From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SAMSUNG: Use kmemdup rather than duplicating its implementation
Date: Wed, 07 Dec 2011 15:57:07 +0900 [thread overview]
Message-ID: <03e001ccb4ad$6f76a490$4e63edb0$%kim@samsung.com> (raw)
In-Reply-To: <1321569820.1624.268.camel@localhost.localdomain>
Thomas Meyer wrote:
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/memdup.cocci.
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
> --- a/arch/arm/plat-s3c24xx/dma.c 2011-11-07 19:37:20.736205210 +0100
> +++ b/arch/arm/plat-s3c24xx/dma.c 2011-11-08 11:03:41.719762852 +0100
> @@ -1437,11 +1437,10 @@ int __init s3c24xx_dma_init_map(struct s
> size_t map_sz = sizeof(*nmap) * sel->map_size;
> int ptr;
>
> - nmap = kmalloc(map_sz, GFP_KERNEL);
> + nmap = kmemdup(sel->map, map_sz, GFP_KERNEL);
> if (nmap == NULL)
> return -ENOMEM;
>
> - memcpy(nmap, sel->map, map_sz);
> memcpy(&dma_sel, sel, sizeof(*sel));
>
> dma_sel.map = nmap;
Yes, looks ok to me, will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2011-12-07 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 22:43 [PATCH] ARM: SAMSUNG: Use kmemdup rather than duplicating its implementation Thomas Meyer
2011-12-07 6:57 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='03e001ccb4ad$6f76a490$4e63edb0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).