From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
martin.botka@somainline.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, paul.bouchara@somainline.org,
kernel@collabora.com
Subject: Re: [PATCH 5/7] arm64: dts: mediatek: mt6795: Add fixed clocks for 32kHz and 26MHz XOs
Date: Mon, 16 May 2022 09:10:01 +0200 [thread overview]
Message-ID: <03e99a02-1233-3882-e1e5-24ab1bbaf257@linaro.org> (raw)
In-Reply-To: <20220513171617.504430-6-angelogioacchino.delregno@collabora.com>
On 13/05/2022 19:16, AngeloGioacchino Del Regno wrote:
> Add the 32kHz and 26MHz oscillators as fixed clocks in devicetree to
> provide a good initial clock spec, since this SoC features two always
I don't understand that part with actual patch. You claim here you add
clocks, but in DTS they were already before.
Additionally, these clocks do not belong to DTSI because, AFAIU, these
are properties of boards. At least their frequencies should be moved to
the board DTS.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-16 7:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 17:16 [PATCH 0/7] MediaTek Helio X10 MT6795 - Devicetree, part 1 AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 1/7] arm64: dts: mediatek: mt6795: Create soc bus node and move mmio devices AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 2/7] arm64: dts: mediatek: mt6795: Add cpu-map and L2 cache AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 3/7] arm64: dts: mediatek: mt6795: Add Cortex A53 PMU nodes AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 4/7] arm64: dts: mediatek: mt6795: Add watchdog node to avoid timeouts AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 5/7] arm64: dts: mediatek: mt6795: Add fixed clocks for 32kHz and 26MHz XOs AngeloGioacchino Del Regno
2022-05-16 7:10 ` Krzysztof Kozlowski [this message]
2022-05-16 8:51 ` AngeloGioacchino Del Regno
2022-05-16 14:51 ` Krzysztof Kozlowski
2022-05-17 8:14 ` AngeloGioacchino Del Regno
2022-05-17 8:18 ` Krzysztof Kozlowski
2022-05-13 17:16 ` [PATCH 6/7] arm64: dts: mediatek: mt6795: Add general purpose timer node AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 7/7] arm64: dts: mediatek: mt6795: Add ARM CCI-400 node and assign to CPUs AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03e99a02-1233-3882-e1e5-24ab1bbaf257@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=matthias.bgg@gmail.com \
--cc=paul.bouchara@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox