From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01ED6C3DA5D for ; Thu, 25 Jul 2024 06:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:In-Reply-To:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q/JMOXNCI9IdUHR/uZKFylmAXlUN/kcQ+9IuABUEBvU=; b=oT2w6FFHUs6cCQqEeHYWvBjeui HtR5wG9wtZTw/wS2xi/S+BZ9p8TvG22jyCHG3nVr9ln1MMohQrIkc8z3SnT05JGp4qy18vDlA0DT3 D3Nr3RX0Nle9XLJOK4qmkx5fPGZB9eemunaAPeIYShzig++zRvXHPzy/DvF66NyYlZ7sAcHJIbTBI spYusNYrXMJAB/IeFC/y9vE1jELSN6+BCVvyGrbR/jVhnmpnjgMpg0O2iBGrUEpO+SvXlfrKy6l+Z 791RROO8soIYWb2V2eEYm97viZhCK/54MQD88QKCmN/l3wO0OK29ULxzRY7BXUNJ2bsWzYcJ8gy/p 4XrOGTqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWs4o-000000003Mk-3Mib; Thu, 25 Jul 2024 06:35:46 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWs4P-000000003Ff-3SbC for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2024 06:35:24 +0000 Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20240725063515epoutp025bf708b1c5b34d8fde656ad9f0eacfe1~lYTW73Ek21169911699epoutp02E for ; Thu, 25 Jul 2024 06:35:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20240725063515epoutp025bf708b1c5b34d8fde656ad9f0eacfe1~lYTW73Ek21169911699epoutp02E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1721889315; bh=Q/JMOXNCI9IdUHR/uZKFylmAXlUN/kcQ+9IuABUEBvU=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=FRqymAFddXF5gFQu9jv0oFs+pnxIytg+JZ1883zxWnE3GRl+4bBBeBf0dVXR6LKqM BpCZzJNI5rU6CDlG4e9iMXEBVDEwNmN/A9WY99bCS1AFErFww71otXyaRn4Q3ShwQg DMy9q7jBwF50bHXcjdcyUab/H+0s1l31RUEGBa/o= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas2p4.samsung.com (KnoxPortal) with ESMTP id 20240725063515epcas2p4155ab51c7d628eb495bc982f500917dc~lYTWmyqqT1591615916epcas2p4Q; Thu, 25 Jul 2024 06:35:15 +0000 (GMT) Received: from epsmgec2p1.samsung.com (unknown [182.195.36.99]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4WV1N26ppXz4x9Q1; Thu, 25 Jul 2024 06:35:14 +0000 (GMT) Received: from epcas2p2.samsung.com ( [182.195.41.54]) by epsmgec2p1.samsung.com (Symantec Messaging Gateway) with SMTP id 21.69.08901.222F1A66; Thu, 25 Jul 2024 15:35:14 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPA id 20240725063514epcas2p33cc67418bd936a63d962c537e115b9d7~lYTVfetAc1527215272epcas2p3B; Thu, 25 Jul 2024 06:35:14 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240725063514epsmtrp2ed5d2a671999752d747211735a0f25bf~lYTVegRgg0045000450epsmtrp2w; Thu, 25 Jul 2024 06:35:14 +0000 (GMT) X-AuditID: b6c32a43-a0fff700000022c5-2b-66a1f222c37a Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id E1.C9.08964.222F1A66; Thu, 25 Jul 2024 15:35:14 +0900 (KST) Received: from KORCO118965 (unknown [10.229.18.201]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20240725063514epsmtip2ed131260699e7af5f09a30fb6eba5e02~lYTVLydhz1744317443epsmtip2N; Thu, 25 Jul 2024 06:35:14 +0000 (GMT) From: "sunyeal.hong" To: "'Krzysztof Kozlowski'" , "'Rob Herring'" Cc: "'Sylwester Nawrocki'" , "'Chanwoo Choi'" , "'Alim Akhtar'" , "'Michael Turquette'" , "'Stephen Boyd'" , "'Conor Dooley'" , , , , , In-Reply-To: Subject: RE: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU bindings Date: Thu, 25 Jul 2024 15:35:13 +0900 Message-ID: <03ef01dade5c$ce407820$6ac16860$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKlY5hu3bVCnsOExtpi/jJA6pOgwAIfj46DASLmYXQCkOemkQII707mAaDCc8MCEkcIaLAVdPGg Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMJsWRmVeSWpSXmKPExsWy7bCmma7Sp4VpBtN3GFo8mLeNzWLN3nNM Fte/PGe1mH/kHKvF+fMb2C02Pb7GavGx5x6rxeVdc9gsZpzfx2Rx8ZSrxf89O9gtDr9pZ7X4 d20jiwOvx/sbrewem1Z1snlsXlLv0bdlFaPH501yAaxR2TYZqYkpqUUKqXnJ+SmZeem2St7B 8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QCcqKZQl5pQChQISi4uV9O1sivJLS1IVMvKL S2yVUgtScgrMC/SKE3OLS/PS9fJSS6wMDQyMTIEKE7Izdj+dwF5wWqri58tm1gbGx8JdjBwc EgImEoe3+3QxcnEICexglLj24BIzhPOJUaLp0i9GCOcbo8SGBeeYuhg5wTrO7TnADpHYyyjx 79c8qJaXjBKn325hBaliE9CXWN19mw3EFhEIkti2bQ0LSBGzwC5miZ7d3cwgCU4BO4lzCz+C 2cICYRJbZ3QwghzFIqAqca9VCiTMK2ApsX1tGzuELShxcuYTFhCbWUBbYtnC18wQFylI/Hy6 jBViV5TEw1kNbBA1IhKzO9vAjpMQOMAhsefLFnaIBheJlXf/QtnCEq+Ow8SlJD6/28sGYedL TL7+lgmiuQEYMv+6obbZSyw685Md5FBmAU2J9bv0IQGpLHHkFtRtfBIdh/+yQ4R5JTrahCAa 1SQ+XbkMNURG4tiJZ8wTGJVmIflsFpLPZiH5YBbCrgWMLKsYxVILinPTU5ONCgzhkZ2cn7uJ EZx6tZx3MF6Z/0/vECMTB+MhRgkOZiUR3mX3F6YJ8aYkVlalFuXHF5XmpBYfYjQFBvVEZinR 5Hxg8s8riTc0sTQwMTMzNDcyNTBXEue91zo3RUggPbEkNTs1tSC1CKaPiYNTqoFpJmdGs9qV 3EXvdm5e2fza9O/nxN+C4Y9+2BX//XTPaM4uF7sJP28eXX3DTHnH+c9bVrdI318UEsB3oIhv 3dLpr+vs8jbpPfIM9NrxWH/pzRvbzt1gODt3QemC5KUqK443fLKSN1X+yS2t/WvyBuk3D0Wb pcTfcbHxrq+Jna9iqXfvyv9zCwz2WzyUbJooeruez/90zusvU27UWHF9mT27PEVTcvnl4Olt 22uEnqZP8hPIeXDXpn17TBYjw6Xjj7YbChuErntevsWMb1JJEvOMRGuOXSe+OzdV64j1uM+M ubrNsDv5htvXrzd0Hi9gj10pzC6tnPZpltuH2wJS+Wtb1xptMLj1cGfJlbiZQebrOJVYijMS DbWYi4oTAWD0/IxGBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsWy7bCSvK7Sp4VpBstecVs8mLeNzWLN3nNM Fte/PGe1mH/kHKvF+fMb2C02Pb7GavGx5x6rxeVdc9gsZpzfx2Rx8ZSrxf89O9gtDr9pZ7X4 d20jiwOvx/sbrewem1Z1snlsXlLv0bdlFaPH501yAaxRXDYpqTmZZalF+nYJXBlHdy1mLWiQ qri6bxpbA+M04S5GTg4JAROJc3sOsHcxcnEICexmlNjYsZkZIiEjsbHhPzuELSxxv+UIK0TR c0aJVx+vsIAk2AT0JVZ332YDsUUEgiS2/X8EVsQscIhZ4kffZBaIjn9MEtc3nGICqeIUsJM4 t/Aj2AphgRCJyYtageIcHCwCqhL3WqVAwrwClhLb17axQ9iCEidnPgFbxiygLdH7sJURxl62 8DXUpQoSP58uY4U4Ikri4awGNogaEYnZnW3MExiFZyEZNQvJqFlIRs1C0rKAkWUVo2RqQXFu em6xYYFhXmq5XnFibnFpXrpecn7uJkZwJGpp7mDcvuqD3iFGJg7GQ4wSHMxKIrzL7i9ME+JN SaysSi3Kjy8qzUktPsQozcGiJM4r/qI3RUggPbEkNTs1tSC1CCbLxMEp1cBk2ru5Q1AtVstw sle8ptACp/UW+gaCVmrT/I0VOKZkWGxxzNseM0HvsPDr/fV9L3atqJp78on/pbM3U7WPhgoI Z3LLhtREVfh9WtM+WegEe3T5lJcajxNcwpcwVG5kLL98ZfL/r3JpVWtPM93cf1KgIz33ovcr 3fDZJs0P9d/v3Ch93cBY/bVee0eXtdTCgtw+xSmn3riuWVi9VYAp74lnydxyB/XEZc7bHzAc 4TCYuumWVF7+8rC5L3oaShSWFoY7u2z8rxjx4/bJN5uufj5qfYh3/77zm585WjtnPd+s//bl xbCNcutiJIUmL+Q9lmF85rkNV+vkXYxurefPOO7iOOPz4Wyo/ta9rsGpO6uUWIozEg21mIuK EwEzQAaBMwMAAA== X-CMS-MailID: 20240725063514epcas2p33cc67418bd936a63d962c537e115b9d7 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20240722223340epcas2p4ab83b1e8dbc64eaaf32f4f8b7e3f015d References: <20240722223333.1137947-1-sunyeal.hong@samsung.com> <20240722223333.1137947-2-sunyeal.hong@samsung.com> <20240723205714.GA1093352-robh@kernel.org> <035501dade31$55cc7f40$01657dc0$@samsung.com> <03b201dade3f$3d66e3b0$b834ab10$@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_233522_542691_53ADD106 X-CRM114-Status: GOOD ( 21.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski > Sent: Thursday, July 25, 2024 3:21 PM > To: sunyeal.hong ; 'Rob Herring' > > Cc: 'Sylwester Nawrocki' ; 'Chanwoo Choi' > ; 'Alim Akhtar' ; 'Mi= chael > Turquette' ; 'Stephen Boyd' ; > 'Conor Dooley' ; linux-samsung-soc=40vger.kernel.o= rg; > linux-clk=40vger.kernel.org; devicetree=40vger.kernel.org; linux-arm- > kernel=40lists.infradead.org; linux-kernel=40vger.kernel.org > Subject: Re: =5BPATCH v4 1/4=5D dt-bindings: clock: add ExynosAuto v920 S= oC > CMU bindings >=20 > On 25/07/2024 05:03, sunyeal.hong wrote: >=20 > > - dts > > cmu_misc: clock-controller=4010020000 =7B > > compatible =3D =22samsung,exynosautov920-cmu-misc=22; > > reg =3D <0x10020000 0x8000>; > > =23clock-cells =3D <1>; > > > > clocks =3D <&xtcxo>, > > <&cmu_top DOUT_CLKCMU_MISC_NOC>; > > clock-names =3D =22oscclk=22, > > =22noc=22; > > =7D; > > > > In this case, can you tell me how to handle it? > > And if a new clock item is added and a new cmu block uses only the cloc= k > item added and oscclk, a problem may occur. >=20 > The same problem was in your original version, so why suddenly it appeare= d? >=20 > Anyway, why clock would be missing? You just wrote in the bindings that > there is such input clock. >=20 > Best regards, > Krzysztof >=20 If I reflect Rob's review, it will be changed as below. - yaml properties: compatible: enum: - samsung,exynosautov920-cmu-top - samsung,exynosautov920-cmu-peric0 clocks: minItems: 1 items: - description: External reference clock (38.4 MHz) - description: Block IP clock (from CMU_TOP) - description: Block NOC clock (from CMU_TOP) clock-names: minItems: 1 items: - const: oscclk - const: ip - const: noc =22=23clock-cells=22: const: 1 reg: maxItems: 1 if: properties: compatible: enum: - samsung,exynosautov920-cmu-misc then: properties: clocks: minItems: 2 maxItems: 2 clock-names: minItems: 2 maxItems: 2 - device tree cmu_misc: clock-controller=4010020000 =7B compatible =3D =22samsung,exynosautov920-cmu-misc=22; reg =3D <0x10020000 0x8000>; =23clock-cells =3D <1>; clocks =3D <&xtcxo>, <&cmu_top DOUT_CLKCMU_MISC_NOC>; clock-names =3D =22oscclk=22, =22noc=22; =7D; In this case, ip should be used after oscclk, but misc does not use ip, so = there is a problem in dt check. The code of v4 version has clock items for each block, so there was no prob= lem like this. - yaml(v4) if: properties: compatible: contains: const: samsung,exynosautov920-cmu-misc then: properties: clocks: items: - description: External reference clock (38.4 MHz) - description: CMU_MISC NOC clock (from CMU_MISC) clock-names: items: - const: oscclk - const: noc If there is anything I misunderstand, please guide me. Thanks, Sunyeal Hong.