From: Philippe CORNU <philippe.cornu@st.com>
To: Fabien DESSENNE <fabien.dessenne@st.com>,
Yannick FERTRE <yannick.fertre@st.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Vincent ABRIOU <vincent.abriou@st.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] drm/stm: ltdc: return appropriate error code during probe
Date: Fri, 26 Apr 2019 12:30:22 +0000 [thread overview]
Message-ID: <03f53dcc-816f-c017-f420-5eacc1fa486d@st.com> (raw)
In-Reply-To: <1556114601-30936-3-git-send-email-fabien.dessenne@st.com>
Hi Fabien,
and thank you for your patch,
Acked-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
On 4/24/19 4:03 PM, Fabien Dessenne wrote:
> During probe, return the "clk_get" error value instead of -ENODEV.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 521ba83..97912e2 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1145,8 +1145,9 @@ int ltdc_load(struct drm_device *ddev)
>
> ldev->pixel_clk = devm_clk_get(dev, "lcd");
> if (IS_ERR(ldev->pixel_clk)) {
> - DRM_ERROR("Unable to get lcd clock\n");
> - return -ENODEV;
> + if (PTR_ERR(ldev->pixel_clk) != -EPROBE_DEFER)
> + DRM_ERROR("Unable to get lcd clock\n");
> + return PTR_ERR(ldev->pixel_clk);
> }
>
> if (clk_prepare_enable(ldev->pixel_clk)) {
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-26 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 14:03 [PATCH 0/2] drm/stm: ltdc: manage error cases in probe Fabien Dessenne
2019-04-24 14:03 ` [PATCH 1/2] drm/stm: ltdc: manage the get_irq probe defer case Fabien Dessenne
2019-04-26 12:29 ` Philippe CORNU
2019-05-06 7:25 ` Benjamin Gaignard
2019-04-24 14:03 ` [PATCH 2/2] drm/stm: ltdc: return appropriate error code during probe Fabien Dessenne
2019-04-26 12:30 ` Philippe CORNU [this message]
2019-05-06 7:25 ` Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03f53dcc-816f-c017-f420-5eacc1fa486d@st.com \
--to=philippe.cornu@st.com \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabien.dessenne@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=vincent.abriou@st.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).