From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9135D26D75 for ; Fri, 9 Jan 2026 17:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B+3UzmwLO8JN/qBdtE9TBLXhBi+5lAbLM+z0XA6YawY=; b=iEjlVafKvQK029aAbLjz2Y1g62 3RQwgSaP4HFO8+ghdbfuF2tikoy2nuFYjX/WkMenC2ZaMdxUQEkTiXKfdGo6b3EhS86cdnnqJx4q9 m1edI5yPFEAthIGZ5egT5mimEC4NpSJ1HgwBilbTSBXmB4JJoCgfJXOleJRoPxX59VQ/jv7QALKaa xv3Rf53OuWWZANN9Gi1dN1dunTz69uuppugc+HszAANJd7LFRCw9IN3i4z3Y/x96DmtqLx71lR1V7 lUa0I4r73ngsl+T4dG7zd0a5+ZY9Ca5g0svBn+kE9R/2WX0LjIyCwGrrrenb40CvGrFCIxh/Ni9O4 nDTJlZYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1veFtr-00000002hcE-10st; Fri, 09 Jan 2026 17:03:47 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1veFto-00000002hbR-3JTl for linux-arm-kernel@lists.infradead.org; Fri, 09 Jan 2026 17:03:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1767978223; x=1799514223; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=HAnLULaMUOc5Nc5jyCi1DTCw+t7mBlxZV/qBH8OF/pw=; b=BfmEoMhFBhwzbfkFMEguKpsPmJxn5Unjqgy5AU4r7eHN7XWSXmFDiWRe 3VAbMky11FTDKQyROp6b5zlsFM+XrXW/ZA3lKTVnfEjYhJI3hXY+CrJM3 ig5Ab/0qCPvE/SUhIaxZOnC55NWpTppJWsE6CxI21CASgGQF/cTrjljKF PHGd1XHxq+9PCRTiCPshe6CZY9HVpnJdqq2Hj+i7IU0HKCWZSKKSEagzN fcWf6MAnMu6fKr7ncOHgthCTK/eLjvhhBUR8GwXaVHtTvxrjmwEcH70QF FIiX0as64NvMjYgJz1y1D0P47dTSLhjs+Or32qi4xNCD+yfoKb4CU0Uq8 A==; X-CSE-ConnectionGUID: RKd1RUMeRFOIyoqLuXNK1Q== X-CSE-MsgGUID: SNK/4r0HSISKVG1n6XCSeg== X-IronPort-AV: E=Sophos;i="6.21,214,1763449200"; d="scan'208";a="50915444" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2026 10:03:40 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.87.152) by chn-vm-ex1.mchp-main.com (10.10.87.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.29; Fri, 9 Jan 2026 10:03:25 -0700 Received: from [10.10.179.162] (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Fri, 9 Jan 2026 10:03:25 -0700 Message-ID: <0402804e-7575-42b2-9990-1b09fca80451@microchip.com> Date: Fri, 9 Jan 2026 10:03:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 21/31] clk: at91: dt-compat: switch to parent_hw and parent_data To: Claudiu Beznea , , , , CC: , , , References: <628859234f4b2523f43b3ac05d5e29ceb05a7f61.1758226719.git.Ryan.Wanner@microchip.com> From: Ryan Wanner Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260109_090345_136926_DFF89D1D X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/20/25 12:15, Claudiu Beznea wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi, Ryan, > > On 9/19/25 00:16, Ryan.Wanner@microchip.com wrote: >> From: Claudiu Beznea >> >> Switch old dt-compat clocks to use parent_hw and parent_data. Having >> parent_hw instead of parent names improves to clock registration >> speed and re-parenting. >> >> Signed-off-by: Claudiu Beznea >> Signed-off-by: Ryan Wanner >> --- >> drivers/clk/at91/dt-compat.c | 80 +++++++++++++++++++++++++----------- >> 1 file changed, 56 insertions(+), 24 deletions(-) >> >> diff --git a/drivers/clk/at91/dt-compat.c b/drivers/clk/at91/dt-compat.c >> index fa8658d3be7b..9ca871b817e0 100644 >> --- a/drivers/clk/at91/dt-compat.c >> +++ b/drivers/clk/at91/dt-compat.c >> @@ -43,7 +43,8 @@ static void __init of_sama5d2_clk_audio_pll_frac_setup(struct device_node *np) >> >> parent_name = of_clk_get_parent_name(np, 0); >> >> - hw = at91_clk_register_audio_pll_frac(regmap, name, parent_name, NULL); >> + hw = at91_clk_register_audio_pll_frac(regmap, name, NULL, >> + &AT91_CLK_PD_NAME(parent_name)); >> if (IS_ERR(hw)) >> return; >> >> @@ -69,7 +70,8 @@ static void __init of_sama5d2_clk_audio_pll_pad_setup(struct device_node *np) >> >> parent_name = of_clk_get_parent_name(np, 0); >> >> - hw = at91_clk_register_audio_pll_pad(regmap, name, parent_name, NULL); >> + hw = at91_clk_register_audio_pll_pad(regmap, name, NULL, >> + &AT91_CLK_PD_NAME(parent_name)); >> if (IS_ERR(hw)) >> return; >> >> @@ -95,7 +97,7 @@ static void __init of_sama5d2_clk_audio_pll_pmc_setup(struct device_node *np) >> >> parent_name = of_clk_get_parent_name(np, 0); >> >> - hw = at91_clk_register_audio_pll_pmc(regmap, name, parent_name, NULL); >> + hw = at91_clk_register_audio_pll_pmc(regmap, name, NULL, &AT91_CLK_PD_NAME(parent_name)); >> if (IS_ERR(hw)) >> return; >> >> @@ -129,6 +131,7 @@ static void __init of_sama5d2_clk_generated_setup(struct device_node *np) >> struct clk_hw *hw; >> unsigned int num_parents; >> const char *parent_names[GENERATED_SOURCE_MAX]; >> + struct clk_parent_data parent_data[GENERATED_SOURCE_MAX]; >> struct device_node *gcknp, *parent_np; >> struct clk_range range = CLK_RANGE(0, 0); >> struct regmap *regmap; >> @@ -149,6 +152,8 @@ static void __init of_sama5d2_clk_generated_setup(struct device_node *np) >> if (IS_ERR(regmap)) >> return; >> >> + for (unsigned int i = 0; i < num_parents; i++) >> + parent_data[i] = AT91_CLK_PD_NAME(parent_names[i]); >> for_each_child_of_node(np, gcknp) { >> int chg_pid = INT_MIN; >> >> @@ -171,7 +176,7 @@ static void __init of_sama5d2_clk_generated_setup(struct device_node *np) >> >> hw = at91_clk_register_generated(regmap, &pmc_pcr_lock, >> &dt_pcr_layout, name, >> - parent_names, NULL, NULL, >> + NULL, parent_data, NULL, >> num_parents, id, &range, >> chg_pid); >> if (IS_ERR(hw)) >> @@ -201,7 +206,7 @@ static void __init of_sama5d4_clk_h32mx_setup(struct device_node *np) >> >> parent_name = of_clk_get_parent_name(np, 0); >> >> - hw = at91_clk_register_h32mx(regmap, name, parent_name, NULL); >> + hw = at91_clk_register_h32mx(regmap, name, NULL, &AT91_CLK_PD_NAME(parent_name)); >> if (IS_ERR(hw)) >> return; >> >> @@ -228,6 +233,8 @@ static void __init of_sama5d2_clk_i2s_mux_setup(struct device_node *np) >> return; >> >> for_each_child_of_node(np, i2s_mux_np) { >> + struct clk_parent_data parent_data[2]; >> + >> if (of_property_read_u8(i2s_mux_np, "reg", &bus_id)) >> continue; >> >> @@ -238,8 +245,10 @@ static void __init of_sama5d2_clk_i2s_mux_setup(struct device_node *np) >> if (ret != 2) >> continue; >> >> + parent_data[0] = AT91_CLK_PD_NAME(parent_names[0]); >> + parent_data[1] = AT91_CLK_PD_NAME(parent_names[1]); >> hw = at91_clk_i2s_mux_register(regmap_sfr, i2s_mux_np->name, >> - parent_names, NULL, 2, bus_id); >> + NULL, parent_data, 2, bus_id); >> if (IS_ERR(hw)) >> continue; >> >> @@ -269,7 +278,8 @@ static void __init of_at91rm9200_clk_main_osc_setup(struct device_node *np) >> if (IS_ERR(regmap)) >> return; >> >> - hw = at91_clk_register_main_osc(regmap, name, parent_name, NULL, bypass); >> + hw = at91_clk_register_main_osc(regmap, name, NULL, >> + &AT91_CLK_PD_NAME(parent_name), bypass); >> if (IS_ERR(hw)) >> return; >> >> @@ -323,7 +333,7 @@ static void __init of_at91rm9200_clk_main_setup(struct device_node *np) >> if (IS_ERR(regmap)) >> return; >> >> - hw = at91_clk_register_rm9200_main(regmap, name, parent_name, NULL); >> + hw = at91_clk_register_rm9200_main(regmap, name, NULL, &AT91_CLK_PD_NAME(parent_name)); >> if (IS_ERR(hw)) >> return; >> >> @@ -336,6 +346,7 @@ static void __init of_at91sam9x5_clk_main_setup(struct device_node *np) >> { >> struct clk_hw *hw; >> const char *parent_names[2]; >> + struct clk_parent_data parent_data[2]; >> unsigned int num_parents; >> const char *name = np->name; >> struct regmap *regmap; >> @@ -354,7 +365,9 @@ static void __init of_at91sam9x5_clk_main_setup(struct device_node *np) >> >> of_property_read_string(np, "clock-output-names", &name); >> >> - hw = at91_clk_register_sam9x5_main(regmap, name, parent_names, NULL, >> + parent_data[0] = AT91_CLK_PD_NAME(parent_names[0]); >> + parent_data[1] = AT91_CLK_PD_NAME(parent_names[1]); >> + hw = at91_clk_register_sam9x5_main(regmap, name, NULL, parent_data, >> num_parents); >> if (IS_ERR(hw)) >> return; >> @@ -396,6 +409,7 @@ of_at91_clk_master_setup(struct device_node *np, >> struct clk_hw *hw; >> unsigned int num_parents; >> const char *parent_names[MASTER_SOURCE_MAX]; >> + struct clk_parent_data parent_data[MASTER_SOURCE_MAX]; >> const char *name = np->name; >> struct clk_master_characteristics *characteristics; >> struct regmap *regmap; >> @@ -419,13 +433,15 @@ of_at91_clk_master_setup(struct device_node *np, >> if (IS_ERR(regmap)) >> return; >> >> + for (unsigned int i = 0; i < MASTER_SOURCE_MAX; i++) >> + parent_data[i] = AT91_CLK_PD_NAME(parent_names[i]); >> hw = at91_clk_register_master_pres(regmap, "masterck_pres", num_parents, >> - parent_names, NULL, layout, >> + NULL, parent_data, layout, >> characteristics, &mck_lock); >> if (IS_ERR(hw)) >> goto out_free_characteristics; >> >> - hw = at91_clk_register_master_div(regmap, name, "masterck_pres", NULL, >> + hw = at91_clk_register_master_div(regmap, name, NULL, &AT91_CLK_PD_HW(hw), >> layout, characteristics, >> &mck_lock, CLK_SET_RATE_GATE, 0); > > Looks like at91_clk_register_master_div() could be kept to use parent_hws > instead of parent_data. Looking into this more the register_master_div calls at91_clk_register_master_internal() which is used for all of the SoCs. Some of the SoCs that use this function only have the parents passed in by name string and not clk_hw. Would it be wise to add another function for this to account for clk_hw and parent name? Or keep the use of parent_data? Ryan