From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D3BCC38A2B for ; Fri, 17 Apr 2020 11:17:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41D48208E4 for ; Fri, 17 Apr 2020 11:17:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="merj8/0C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41D48208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DuX0H6zF0gBhj5ra/xZFfZBSiejXvxIlmZAeQ2GEu+Q=; b=merj8/0CUQ6eDE AkOT8jLn4sUzIcjun86z2erJKryuJRAqdN6X3bE+ofIBsM6jrxGiTUD2FHcSEkkh80rwEuDQK9+7j RqftPGw8w94W+ySjp/I2a9VZWTvRcZdjIGcvBBO8C+W4zHPKnc/dKGff7bnpJUlucj+sqh2vTT72p km1/0c/KmCmwEXwrt3E2bVlLYfS3b0gB7IJ0QY9y1ZbaY9tXC6sHInwtrMU3zdfJz3SMVLyXdcQIM 5eRiTlcSX2vXGbIvM3p0sU/FvGNTTcUcHRXCkWDAcQxuGa3rGWuA1+j73UtOuorYaIauYOSJQGVGl THyCWXNGWVnsDZuyt00g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPOzx-0001fz-JE; Fri, 17 Apr 2020 11:17:29 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPOzv-0001eE-9q for linux-arm-kernel@lists.infradead.org; Fri, 17 Apr 2020 11:17:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 72186C14; Fri, 17 Apr 2020 04:17:25 -0700 (PDT) Received: from [192.168.0.14] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 004173F6C4; Fri, 17 Apr 2020 04:17:23 -0700 (PDT) Subject: Re: [PATCH v2 3/6] KVM: arm: vgic: Only use the virtual state when userspace accesses enable bits To: Marc Zyngier References: <20200417083319.3066217-1-maz@kernel.org> <20200417083319.3066217-4-maz@kernel.org> From: James Morse Message-ID: <040579d5-151f-5263-9f5f-69f86965dfc6@arm.com> Date: Fri, 17 Apr 2020 12:17:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200417083319.3066217-4-maz@kernel.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200417_041727_384600_80DE6FCD X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , kvm@vger.kernel.org, Suzuki K Poulose , Andre Przywara , Eric Auger , Julien Thierry , Zenghui Yu , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On 17/04/2020 09:33, Marc Zyngier wrote: > There is no point in accessing the HW when writing to any of the > ISENABLER/ICENABLER registers from userspace, as only the guest > should be allowed to change the HW state. > > Introduce new userspace-specific accessors that deal solely with > the virtual state. > > Reported-by: James Morse Tested on both machines I've hit this on: Tested-by: James Morse and perhaps more useful: Reviewed-by: James Morse Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel