From: sbkim73@samsung.com (Sangbeom Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 3/3] SoC: SAMSUNG: Add WM8580 PCM Machine driver
Date: Thu, 07 Apr 2011 11:05:22 +0900 [thread overview]
Message-ID: <041801cbf4c8$51ca7390$f55f5ab0$@com> (raw)
In-Reply-To: <20110407011704.GA21071@sirena.org.uk>
Hi Mark,
On Thu, Apr 07, 2011 at 10:17:10AM +0900, Mark Brown wrote:
> > +config SND_SOC_SAMSUNG_SMDK_WM8580_PCM
> > + tristate
> > +
>
> What is the purpose of this variable? Just the config for the machine
> should be enough.
Ok, I will remove it and use machine config.
>
> > @@ -1,12 +1,12 @@
> > -# S3c24XX Platform Support
> > +# SAMSUNG Platform Support
> > snd-soc-s3c24xx-objs := dma.o
> > snd-soc-s3c24xx-i2s-objs := s3c24xx-i2s.o
> > snd-soc-s3c2412-i2s-objs := s3c2412-i2s.o
> > snd-soc-ac97-objs := ac97.o
> > snd-soc-s3c-i2s-v2-objs := s3c-i2s-v2.o
> > snd-soc-samsung-spdif-objs := spdif.o
> > -snd-soc-pcm-objs := pcm.o
> > -snd-soc-i2s-objs := i2s.o
> > +snd-soc-samsung-pcm-objs := pcm.o
> > +snd-soc-samsung-i2s-objs := i2s.o
>
> These changes all look reasonable but they're unrelated to adding the
> machine driver and should be split out.
Ok, I will split out.
>
> > diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
> > index 38aac7d..9c7e8b4 100644
> > --- a/sound/soc/samsung/pcm.c
> > +++ b/sound/soc/samsung/pcm.c
> > @@ -350,8 +350,8 @@ static int s3c_pcm_set_fmt(struct snd_soc_dai
> *cpu_dai,
> > ctl = readl(regs + S3C_PCM_CTL);
> >
> > switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
> > - case SND_SOC_DAIFMT_NB_NF:
> > - /* Nothing to do, NB_NF by default */
> > + case SND_SOC_DAIFMT_IB_NF:
> > + /* Nothing to do, IB_NF by default */
> > break;
>
> Similarly here, this is a bug fix so should be merged for 2.6.39.
I will submit another bug fix patch for this.
>
> > + smdk_snd_device = platform_device_alloc("soc-audio", -1);
> > + if (!smdk_snd_device)
> > + return -ENOMEM;
>
> Please use snd_soc_register_card() for new machines rather than the
> soc-audio device. Otherwise the actual driver itself looks good.
Ok I will apply it.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Thanks and Regards,
SB Kim
next prev parent reply other threads:[~2011-04-07 2:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 0:31 [PATCH 0/3] Add WM8580 PCM Machine driver for Samsung SoCs Sangbeom Kim
2011-04-07 0:31 ` [PATCH 1/3] ARM: S5PV210: Add PCM audio support for WM8580 Sangbeom Kim
2011-04-07 0:31 ` [PATCH 2/3] ARM: S5P64X0: " Sangbeom Kim
2011-04-07 0:31 ` [alsa-devel][PATCH 3/3] SoC: SAMSUNG: Add WM8580 PCM Machine driver Sangbeom Kim
2011-04-07 1:17 ` [alsa-devel] [PATCH " Mark Brown
2011-04-07 2:05 ` Sangbeom Kim [this message]
2011-04-07 3:43 ` [alsa-devel][PATCH " Jassi Brar
2011-04-07 4:44 ` [alsa-devel] [PATCH " Sangbeom Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='041801cbf4c8$51ca7390$f55f5ab0$@com' \
--to=sbkim73@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox