From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98970C67861 for ; Fri, 5 Apr 2024 11:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LJMMe5fDzbdtMFN8QTwlxOfBIZNg2uJyCiS26G/bu30=; b=SI9p9N7ONAgCh9 svCqlQ6ijsHbo+d3PlqSF+lCdSqtoVQn7BMjV9bopvqPcDRegVa+rU8Rq5hBP0cpPI8TKVgjM+NVc Oz2uRFQoMHJ/xYr63vhpsYLl/FT4B6iNKCzULO4CTjkbSrHrlu3Uah0hWjpuT42+XC74JZfcZFuEx YZmdYiujh8R2dsA4mUNg3xoPxCZTUzDncFMNhP3psEIJgsmBLoIJG2hxFG1xE6GAxYzo6lYvy319v OxZwJaLBHpzXa1CGN8MyNPZwiEpJmWcSFyWFwh5+sprKHDCJObkEUCRRYbDmR4pztdaSvfkwYdiEv I96o8A4Q6oNoBg+znUkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rshqR-00000006hcA-0Ocg; Fri, 05 Apr 2024 11:34:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsgtR-00000006SdC-1p9x for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2024 10:33:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C4E54FEC; Fri, 5 Apr 2024 03:34:24 -0700 (PDT) Received: from [10.57.54.111] (unknown [10.57.54.111]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D6D873F64C; Fri, 5 Apr 2024 03:33:52 -0700 (PDT) Message-ID: <042bbb32-481e-40d8-a46a-472b724ec33f@arm.com> Date: Fri, 5 Apr 2024 11:33:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf: arm_cspmu: Don't touch interrupt registers if no interrupt was assigned Content-Language: en-GB To: Ilkka Koskinen , Besar Wicaksono , Suzuki K Poulose , Will Deacon Cc: Mark Rutland , Raag Jadav , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240307193104.58302-1-ilkka@os.amperecomputing.com> From: Robin Murphy In-Reply-To: <20240307193104.58302-1-ilkka@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_033357_553503_34DA21D6 X-CRM114-Status: GOOD ( 13.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-03-07 7:31 pm, Ilkka Koskinen wrote: > The driver enabled and disabled interrupts even if no interrupt was > assigned to the device. Why's that a concern - if the interrupt isn't routed anywhere, surely it makes no difference what happens at the source end? Thanks, Robin. > Signed-off-by: Ilkka Koskinen > --- > drivers/perf/arm_cspmu/arm_cspmu.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c > index 50b89b989ce7..2cbdb5dcb6ff 100644 > --- a/drivers/perf/arm_cspmu/arm_cspmu.c > +++ b/drivers/perf/arm_cspmu/arm_cspmu.c > @@ -795,7 +795,8 @@ static void arm_cspmu_enable_counter(struct arm_cspmu *cspmu, int idx) > inten_off = PMINTENSET + (4 * reg_id); > cnten_off = PMCNTENSET + (4 * reg_id); > > - writel(BIT(reg_bit), cspmu->base0 + inten_off); > + if (cspmu->irq) > + writel(BIT(reg_bit), cspmu->base0 + inten_off); > writel(BIT(reg_bit), cspmu->base0 + cnten_off); > } > > @@ -810,7 +811,8 @@ static void arm_cspmu_disable_counter(struct arm_cspmu *cspmu, int idx) > cnten_off = PMCNTENCLR + (4 * reg_id); > > writel(BIT(reg_bit), cspmu->base0 + cnten_off); > - writel(BIT(reg_bit), cspmu->base0 + inten_off); > + if (cspmu->irq) > + writel(BIT(reg_bit), cspmu->base0 + inten_off); > } > > static void arm_cspmu_event_update(struct perf_event *event) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel