From: "Sugaya, Taichi" <sugaya.taichi@socionext.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Shinji Kanematsu <kanematsu.shinji@socionext.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Jassi Brar <jaswinder.singh@linaro.org>,
linux-serial@vger.kernel.org,
Takao Orito <orito.takao@socionext.com>,
Kazuhiro Kasai <kasai.kazuhiro@socionext.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 09/15] dt-bindings: serial: Add Milbeaut serial driver description
Date: Tue, 19 Feb 2019 17:11:29 +0900 [thread overview]
Message-ID: <04726ec4-4ee5-3aa8-8b46-2e1293f773f5@socionext.com> (raw)
In-Reply-To: <20190218195713.GA18625@bogus>
Hi,
On 2019/02/19 4:57, Rob Herring wrote:
> On Fri, Feb 08, 2019 at 09:27:29PM +0900, Sugaya Taichi wrote:
>> Add DT bindings document for Milbeaut serial driver.
>>
>> Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
>> ---
>> .../devicetree/bindings/serial/milbeaut-uart.txt | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/serial/milbeaut-uart.txt
>>
>> diff --git a/Documentation/devicetree/bindings/serial/milbeaut-uart.txt b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
>> new file mode 100644
>> index 0000000..8f61c38
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
>> @@ -0,0 +1,21 @@
>> +Socionext Milbeaut UART controller
>> +
>> +Required properties:
>> +- compatible: should be "socionext,milbeaut-usio-uart".
>> +- reg: offset and length of the register set for the device.
>> +- interrupts: two interrupts specifier.
>> +- clocks: phandle to the input clock.
>> +- interrupt-names: should be "rx", "tx".
>
> Put this next to 'interrupts'
>
OK, change the order.
>> +
>> +Optional properties:
>> +- uart-flow-enable: flow control enable.
>
> We already have a standard property for this: auto-flow-control
>
Okay, I change the property name to "auto-flow-control"
>> +
>> +Example:
>> + usio1: usio_uart@1e700010 {
>
> serial@...
>
I got it.
Thanks,
Sugaya Taichi
>> + compatible = "socionext,milbeaut-usio-uart";
>> + reg = <0x1e700010 0x10>;
>> + interrupts = <0 141 0x4>, <0 149 0x4>;
>> + interrupt-names = "rx", "tx";
>> + clocks = <&clk 2>;
>> + uart-flow-enable;
>> + };
>> --
>> 1.9.1
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-02-19 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 12:27 [PATCH v2 09/15] dt-bindings: serial: Add Milbeaut serial driver description Sugaya Taichi
2019-02-18 19:57 ` Rob Herring
2019-02-19 8:11 ` Sugaya, Taichi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04726ec4-4ee5-3aa8-8b46-2e1293f773f5@socionext.com \
--to=sugaya.taichi@socionext.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jaswinder.singh@linaro.org \
--cc=kanematsu.shinji@socionext.com \
--cc=kasai.kazuhiro@socionext.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masami.hiramatsu@linaro.org \
--cc=orito.takao@socionext.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox