From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D67C4338F for ; Tue, 10 Aug 2021 15:12:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE920606A5 for ; Tue, 10 Aug 2021 15:12:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EE920606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=q2yb4HGQhYX5ims4BxI1dGHs+g6vz113pykZCemOWlc=; b=Y/rdeqLdoiSR15XlB2ryRBb3Ho Ozc/DxwWboLHgFQWxJIy2Gw6veVCugGDFqfQMeDpI5HTRfCqooPUdqB0HaRZ4sJI6zs4oL+f1Gb6w KDarDeiIF69OzQR8jvNAQ4aG/gYz4nNEb61xZ9smaPw0YGPkWI5yDjfzsY68QcZhVJ4hJIWcf04fj PvixSdsAhxQMqlWg7bST+U79BdEj57ZEizSaERMyr969QtsOCqb7Owf1a37015rakWJMATknvIDPv 2dULQzuMP7VjGN2khAjoQs0qYZyf3eUMBQMIWeXSVztHLTp1ohz/ESMA4L5WkT5g60sedgTvgQJUh fK9odx3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDTOi-004IQV-4F; Tue, 10 Aug 2021 15:10:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDTOe-004IPo-4q for linux-arm-kernel@lists.infradead.org; Tue, 10 Aug 2021 15:10:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7B3E61FB; Tue, 10 Aug 2021 08:10:26 -0700 (PDT) Received: from [10.163.67.89] (unknown [10.163.67.89]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7D40C3F718; Tue, 10 Aug 2021 08:10:23 -0700 (PDT) Subject: Re: [PATCH 2/5] KVM: arm64: Drop init_common_resources() To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org References: <1628578961-29097-1-git-send-email-anshuman.khandual@arm.com> <1628578961-29097-3-git-send-email-anshuman.khandual@arm.com> <20210810132123.GB2946@willie-the-truck> From: Anshuman Khandual Message-ID: <0480869b-bb08-747a-f4f1-3f77ba4bbed9@arm.com> Date: Tue, 10 Aug 2021 20:41:16 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210810132123.GB2946@willie-the-truck> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_081028_292722_9807458C X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/10/21 6:51 PM, Will Deacon wrote: > On Tue, Aug 10, 2021 at 12:32:38PM +0530, Anshuman Khandual wrote: >> Could do without this additional indirection via init_common_resources() by >> just calling kvm_set_ipa_limit() directly instead. This change saves memory >> and cycles. > > Does it? Really? TBH, I did not really measure them to be sure. It was more like an intuitive assumption. But do you suspect that the compiler might be already optimizing this out, hence giving memory and CPU cycle benefits ? Regardless this still drops an unnecessary function. > > Will > >> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c >> index e9a2b8f27792..19560e457c11 100644 >> --- a/arch/arm64/kvm/arm.c >> +++ b/arch/arm64/kvm/arm.c >> @@ -1696,11 +1696,6 @@ static bool init_psci_relay(void) >> return true; >> } >> >> -static int init_common_resources(void) >> -{ >> - return kvm_set_ipa_limit(); >> -} >> - >> static int init_subsystems(void) >> { >> int err = 0; >> @@ -2102,7 +2097,7 @@ int kvm_arch_init(void *opaque) >> } >> } >> >> - err = init_common_resources(); >> + err = kvm_set_ipa_limit(); >> if (err) >> return err; >> >> -- >> 2.20.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel