From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E612FC43461 for ; Thu, 17 Sep 2020 07:52:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9385821D41 for ; Thu, 17 Sep 2020 07:52:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Qklxumc8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="DGX5qw5a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9385821D41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D8pw7DADLBTUi2vJhVOHboRQT0vMZNrVxgPqezV2hzE=; b=Qklxumc8E/GWZr2bo6wVGKblZ PDff2Q/6/8lCJEdtPIZ4hXRcW74oKI8CH6g/B8LR2QdToEOnx0jONM7mImcLnqEdsvxk4n6rV8q4P QeH11I+gDpR/vJuALj7GJn7m4mAzuIC3BGMIY5s4O1NHFAUeJ2gCTSYzTHoKjQzowx5ObZ+57tIG5 k/t/KZM9gqOT1lxZt0DwYn+BOidMMph/9D1MBKf+oiUqT9twQRkO25EHsi0aRiOcg7i5EeUjc9TUy Gc0L8ncLU8/xsZ8YUzmxjQ/xYiT+PZVOUywk4wB5bMhRwqFMGf0oE5M4RQSn5W/XeD7fN6wDTvYDu mpIJsWtIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIoh2-0001g3-5M; Thu, 17 Sep 2020 07:51:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIogy-0001eH-71 for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 07:50:57 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 86A3B206A2; Thu, 17 Sep 2020 07:50:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600329055; bh=Ykwk+zCIbuxzOUGbtYHyRK5nz7GeslSBQE3W8Jk37wU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DGX5qw5an5iqsqAOZkP1ZkjVnAXaAQXmQDcf/CmRmPjl2bCxSqzRTK76GVlO7BKFm ROcTjkuVz/RGWVJs0Rb11jr6nNGINh1jafORNlQPiSqrqQ8lVEqmenF6Ciqqe3dtUb ljSgnoxXtCKrmMnIhx3wnxwWzHpZshhSFGaIRnF8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kIogv-00CZDd-Ps; Thu, 17 Sep 2020 08:50:53 +0100 MIME-Version: 1.0 Date: Thu, 17 Sep 2020 08:50:53 +0100 From: Marc Zyngier To: Linus Walleij Subject: Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts In-Reply-To: References: <20200901144324.1071694-1-maz@kernel.org> <20200901144324.1071694-9-maz@kernel.org> <933bc43e-3cd7-10ec-b9ec-58afaa619fb7@nvidia.com> <3378cd07b92e87a24f1db75f708424ee@kernel.org> User-Agent: Roundcube Webmail/1.4.8 Message-ID: <049d62ac7de32590cb170714b47fb87d@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: linus.walleij@linaro.org, jonathanh@nvidia.com, m.szyprowski@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sumit.garg@linaro.org, kernel-team@android.com, f.fainelli@gmail.com, linux@arm.linux.org.uk, jason@lakedaemon.net, saravanak@google.com, andrew@lunn.ch, catalin.marinas@arm.com, gregory.clement@bootlin.com, b.zolnierkie@samsung.com, krzk@kernel.org, linux-samsung-soc@vger.kernel.org, tglx@linutronix.de, will@kernel.org, Valentin.Schneider@arm.com, linux-tegra@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_035056_393232_5C2FC17C X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Florian Fainelli , Russell King , Jason Cooper , Saravana Kannan , Andrew Lunn , Catalin Marinas , Gregory Clement , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Jon Hunter , Will Deacon , Linux Samsung SOC , linux-tegra , Thomas Gleixner , kernel-team@android.com, Valentin Schneider , Linux ARM , Marek Szyprowski Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus, On 2020-09-17 08:40, Linus Walleij wrote: > On Wed, Sep 16, 2020 at 5:11 PM Marc Zyngier wrote: > >> Can you try the patch below and let me know? > > I tried this patch and now Ux500 WORKS. So this patch is definitely > something you should apply. > >> - if (is_frankengic()) >> - set_sgi_intid(irqstat); >> + this_cpu_write(sgi_intid, intid); > > This needs changing to irqstat to compile as pointed out by Jon. > > With that: > Tested-by: Linus Walleij Thanks a lot for that. Still need to understand why some of Jon's systems are left unbootable, despite having similar GIC implementations (Tegra194 and Tegra210 use the same GIC-400, and yet only one of the two boots correctly...). Thanks again, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel