From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3108AC433E0 for ; Thu, 2 Jul 2020 06:45:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDCDE20675 for ; Thu, 2 Jul 2020 06:45:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1/4uMP7F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDCDE20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VS/kFVCSuDanw8DC8xP439t6UAVpGSOtyUeiCB4m5Vk=; b=1/4uMP7FhvNM99v+sYaithu2r DuBesPFxleSebAPFTPrKke/vivzjFUBwkqqDeqzY+sGrtEQojuQVl67u+VRBdZuq+hDwS9NjCngck biVrGYLDk5dKKz6Wwn43vcE0blbCThWF3fQvIj0EYfmXrsIdYiNw+DTGNkdp+wFEMN7yGhRJSxUUA T/hFSAsq01OiQP8q1JdrpbhsPKC2c/l1UwYuOconVp9obGFGTWFtZ1j83AFY3SiWsfFhiJTrZTUTG 8GzL+64lScuEG5tKEz/kD98OI3qwxG/Nbg481dSUM9DjP112kdNH6NX9VYnKp9GO1G4TOk5yfVVrw JoOw3JV+w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqsx3-00070B-EZ; Thu, 02 Jul 2020 06:44:05 +0000 Received: from mga09.intel.com ([134.134.136.24]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqsx1-0006zK-3s for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 06:44:04 +0000 IronPort-SDR: 3n/Pz9HeN8rfDfPmZzZM/lexiFeJIB/iA+roLLoaNPfVSqb/Ex7vlfuv4B2gH8fs9ejr21j6A7 sFeTe3qpEQ8g== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="148354252" X-IronPort-AV: E=Sophos;i="5.75,303,1589266800"; d="scan'208";a="148354252" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 23:43:59 -0700 IronPort-SDR: rHXL0bKhROcvkEdkF2ZKwjC3xqd7t/KLFz9uDJIbOqWn8hBk9exjsQ3r0r4ETueAaQIKkKQqz6 3f7CdnJwMwNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,303,1589266800"; d="scan'208";a="425846485" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.73]) ([10.237.72.73]) by orsmga004.jf.intel.com with ESMTP; 01 Jul 2020 23:43:57 -0700 Subject: Re: [PATCH 14/15] mmc: host: cqhci: Demote faux kerneldoc header down to basic comment block To: Lee Jones , ulf.hansson@linaro.org References: <20200701124702.908713-1-lee.jones@linaro.org> <20200701124702.908713-15-lee.jones@linaro.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <049e68ad-50fb-31d6-0a94-3f7c676a75e7@intel.com> Date: Thu, 2 Jul 2020 09:43:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200701124702.908713-15-lee.jones@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_024403_328110_B477F19A X-CRM114-Status: GOOD ( 21.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Venkat Gopalakrishnan , Ritesh Harjani , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Asutosh Das Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/07/20 3:47 pm, Lee Jones wrote: > cqhci_host_alloc_tdl()'s function header is the only one in > kerneldoc format. Which seems odd as it's not part of an > external API and isn't referenced anywhere else. Seeing as > there has also been no attempt to describe the expected > function arguments either, we're going to assume that this is > not actually a bona fide kerneldoc use-case. > > Fixes the following W=1 kernel build warning: > > drivers/mmc/host/cqhci.c:163: warning: Function parameter or member 'cq_host' not described in 'cqhci_host_alloc_tdl' > > Cc: Adrian Hunter > Cc: Ritesh Harjani > Cc: Asutosh Das > Cc: Venkat Gopalakrishnan > Signed-off-by: Lee Jones Acked-by: Adrian Hunter > --- > drivers/mmc/host/cqhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c > index 75934f3c117eb..8cc277b4ffe9e 100644 > --- a/drivers/mmc/host/cqhci.c > +++ b/drivers/mmc/host/cqhci.c > @@ -144,7 +144,7 @@ static void cqhci_dumpregs(struct cqhci_host *cq_host) > CQHCI_DUMP(": ===========================================\n"); > } > > -/** > +/* > * The allocated descriptor table for task, link & transfer descritors > * looks like: > * |----------| > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel