From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20D9AC433ED for ; Mon, 12 Apr 2021 20:19:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70EF061352 for ; Mon, 12 Apr 2021 20:19:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70EF061352 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Rx03I6gsZpDpKgraTVF6DO+BHIEnGemYyHR84bxFfDA=; b=f8uuca4SzanProTpbWO1+8pgw kxC9iQJhSITEoDqrIKPGTK9Z8rWn22PXYUZ5HYeDU50gz1N/U7T/Cwf0eXWlm1GXYEDvSc/atwVW7 eYyPoS+gnpo0iiOmC+yS4mExdWQYrJhMs0qNDAlwYS21WR/bju4ZHMRDpbSbWVEMhrzi/V3xDmduL xkaFPzd+1m6wBvfcRipMVVrWAfBv9dp1RCAWHf9GJVEuugqxwlvbhQ8JDr130pWgKH8bq/KCly7gp SpiydcH+y+yJ8BHFbWwA3eIOSzovp2dBL8SgcJvGQkooGCwuzkp0zK8v4tAJD3Dkbxo7H6C77pV0k QA9uFpfsw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lW30H-007blz-Ig; Mon, 12 Apr 2021 20:17:50 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW30E-007blq-M4 for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 20:17:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Sender:Reply-To:Content-Description; bh=89l2/MsE/1R1nMK6CqBKVCcdTYrKJDV8eyR7s7g4tP0=; b=fBliRPJMNbFidxWPHuuVQfGyAj KBPK8qO+u/Fx6HSQcK+jo0Ph8xceS3kXOipbqwvqHwJxpjFkfUKjqhKZYZrWrCkFZacEl4miAkx+T 3mC6KtwHiD+YW21L5fgzT+AtYgajlpVTjqJT/h2i6wKOWrGXjlkU4duP3TAIRzGRoPV+e6HqLkKG1 zr2hkOZFi4WIgXJJcOhf0jATb+NgVyWaPK+uTjoUiyqhT6SlBKp+RJmqfzx1+qPy49MF/LmPwtXm3 nCDQ+d1T/urHrIb0VSwZY9OGpE01w8KnnLUYm6n73F3pII9xPMjIsJr2NoA0o+/3rfs7a3lKiC9u+ /Izv4P5w==; Received: from mail-eopbgr140059.outbound.protection.outlook.com ([40.107.14.59] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW30B-006XBk-Bo for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 20:17:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89l2/MsE/1R1nMK6CqBKVCcdTYrKJDV8eyR7s7g4tP0=; b=V1mVMbDendzo4hwawfj6x2xd+66JvLCrPJnSDomUCc/7RiLiiwZWiIXpx9hGho5fOltv4ArAAt5neZU2gBDtY/2FLFmdv904lXyOwtnJ15WkYtUQkNgvOsYhyaa7hsTGeGIev4Bcf6npGWgYMxEd/UBhm4KsR8wCRLk2ewMw6hM= Received: from DU2PR04CA0173.eurprd04.prod.outlook.com (2603:10a6:10:2b0::28) by HE1PR0801MB2091.eurprd08.prod.outlook.com (2603:10a6:3:51::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.21; Mon, 12 Apr 2021 20:17:26 +0000 Received: from DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b0:cafe::96) by DU2PR04CA0173.outlook.office365.com (2603:10a6:10:2b0::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Mon, 12 Apr 2021 20:17:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT038.mail.protection.outlook.com (10.152.21.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Mon, 12 Apr 2021 20:17:25 +0000 Received: ("Tessian outbound 82c2d58b350b:v90"); Mon, 12 Apr 2021 20:17:25 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4def65a529c1883b X-CR-MTA-TID: 64aa7808 Received: from 57ded76461f9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DFBE7B4D-E954-4E1C-A6B4-F754D035D005.1; Mon, 12 Apr 2021 20:17:16 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 57ded76461f9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 12 Apr 2021 20:17:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MkyU+CkjecnH5ZVhaabTZjF0iHNI98Qi9LSDVQ3br7msG9YYrdUZDdtNcsrhNtkoMrgDZh90BWcHb649nCn5XmabcUcSUKR8ary0XBsS2FmgX6x+HhF/Oave4n1yByyqavbEgF/Fcth/1l2D1UXvAQ07ixz/kfgjy0WgXto/ukEeLkKEd0SSwkMxvWNOL5Zd86jdaNjpGWZ7G92LxlHzfhKBHjnR7thRDrp8/yca1ZciCi2a/wpWV/cZDcfNww9VzBD7+MzX9KaJEJAkXHk477UANz7bZTDvoFKRGMHLP+/5wxwyFfKEcsZeWOiugIRGgdhSnytMLA3yIbBRM4fMUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89l2/MsE/1R1nMK6CqBKVCcdTYrKJDV8eyR7s7g4tP0=; b=LgvG94CUEQiUTxuLNw6pKKBWxuPGzvJ5NDZXZZU6seTFt2YQ5M7WZva37s2V7VjYgoU4QllWNm1JKH0dHB3q+NnDfPNcd6/FIDeCqoCeRlsDgLxUMGQKFtHNgpR/RHAZp2+0+t1AlhyafX985CNqyuJhaFsixUmJQc2oGdR7WY6USzq0X7Pesb9jNLMyKsv9K6Zv8Q6GaVaGPYTdDlq1eYIke8baWFxAaSrh4t+G3Mtb68Mlm4JSrJlG2hBdIdx57Gbgc3Ih8KHpPFkhOp615ls96sxHmHTurZCT51nkqcqnpVgtXnFxjwe2ndpjsWJB0wI41KmEV0gK8HeKNUAmBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89l2/MsE/1R1nMK6CqBKVCcdTYrKJDV8eyR7s7g4tP0=; b=V1mVMbDendzo4hwawfj6x2xd+66JvLCrPJnSDomUCc/7RiLiiwZWiIXpx9hGho5fOltv4ArAAt5neZU2gBDtY/2FLFmdv904lXyOwtnJ15WkYtUQkNgvOsYhyaa7hsTGeGIev4Bcf6npGWgYMxEd/UBhm4KsR8wCRLk2ewMw6hM= Received: from AM0PR08MB3026.eurprd08.prod.outlook.com (2603:10a6:208:65::21) by AM0PR08MB4387.eurprd08.prod.outlook.com (2603:10a6:208:140::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Mon, 12 Apr 2021 20:17:08 +0000 Received: from AM0PR08MB3026.eurprd08.prod.outlook.com ([fe80::b992:b96d:436f:295b]) by AM0PR08MB3026.eurprd08.prod.outlook.com ([fe80::b992:b96d:436f:295b%5]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 20:17:07 +0000 From: Daniel Kiss To: Will Deacon CC: Linux ARM , Ard Biesheuvel , Catalin Marinas , "pcc@google.com" Subject: Re: [PATCH v3 2/2] arm64: Conditionally configure PTR_AUTH key of the kernel. Thread-Topic: [PATCH v3 2/2] arm64: Conditionally configure PTR_AUTH key of the kernel. Thread-Index: AQHW/iqZeTXZj6OKmk+25jqAMSCE4KqbWbUAgBZbkQA= Date: Mon, 12 Apr 2021 20:17:05 +0000 Message-ID: <04AA56B1-FF63-4DB1-826B-037A7AF03CCD@arm.com> References: <20210208145554.2164638-1-daniel.kiss@arm.com> <20210208145554.2164638-3-daniel.kiss@arm.com> <20210329145137.GE4203@willie-the-truck> In-Reply-To: <20210329145137.GE4203@willie-the-truck> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [78.92.185.39] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 1f08ccf1-f7b2-43f4-cd10-08d8fdeffd34 x-ms-traffictypediagnostic: AM0PR08MB4387:|HE1PR0801MB2091: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3044;OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jqfFDYvNwMqboiot9+dr034pWmYbfntr6xVnIgsJ+IM7u/AGHJDznMMhd/bgCE7Qn5RReQUASifX6g/VuEyAQE847+dJQEZl8xWO2dy5zzeWL4z6w3rKl3VfeexdQWZppZWxfiYvGcCKPZlQVGdsbq9s/2Hwwfauo+e1O2sEFYDCj2QLkPcpjnOJO0qUi5uXWEQs236mtAK9wpIdIGhffHlnOYpMqO5oQjh+AbJOVFzL+0WpMrvEsn8/2s8kpfZfvNnKS0PHThVudYDM5r+NMHtsMvOFLtHO/g1Cqdf/2qJAEAJhf2oLfoG6tN6FS2GI58BkdsxO3P45EeF4b20tsAY/84hniHu4nulT6HiNRqg2dcjrFZADusI2oKPzpa5pWK3DPWMhkw50XXs/jJ9spmHc2wYiCjZU1YFGK+Kd1MVzFAD/pOyE++BL9NPV1swqlA0irUep2qW7O58VsNxk7qjkdCS6d/iFipBObXCjm2wA2xUoLF58+z5GukiMvZeJtxV3WnKz1U3i26WJSEiZGaaloLgcoPC/Xw9GZjWmnJW1URAN1Iy+y9mC/yqchBJLKhR/JX45HvYSLPozw1ljKgNAFqUaoo8njbAmPqWYV7d0omxP48xpFfqWFsYSPlxZQUADfSfTZp/8TRdu8oGxo29IAdf26zGhj/+70OfwDtw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR08MB3026.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(186003)(478600001)(53546011)(36756003)(6486002)(6506007)(8676002)(26005)(83380400001)(66446008)(66946007)(86362001)(64756008)(66556008)(5660300002)(91956017)(54906003)(76116006)(2616005)(66476007)(4326008)(2906002)(38100700002)(6512007)(6916009)(33656002)(8936002)(71200400001)(316002)(45980500001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?6dfFVUEAf5HIjlgnI7YrylRqwdmceusrWAgjxJxArcgtvFcsoEBYUXstSLk2?= =?us-ascii?Q?Ksmh1OFjEWnzTqGPRJV18N08uMveZJ2wmVtX7iorr0Ib8naSBGKuQ13lGypl?= =?us-ascii?Q?FZplt65nPAJGFtCNJEUD3K08ViP++Zk+ou/URmgAEpy0SRWbhcBhtijhUkH/?= =?us-ascii?Q?PPjPs59Z8oB+INGCEQWTencabBGU8vUAz+5wMjqHjJ39sOBy6I+qe+7za5vY?= =?us-ascii?Q?IA77HssUTBW4RoZPB/TF5BySWWkrob2mQ3Q0J7ZLacxbb/XUwEbfMgSRx5pB?= =?us-ascii?Q?f5tWAnrvrOawmaYCwmnXARP5G/ely/JNY/ZLNT5pEuA/525Lmn8xJX6AreQ0?= =?us-ascii?Q?9Zm+S55sevE7UeSoFy50dQyjKzFHQyFBecwIeAv7y+HIiRywANbqCWk1/NN1?= =?us-ascii?Q?CIAS7jvRuFPAmVM+Xbo5U8b2XylrHyHhO8IJogHOu7ebh6qX7aPaNl5oAbeL?= =?us-ascii?Q?RDWl7jTJT9+CIxo9gGV8UlaSJ9lbbZge2ik+AVXe5iU4ExJae3jhQF0jrUgL?= =?us-ascii?Q?gOvi9YOE0CAVYgKWQ0UQiI2B4tQdN1Df7+WBTyzP/fZTy/ca1jT2DZvAKDPP?= =?us-ascii?Q?/7fD4gah/Zt5JhTOrPcn5mxSCo0eC7WASrRDUBxV8IGgzgxI5ZXFtIaxgA++?= =?us-ascii?Q?qNhcJOlDxCL74pxYY49nz8Pz4wr+xDWlDm/PKw8ycwl75tuiFrpymNGLbfpA?= =?us-ascii?Q?eDiwGyN06lXWXBw0XLhmHVJtW0zZCyZddclj4fSZ3nn72NJ5dBKQ6oQuuGCz?= =?us-ascii?Q?qlF3JOTL1HmzFh54LKNRV1liYFkW8yUf2xcfCn0gq3d14v/OTzOPi5KmBD+2?= =?us-ascii?Q?WlY/4jZtbiXcR6NTg4cyxUftfBYKLhPxhUQXEbEIYdQXmejpu/+Pq1jsU2tV?= =?us-ascii?Q?TfO2iTJS1gEdT3OEQHlD53z9qMVPgYBAxieOjb6JaccfIh9LVw3SSMO2U7uV?= =?us-ascii?Q?uvVG9cwHswYjG6BHpCU6RXSKWzpdGKEORCIjiZQo15ZGCmra1WqkRB7YQ33A?= =?us-ascii?Q?CumnPgxGBn9g8YQMTILjBZmV2neXIB+6jSBhu8cUdrXuWs0Y4y02c3cTV08q?= =?us-ascii?Q?N6pxs0QzoW9BgAS3xF9gnHYdju6DKvUejqXZGsyX42h+lAlS0nT52X8hdMRd?= =?us-ascii?Q?MKGtt5ZgA594BkAuYWXbs9aQkguVJVwbffzATHktzTkcISlA0hK7+R1ottDC?= =?us-ascii?Q?AdChZXags98azOlEJacA4o8D1kaOsaKg9+25UpxAfOS8M0BlQ372z2dl5u/r?= =?us-ascii?Q?Asp1q2b9fcgdAaOI65U4noRKsEF8Mu5GoDS5u6T25IT/F+66vLqLHYrYyDSW?= =?us-ascii?Q?gTB1aoFkc/P1J42PJdBGwJRM?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4387 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a1770bd0-96b1-42bc-8279-08d8fdeff238 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o/8s/LuamrWT+m492i7hwMtSU4r2FAr7w62Z9YJ7TjwGqmJAHUibiwvyfypgTaPYO33zesrZzqo84PLB1DIQDycKWThCb6v9fJFfl2PXcDA+4WYKTv0jTzekKnsSdefz+DO4XYCvovnPJUeY9QU82ibeC8O4/H8/2pRHkz//2PPMhDfiusSwLpg574eAf31hWM7SPopL1s6YTUwccLhs46ZV9NyGka6eBzjvdMN/YaCMDnMyq81OROKlEf3GPytAwNBr+JB9yt1Jc2MQuZ5nDvI4GBEoKB8HJ/sG1N8/kFWe3FN31aAEcWM8tXW16TGWkFTqBG9DtxZED/P7kUjxdbAT6NtsKgmmoGAVA1SiIQjzMtgd/dvF2vzhZugKPTrYIiEUWgbQFWPdTsoZwKQZADa4Z/hjhTkd9yAV7ShbdmJIf8ET6eMjg+9zHnCJgE9/wI8nWR111YahYyChJmoRjE5S9Qsk5Jr+pg7jkMZWTwJRPylNhUnyhdnem8KNQojx3Tf9r+A/vedeKesX+gaNaAJeyoZBn4Ff5tHD8nuRREN7c0xCQe5zW3pLb7gnkohlROp0OrZROk8H5F59wqlxqfQNQOJbdqurl1ktFNbHdPit6Sk7exJdw3HsYYrgRUkmyJd9ikIS0uHLznY9TpU7rw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(376002)(396003)(346002)(136003)(36840700001)(46966006)(107886003)(33656002)(36860700001)(70586007)(8936002)(8676002)(4326008)(36756003)(316002)(54906003)(83380400001)(356005)(47076005)(6506007)(82310400003)(26005)(336012)(5660300002)(478600001)(2906002)(6486002)(6512007)(186003)(53546011)(86362001)(70206006)(82740400003)(81166007)(6862004)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2021 20:17:25.9972 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f08ccf1-f7b2-43f4-cd10-08d8fdeffd34 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2091 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_131743_501470_4AC88DDE X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On 29 Mar 2021, at 16:51, Will Deacon wrote: > > On Mon, Feb 08, 2021 at 03:55:54PM +0100, Daniel Kiss wrote: >> If the kernel is not compiled with CONFIG_ARM64_PTR_AUTH_KERNEL=y, >> then no PACI/AUTI instructions are expected while the kernel is running >> so the kernel's key will not be used. Write of a system regiters >> is expensive therefore avoid it not required. > > What happens if somebody tries to load a module built with PAC into a kernel > where CONFIG_ARM64_PTR_AUTH_KERNEL=n? Do we reject the module? I think it will be loaded, but actually nothing will happen because then the instruction will be just NOPs. Other way will work as well. Enforcement will be trick because module might sneak the compiler flag in that overrides the kconfig. > I'm not sure how much we care, but I'm a bit worried that it might not go > "obviously" wrong. > >> Signed-off-by: Daniel Kiss >> --- >> arch/arm64/include/asm/asm_pointer_auth.h | 63 +++++++++++++---------- >> arch/arm64/include/asm/pointer_auth.h | 20 +++++-- >> arch/arm64/include/asm/processor.h | 2 + >> arch/arm64/kernel/asm-offsets.c | 2 + >> 4 files changed, 54 insertions(+), 33 deletions(-) > > [...] > >> diff --git a/arch/arm64/include/asm/pointer_auth.h b/arch/arm64/include/asm/pointer_auth.h >> index c6b4f0603024..b34aebb95757 100644 >> --- a/arch/arm64/include/asm/pointer_auth.h >> +++ b/arch/arm64/include/asm/pointer_auth.h >> @@ -30,9 +30,11 @@ struct ptrauth_keys_user { >> struct ptrauth_key apga; >> }; >> >> +#ifdef CONFIG_ARM64_PTR_AUTH_KERNEL >> struct ptrauth_keys_kernel { >> struct ptrauth_key apia; >> }; >> +#endif >> >> static inline void ptrauth_keys_init_user(struct ptrauth_keys_user *keys) >> { >> @@ -54,6 +56,8 @@ do { \ >> write_sysreg_s(__pki_v.hi, SYS_ ## k ## KEYHI_EL1); \ >> } while (0) >> >> +#ifdef CONFIG_ARM64_PTR_AUTH_KERNEL >> + >> static __always_inline void ptrauth_keys_init_kernel(struct ptrauth_keys_kernel *keys) >> { >> if (system_supports_address_auth()) >> @@ -69,6 +73,8 @@ static __always_inline void ptrauth_keys_switch_kernel(struct ptrauth_keys_kerne >> isb(); >> } >> >> +#endif /* CONFIG_ARM64_PTR_AUTH_KERNEL */ > > Can you group this with the struct and avoid having two #ifdef blocks? Sure, I'll send a version. > > Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel