From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CDF2C27C76 for ; Sat, 28 Jan 2023 10:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mDZBgr7NEaNfmPbWfWfeeMRQnOvGXmEck0i+yX0U1ao=; b=G2CKqC7mfQ+3EB 82qZbpJLxnn8bt4N6P0W5Nx/Ii6dcMe5uBF4wiN3tLLuDLIVcl/+kdWJSd7xS4ZjR+HD40t/QrTqM 9mz3ChgnJ+GSYpeXiLdLyS/R7JQOMOYLH5yhfC6LhPdoIkR5iVrP/bMqufHkZuiivU2qxZhpvrVks 9BPEwjCYjwtcwe9xf/lynyCh4A6+C64bVB006mky6tL/+iRShOm2ykyVLpzeNv6R5eftDh18h3kMX dcwGzds5XQOHLALercGOMTy9EpzJhDrb81eFmLiGh6E9u+pXAw5a8lkMbaol53DoQtNfDRBOBWz+b wXifIhsgkbnL10k550qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLi82-00Ha4U-Ih; Sat, 28 Jan 2023 10:08:10 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLi80-00Ha3e-5E for linux-arm-kernel@lists.infradead.org; Sat, 28 Jan 2023 10:08:09 +0000 Received: by mail-wr1-x436.google.com with SMTP id d14so7022297wrr.9 for ; Sat, 28 Jan 2023 02:08:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FOUEu8oBZpye/PT3Np7iUa0KHDNdwIekwrLom/JgEd4=; b=TlJ69dHpibrtcOj69LxiAnK0e4psSWHxmUvB7gyQmRkJpfaPYw7mYcBthzIJpClwOn D0m3DY9lk8QUm7pWJFlMW4oEMdkq2qtPWf4rM6AGBkqqcqizNSsD6+AzjM22AORk4tiS cDmBWfAGSJZr3Vi+l2k0+lBtZyxxF14UVQ8x0wXf6wjI5sKsWIlHVdFXOimeotTd8BXR iAxzik//acLXej0D9Uwy/XW+F3Ii6tnvRuW8GjUpwc1PLngVdZ2hWYDqz3OFJfz7AJXm nFQnKNMWjh9RYzaxLc56+++9EO0tWTj8WRbqceuaUMjMFMrdWqFxXAbClBfBs48EVfIT umNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FOUEu8oBZpye/PT3Np7iUa0KHDNdwIekwrLom/JgEd4=; b=p3zAze0mYUaEEiQkPUYROTJKrzsyf4IlrD0B+B2R/3pXo2v/X7XlHS3QBPy0VD5aFa 0/owQUcBvbfRpTKCeV8ewI8ntZ0GUDJCAUZR/JxoRhb2cpJMeIfAl1yhe4kQVF+D17ip fEy1gnln3QA+17Pag5KRKtfuUiaexytCJq/MpZ9VHSFpvz5820NIFJ+e3tPyjyZWbXzK ZGPJ4YBB4JK3/3OhOghcT+n7cvCHZleuIFBMvfNQrxmYT/J6e/Z8DvKoxF6fQ9D/EETy D09MqGsDl245ukLH+HmPlJ7TNlEdw5vUiv0iG8Mi9Negz1TDdRYgC3TMVi+iwZPJsHDE hilA== X-Gm-Message-State: AO0yUKX1oxQGeSJtJfbROpXbjSdHrEu8OkpUBU9Iu3cx5pCW1hA71RLJ rlMiIT77Z4KHa/mIqS+glHlzeQ== X-Google-Smtp-Source: AK7set8gi5MQ7bS/tG0fPpXlve9FGvdYU7ci8KURCgRbR3IiSJ7g6ewsYorQ/6xFHp7/l/Zy0fvBZQ== X-Received: by 2002:adf:b646:0:b0:2bf:d610:e49 with SMTP id i6-20020adfb646000000b002bfd6100e49mr3262238wre.16.1674900482926; Sat, 28 Jan 2023 02:08:02 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id g8-20020adfe408000000b002bdda9856b5sm6314713wrm.50.2023.01.28.02.08.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Jan 2023 02:08:02 -0800 (PST) Message-ID: <04b409b7-0d8c-4b60-1fd5-3486f47cc04c@linaro.org> Date: Sat, 28 Jan 2023 11:08:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 07/15] dt-bindings: clock: Add Ambarella clock bindings Content-Language: en-US To: Li Chen Cc: li chen , michael turquette , stephen boyd , rob herring , krzysztof kozlowski , "moderated list:arm/ambarella soc support" , "open list:common clk framework" , "open list:open firmware and flattened device tree bindings" , open list , arnd bergmann References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-8-lchen@ambarella.com> <0c19efb4-3bca-f500-ca24-14b9d24369ef@linaro.org> <87y1prgdyu.wl-me@linux.beauty> <87tu0ehl88.wl-me@linux.beauty> <87sffyhgvw.wl-me@linux.beauty> <185f3b3a330.11c135c37327076.6300919877819761183@linux.beauty> <33c2038b-5e06-4eb2-82b8-007bb735bfb1@linaro.org> <185f7c1c693.b1cad2b8487563.1022046142491625830@linux.beauty> From: Krzysztof Kozlowski In-Reply-To: <185f7c1c693.b1cad2b8487563.1022046142491625830@linux.beauty> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230128_020808_305264_611C51F4 X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/01/2023 10:42, Li Chen wrote: > Got it, I will model it as: > > rct_syscon(compatible include "ambarella, -clock"...) > | peripheral A > | peripheral B > | ... > > > One more question, two driver models: > a. compatible = "ambarella, -clock", handle all clocks(pll, div, mux, composite) in single driver. > b. compatible = "ambarella, -pll-clock", "ambarella, -composite-clock", "ambarella, -div-clock"...... > and implement a driver for each of them. > > Which driver model is preferred? We do not talk here at all about drivers. This is independent and not really related. Anyway, independent features mostly have separate drivers. Each separate driver should be located in respective subsystem. But again - we do not talk here about drivers at all, so please do not bring them into the problem. It will make everything more complicated... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel