From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E67EC433ED for ; Mon, 12 Apr 2021 09:17:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE4336109E for ; Mon, 12 Apr 2021 09:17:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE4336109E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:Cc:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LipL+3nSIi+resuM2nuCKx7kat+hmRbIJodd4WK8Foc=; b=VTnkNVWTho1DFu1eJIcSidyzD 7fwfMjQhUU2Bk05AQyd4bVV5AynHbRU0q4wCnT4qriZnsThnhpEswT7d2f/hRx0p0qcAdEhQ8OM74 AJ+0AHwkhNRQoFsfo6io0aelkLqHx9qCjh7ExKOG5ExlN0j5EQjo0BcSkWlPWQjEaGiMbbABBM7ae VlPOitY7QfaLFHVMiOrY70Izu6o7IEZ2whYEugkFkj4pbMCRT2o2IbfULrm4+JnbCm2qcNKnmrq/K BFNr+L+jW0Bej7xGnMXm8vega1xZs94hIgjutvmh0Bb0lQXya4VpUM+Sx+Q+wSe45ZU5Gs1jSa7Tk Yw+S+FfIQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVsf9-006Exa-9l; Mon, 12 Apr 2021 09:15:19 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVsf6-006Ex2-3f for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 09:15:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:Subject:From:References :Cc:To:Sender:Reply-To:Content-ID:Content-Description; bh=9CjVkSBXtmrUQcAuDF7E3D+CTItkGZ6+VzlUXbjqLfI=; b=vw2HExxsM1YcR14RwqwmiDiNI6 X7EdybTA/ozjSqxgCrNQUSYlo2CHzHXL+ZdSPc8tMK7AUZtGeEI3oM1UY5a4dRdVbP3lQWFrxdyV6 b/N1T/zEc7qaHuO3NSWisQm5mDE9815apwJIEmuED+nI45NF2rtUKrnZ7ES/VXBAfpKk+VRTKfw0e aKMfgTsfo1zkGEkTgGecoBCaU/c1H+DptQppoF+EJePk7YemkHqmf5HQAjDa0kUtt1cDlEiX37mY0 TsRcyhblNPhyeSzhd5n3YIec+CddIDEAS6za/lOcv1nrVqtZK5RS5TzZ5dtcYVxPjJOsjNBg5hkrB C1oetC8Q==; Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVsf3-0062W1-3J for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 09:15:14 +0000 Received: from [192.168.1.111] (91-157-208-71.elisa-laajakaista.fi [91.157.208.71]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 28A9B3F0; Mon, 12 Apr 2021 11:15:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1618218905; bh=R/sQjgekGKi0dQEpB6c2WYBsNlUIehkjxHLKQk/kObI=; h=To:Cc:References:From:Subject:Date:In-Reply-To:From; b=EyY4d+W/R2UpBeyK3nozWrFZub7FvGa1VOVvlDVuBzh/fhATTYr2s4tx/dv2NMdir ih70Z47kxd2EJkhrKuy+EAgEPBZMrYjafnd4Xz98Yj9LAmfDAWb9o37dq4lsTTCFjw pmMzgHD9/dQr5HmFp9jC0A/of0XTJ+jccc6byTvw= To: Pratyush Yadav , Laurent Pinchart Cc: Nishanth Menon , Benoit Parrot , devicetree@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Tony Lindgren , Vignesh Raghavendra References: <20210412075306.102884-1-tomi.valkeinen@ideasonboard.com> <20210412075306.102884-2-tomi.valkeinen@ideasonboard.com> <20210412083605.qnpf2mxy3rcaj7dv@ti.com> From: Tomi Valkeinen Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am654-base-board: remove ov5640 Message-ID: <04b96345-f1a9-71bc-ce76-07215648e810@ideasonboard.com> Date: Mon, 12 Apr 2021 12:15:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210412083605.qnpf2mxy3rcaj7dv@ti.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_021513_317294_2BDA5A58 X-CRM114-Status: GOOD ( 24.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/04/2021 11:36, Pratyush Yadav wrote: > + Vignesh > > On 12/04/21 11:00AM, Laurent Pinchart wrote: >> Hi Tomi, >> >> Thank you for the patch. >> >> On Mon, Apr 12, 2021 at 10:53:06AM +0300, Tomi Valkeinen wrote: >>> AM654 EVM boards are not shipped with OV5640 sensor module, it is a >>> separate purchase. OV5640 module is also just one of the possible >>> sensors or capture boards you can connect. >>> >>> However, for some reason, OV5640 has been added to the board dts file, >>> making it cumbersome to use other sensors. >>> >>> Remove the OV5640 from the dts file so that it is easy to use other >>> sensors via DT overlays. >>> >>> Signed-off-by: Tomi Valkeinen >>> --- >>> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 27 ------------------- >>> 1 file changed, 27 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts >>> index fe3043943906..76358b4944e1 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts >>> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts >>> @@ -85,12 +85,6 @@ sw6 { >>> gpios = <&wkup_gpio0 27 GPIO_ACTIVE_LOW>; >>> }; >>> }; >>> - >>> - clk_ov5640_fixed: clock { >>> - compatible = "fixed-clock"; >>> - #clock-cells = <0>; >>> - clock-frequency = <24000000>; >>> - }; >>> }; >>> >>> &wkup_pmx0 { >>> @@ -288,22 +282,6 @@ &main_i2c1 { >>> pinctrl-0 = <&main_i2c1_pins_default>; >>> clock-frequency = <400000>; >>> >>> - ov5640: camera@3c { >>> - compatible = "ovti,ov5640"; >>> - reg = <0x3c>; >>> - >>> - clocks = <&clk_ov5640_fixed>; >>> - clock-names = "xclk"; >>> - >>> - port { >>> - csi2_cam0: endpoint { >>> - remote-endpoint = <&csi2_phy0>; >>> - clock-lanes = <0>; >>> - data-lanes = <1 2>; >>> - }; >>> - }; >>> - }; >>> - >>> }; >> >> As for patch 1/2, you could drop the two nodes completely. Same question >> about overlay availability. > > The &main_i2c1 node was added much before the OV5640 node in > 19a1768fc34a (arm64: dts: ti: k3-am654-base-board: Add I2C nodes, > 2018-11-13). I wonder if there is any reason for having it present even > if there are no subnodes. One reason that I can think of is that this > node defines the pinmux configuration and clock frequency which makes > more sense here than in an overlay. Right, and we also have an empty main_i2c2 there. I'd rather keep empty main_i2c1 to be in line with main_i2c2, and to have the pinmux in the main dts file. Unless someone can say we can remove both main_i2c1 and main_i2c2. > >> >>> >>> &main_i2c2 { >>> @@ -497,11 +475,6 @@ flash@0{ >>> }; >>> >>> &csi2_0 { >>> - csi2_phy0: endpoint { >>> - remote-endpoint = <&csi2_cam0>; >>> - clock-lanes = <0>; >>> - data-lanes = <1 2>; >>> - }; >>> }; > > I agree with Laurent that the entire &csi2_0 node can be dropped. > > Have you tested the CAL driver with this node removed and no overlay to > add it back? Can it handle the error gracefully or does it crash and > burn? No, I haven't tested that for a while. Tomi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel