From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 420D9C54EE9 for ; Thu, 22 Sep 2022 15:17:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pl62BsTy+MV7I1xx5lFUYQcvag4s9UrWBBXFxpu8zzc=; b=12tB8GeCp8T9Mg BTClgnCVeihN6io+m6qIM1/fUcbwwFdGZC9Kjmaj8rHvmsnw1PrJPczySiQXTtWqOczWqqsxt6k5g 6tugPEwxr/KoIohGPp2jN+oJm/CX0Z3D7Z0XUiR8xnvF0CJPN68LFqK1wkt7RmNS5cyl5pvN0LmJl IOdTCf79eZlXo+H23h84GLvl1GxmKKnUdTDQgsyKf5UAZPC0e4tm4S5obaqBbkIOtv2E2iyT/84fL fNgXllrzplumYyWVXS/9vL6s3+fdxhxhv/9S8t2n/pn5P6SbGIiSGhD4P4clkAbtEQDT2UYgtitD0 7C2RgfSgii/fS9ogF+CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obNwC-00GMWK-Iv; Thu, 22 Sep 2022 15:16:29 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obNnc-00GITx-9J for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 15:07:39 +0000 Received: by mail-lf1-x133.google.com with SMTP id f9so15189657lfr.3 for ; Thu, 22 Sep 2022 08:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=AICgMCTu4ugKZVgKKYZSCEgyNXOHBsTus/rL4+rxADE=; b=V6OmMtcM8HwjnmW517gvagdimCQzKh4oEk+jCZREpCpQaMRh+CUYlJnjHhWQjY+sn6 O2EMQ4TmRPc0YWA2AXrfK9EAIppOKDmxGDrlHPoDNfxJVW3XtHnP0Fgo5W/reRLAdYHm UVYMEVijD6WYE+JDTgZ0vUoZrmyKJTJtPlgAIrAp/2bsvx+1/X6ph9K33pGARnN0DkAP AgfZpohHy0hyLAk3+mnfVrclwPJDWSjxwZWLrJM9tgAB6aNIiSgHd7ef4jFxWuZMDLPK KNeogYycbDYEqtFUykDyC8n5Xxzcz1p0neVIj97isWerTZuHph+kEpakzCtG+d2YcUpa pKIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=AICgMCTu4ugKZVgKKYZSCEgyNXOHBsTus/rL4+rxADE=; b=Pu6wCRQvuPJYbHlX/8Isco8kEwHchT3e/fngc+pNURrb02KlG1bx0p3OdL+ocr/6/2 pQMMcPqb7oDLTsVVwHLTzbvMRjlWBRKIKb5kzUDqYWV8BjCrLluIPkn/vXto+jgkqgS/ BWXgTrfXDC9nP7BIfcVivILSR82IEcT2buatOq1IIKQPubS8023yQl+z2xYE/S9LlpnT 12UlBjfVMHtjsOOjLTQoTw5c4mVSQsn3KBkEP57XCYKqFz+ov90NhomucShxEDltI6Ku eniXIaCOU1nf3pJ/ELbyHsTDsvC/grbNe5a0XeN6n1s6X8wGg8dENMpyJlnHA1kQloMb e5Vw== X-Gm-Message-State: ACrzQf2GmqYBL607e+Cc+2LdSE2bWOK4u36QzrqDVXvqF7SOCVFciEip IWBVmv1KrP0uTrrpaEv+ghqiOQ== X-Google-Smtp-Source: AMsMyM5wWu4phY9miXzBVbKKyNmCh/6w2BSelex3t5iKGlg/9o62Y81D5nF1RPEPAveTSBkz6dR4Ww== X-Received: by 2002:ac2:4422:0:b0:49f:5c95:9525 with SMTP id w2-20020ac24422000000b0049f5c959525mr1506912lfl.1.1663859254520; Thu, 22 Sep 2022 08:07:34 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u6-20020a05651220c600b0049771081b10sm986478lfr.31.2022.09.22.08.07.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 08:07:33 -0700 (PDT) Message-ID: <04b9e5ef-f3c7-3400-f9df-2f585a084c5d@linaro.org> Date: Thu, 22 Sep 2022 17:07:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [resend PATCH v4 2/2] dt-bindings: net: snps,dwmac: add clk_csr property Content-Language: en-US To: Jianguo Zhang , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , AngeloGioacchino Del Regno Cc: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Matthias Brugger , Biao Huang , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Christophe Roullier References: <20220922092743.22824-1-jianguo.zhang@mediatek.com> <20220922092743.22824-3-jianguo.zhang@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220922092743.22824-3-jianguo.zhang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_080736_391058_87E45729 X-CRM114-Status: GOOD ( 11.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/09/2022 11:27, Jianguo Zhang wrote: > The clk_csr property is parsed in driver for generating MDC clock > with correct frequency. A warning('clk_csr' was unexpeted) is reported > when runing 'make_dtbs_check' because the clk_csr property > has been not documented in the binding file. > You did not describe the case, but apparently this came with 81311c03ab4d ("net: ethernet: stmmac: add management of clk_csr property") which never brought the bindings change. Therefore the property was never part of bindings documentation and bringing them via driver is not the correct process. It bypasses the review and such bypass cannot be an argument to bring the property to bindings. It's not how new properties can be added. Therefore I don't agree. Please make it a property matching bindings, so vendor prefix, no underscores in node names. Driver and DTS need updates. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel