From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDEC2C4706C for ; Sat, 13 Jan 2024 22:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rcTVFsyNRm8p9zvnHUqatDH70gvzV4U8wFbj+FIdCNw=; b=jlOFBzWOkrYYfj 4qc9EW9kOfpKp4ael62iN0WwOsW8Smq2/XNI8ES/WCYLuvfh3XRMErsostRgBbZ4LGuZ5DEeJGHAp nGb//R7eJHaCb0HHV9XpWdD0TXu6FWrkLYLnMF4TbVxXHQBSRZUrh0NPvuIYBThgbNZzhgxaj2BVS MSdy/8RP+gyG/RXUzH+wF6C3MJUowtyi6WjY2SBhrtEAADK21G8khs/D1v1XkCnhebzgCAQSBaakV cGGyHspuy/dFl/k5iUa8GjXtJd7N9m9dt1p/VdU/IJmdQkpbMcgBtWmmZ4L1O835OYrYJRJEmUAIP 1vVJqfQSbkesmioJDhsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rOm9F-005mHM-1l; Sat, 13 Jan 2024 22:06:37 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rOm98-005mG6-1l for linux-arm-kernel@lists.infradead.org; Sat, 13 Jan 2024 22:06:35 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id DAF0B86EF1; Sat, 13 Jan 2024 23:06:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1705183587; bh=enZha7Iw0gW9RpadFFFdbpE81iwRLSzhId9/3yJ2jIg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Sj1Ng4V94PkiIHfdQq6aGI2pUiEs6YwNbWAYTjzt96v3BRPFmzfpvi/umcP4ffKBG ryHNHawxQuxVObxOXsYnMzVaJMaB5DYL+ByNrfrBOkcmj8ZRRxy273bBRokBuJJjvR ACALmL7h0tY6Y62GY9So8kpB84tJvQ44mIpAoe5ROcDNBlDhMyzrPz5IEEO/i0hPYN bqT00TPsog/m33PHs3vXCXYu20h/WnrXqZ5aH5snjkaCrq6stbDwRqLAUCrEmp+T/A qnZaVvowThRxjc7zTMPUit7fAZSfY3JxswRe7mJE95mkZFEgJMO6xS2Kxn5M9sdo6Z BZ2GvEY+/iQvg== Message-ID: <04c11c66-98f6-4d4e-8644-7bdf0443d4d1@denx.de> Date: Sat, 13 Jan 2024 23:06:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: extcon: ptn5150: Describe the USB connector Content-Language: en-US To: Fabio Estevam , cw00.choi@samsung.com Cc: myungjoo.ham@samsung.com, robh+dt@kernel.org, krzysztof.kozlowski@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, shawnguo@kernel.org, hvilleneuve@dimonoff.com, linux-arm-kernel@lists.infradead.org, Fabio Estevam References: <20231212112729.700987-1-festevam@gmail.com> From: Marek Vasut In-Reply-To: <20231212112729.700987-1-festevam@gmail.com> X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240113_140630_758791_C3301E22 X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/12/23 12:27, Fabio Estevam wrote: > From: Fabio Estevam > > PTN5150 supports USB Type-C connector, so improve the bindings by > allowing to describe the connector like it is done on nxp,ptn5110.yaml. > > Signed-off-by: Fabio Estevam > --- > Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml > index d5cfa32ea52d..3837da7416e9 100644 > --- a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml > +++ b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml > @@ -37,6 +37,11 @@ properties: > GPIO pin (output) used to control VBUS. If skipped, no such control > takes place. > > + connector: > + type: object > + $ref: /schemas/connector/usb-connector.yaml# > + unevaluatedProperties: false > + If I read drivers/usb/roles/class.c usb_role_switch_get() implementation right, that function is doing an OF graph look up and expects a port {} subnode for that purpose. The drivers/extcon/extcon-ptn5150.c ptn5150_i2c_probe() calls usb_role_switch_get(), so I would expect the ptn5150 DT node should contain a port {} subnode, not a connector subnode. I think that's what should be done here -- update this PTN5150 binding document and describe the port {} subnode. The two DT patches are not needed and are in fact wrong ; at least the PDK3 one breaks PDK3 USB-C operation as the usb_role_switch_get() look up fails in the PTN5150 driver with that DT patch applied. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel