From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>,
Kory Maincent <kory.maincent@bootlin.com>
Cc: Sudarsana Kalluru <skalluru@marvell.com>,
Manish Chopra <manishc@marvell.com>,
Marco Crivellari <marco.crivellari@suse.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Sunil Goutham <sgoutham@marvell.com>,
Richard Cochran <richardcochran@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 6/7] net: pch_gbe: convert to use ndo_hwtstamp callbacks
Date: Mon, 3 Nov 2025 14:30:26 +0000 [thread overview]
Message-ID: <04d22523-34ed-45f1-ba59-ab8170d749e7@linux.dev> (raw)
In-Reply-To: <20251031113840.067ef711@kernel.org>
On 31/10/2025 18:38, Jakub Kicinski wrote:
> On Fri, 31 Oct 2025 18:35:25 +0100 Kory Maincent wrote:
>>> case HWTSTAMP_FILTER_PTP_V1_L4_SYNC:
>>> - adapter->hwts_rx_en = 0;
>>> + adapter->hwts_rx_en = cfg->rx_filter;
>>
>> It seems there is a functional change here.
>>
>>> pch_ch_control_write(pdev, SLAVE_MODE | CAP_MODE0);
>
> Good catch. Looks like SLAVE | MODE0 translates to 0 | 0
> so presumably the device doesn't actually support timestamping
> of V1 L4 SYNC messages? Unclear what to do about this.
> Maybe let's leave it be? keep the hwts_rx_en = 0; ?
> Not strictly correct but at least we won't break anything.
Ok, it looked like typo as the function actually does the register
manipulation while it's not doing anything for disabling RX timestamping
which probably means it's enabled by default.
But as the code was added back in 2012, and nobody complained, we should
probably keep it as is. I'll send v2 shortly.
next prev parent reply other threads:[~2025-11-03 14:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 0:46 [PATCH net-next 0/7] convert drivers to use ndo_hwtstamp callbacks part 3 Vadim Fedorenko
2025-10-31 0:46 ` [PATCH net-next 1/7] bnx2x: convert to use ndo_hwtstamp callbacks Vadim Fedorenko
2025-10-31 17:04 ` Kory Maincent
2025-10-31 0:46 ` [PATCH net-next 2/7] net: liquidio: " Vadim Fedorenko
2025-10-31 17:07 ` Kory Maincent
2025-10-31 0:46 ` [PATCH net-next 3/7] net: liquidio_vf: " Vadim Fedorenko
2025-10-31 17:19 ` Kory Maincent
2025-10-31 0:46 ` [PATCH net-next 4/7] net: octeon: mgmt: " Vadim Fedorenko
2025-10-31 17:16 ` Kory Maincent
2025-10-31 17:18 ` Kory Maincent
2025-10-31 0:46 ` [PATCH net-next 5/7] net: thunderx: " Vadim Fedorenko
2025-10-31 17:23 ` Kory Maincent
2025-10-31 0:46 ` [PATCH net-next 6/7] net: pch_gbe: " Vadim Fedorenko
2025-10-31 17:35 ` Kory Maincent
2025-10-31 18:38 ` Jakub Kicinski
2025-11-03 14:30 ` Vadim Fedorenko [this message]
2025-10-31 0:46 ` [PATCH net-next 7/7] qede: " Vadim Fedorenko
2025-10-31 17:39 ` Kory Maincent
2025-10-31 17:10 ` [PATCH net-next 0/7] convert drivers to use ndo_hwtstamp callbacks part 3 Kory Maincent
2025-10-31 17:41 ` Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04d22523-34ed-45f1-ba59-ab8170d749e7@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=manishc@marvell.com \
--cc=marco.crivellari@suse.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sgoutham@marvell.com \
--cc=skalluru@marvell.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).