From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43945C77B61 for ; Thu, 13 Apr 2023 14:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kDasgSRS3s7CJxIpXmwET88YYqmsU4VyqTn9jXWvimM=; b=hzPYBXAxvmj4ognnejiS7idK9J AjpkeIZ+dkSOKl68xxJscsdRKVp5cNa/HvIvWfJ82F1QPdXyHZYt2yQtayAMLL6HIPIzv3WgwwSoL uESRLm5W2iLIUBMAbxG1b9zYeM8WbK2H85D9a6w+32NW2wVck0m6cFqXh0YKaRNdi0FikzejirHcS mYNaX7IznQEDMNC+8maU8DpkIsT4mCnf4X27l7ba/Vw20jK0eDVdxRJPq0LIUToiILyvYVV/JjI0Z uJTFZXMe5xLqrgGATIanHfnKiwsV1+Oh4Bp0m0bTE3bNn8QupWMhMw15y8j7PB8X40sWvUKa9s9Me /Q9QTIww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmxdC-006MWY-2M; Thu, 13 Apr 2023 14:08:58 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmxdA-006MVf-1x for linux-arm-kernel@lists.infradead.org; Thu, 13 Apr 2023 14:08:57 +0000 Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-246eebbde1cso579084a91.3 for ; Thu, 13 Apr 2023 07:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681394935; x=1683986935; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rphjvWT4O3gGZ7CqLXaVQmnQVVM9idPSvXcFDuatoKw=; b=e7r4ohLAcdR4hSr4gafx+HPE7lXiSQnw04AUT/3K7UnDTUzGVtFsiS/92L0qoW006V se3oEYYM2Ug8YLK1HQ1aWmMlg0YWKHdkd25tuWJizmwZtDEmdciyKzs9C57LwxRMBemA TceSQxd6pyQTPMJ29Vn4cYkSNXIte2MEPShYaAz9bcgDqaP/81nQ5DFehg71Lhx5Gwyy 3G6n1q91rb5iLfU3dmP4RfsBEWHtcyyMBl/3h+i+MMWw8ZkTy/lEFtoj4b5d6E3bsth2 dBuHrIEKNNGtK5DyMkushWdYAkrWOvvObQMeGVSSd/YfO1LB614x+OmAOdK8WzBg5kaN sz0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681394935; x=1683986935; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rphjvWT4O3gGZ7CqLXaVQmnQVVM9idPSvXcFDuatoKw=; b=KMHpPxL9R1QGwYezXfgZQg1k1CI07AVonS62soy+ibY11GfCKASchZ0yQNZYs9xCto UUBLjRejY3SurcCYY7uVOn22DugZuBOz7pP6HT5dXLUp1jnFP2x9afsTfrrs5KT0M6i5 +J62wuZD89esk3j216k0OfCpeKi99+KcoLsPvpmaETKQ2vgQSPYLjlqzh/GwM7m1rG5w eldlrARaiT/tVfagUWl/Yl5OQqpDzUfdwroV71efE9dAxvXGMqjm2q1+XvGYo37gBOCa fZ1MBdNhM1c2Ao544BvHggz7qYSJQZz0fEDmcKQBJkiONAomdbwLFsUH4q4xSGoVNGh/ sW1g== X-Gm-Message-State: AAQBX9fARabD3xSH2laCMHCdwc1YuDEPjiVSiRHdnNXXJJziWv+GQ+Pi mHmCWawMrJTYazUTDjyaqkoZ9Y8KoaqbIQ== X-Google-Smtp-Source: AKy350YfsJY4xsvoyGFSOmUknTQNtGzNgBbOQYtx2ZcMf5cYzvDVieal915nf+m9oWVnrzPzaH/YWg== X-Received: by 2002:a05:6a00:1949:b0:635:120e:ff65 with SMTP id s9-20020a056a00194900b00635120eff65mr3893359pfk.25.1681394935314; Thu, 13 Apr 2023 07:08:55 -0700 (PDT) Received: from [192.168.1.105] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id i11-20020aa787cb000000b00634b91326a9sm1489694pfo.143.2023.04.13.07.08.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 07:08:54 -0700 (PDT) Message-ID: <04dcbf97-c1b6-a5c3-5088-ffba82d25a0b@gmail.com> Date: Thu, 13 Apr 2023 07:08:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] net: stmmac:fix system hang when setting up tag_8021q VLAN for DSA ports Content-Language: en-US To: linux-arm-kernel@lists.infradead.org References: From: Florian Fainelli In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_070856_640355_9195A9C6 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/13/2023 6:38 AM, Yan Wang wrote: > The system hang because of dsa_tag_8021q_port_setup()-> > stmmac_vlan_rx_add_vid(). > > I found in stmmac_drv_probe() that cailing pm_runtime_put() > disabled the clock. > > First, when the kernel is compiled with CONFIG_PM=y,The stmmac's > resume/suspend is active. > > Secondly,stmmac as DSA master,the dsa_tag_8021q_port_setup() function > will callback stmmac_vlan_rx_add_vid when DSA dirver starts. However, > The system is hanged for the stmmac_vlan_rx_add_vid() accesses its > registers after stmmac's clock is closed. > > I would suggest adding the pm_runtime_resume_and_get() to the > stmmac_vlan_rx_add_vid().This guarantees that resuming clock output > while in use. > > Signed-off-by: Yan Wang You have posted this patch several times now yet not on netdev@vger.kernel or towards the maintainers of the drivers, please consider using scripts/get_maintainer.pl. While it looks like you are fixing a bug, it would be worthy of providing a suitable Fixes: tag since this is a genuine bugfix. You should also consider providing the target tree: 'net' for bug fixes and 'net-next' for features, and also provide a version counter in the subject 'PATCH v4' or something like that. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel