From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB14ACA0EDC for ; Thu, 14 Aug 2025 10:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To:Subject :MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9MXCLoO2a3lry+5txsjkP4aF08L9+Z8/5rMBGiEuFkU=; b=t8B+dvUMXwQGKB lLDhOEcKo5gCXUNtpWqPEzwLyCjbcpadfdSYrI+wdLZ7q1zTKDD4AchcWN9onu+Sk0FZFW/E7KhaJ FmA9r19cszmHo/H7J2N+cQfSingEydAgVQKdbnF4juByjL+RPzhKrKI/8egdtukuyyrb5Q5O2dxG1 f0KdozD6nbAM//fTrChNj3oAWY6uFEOvEzYoJigiAA4kcFhDTBpe1hFVEsmH3a0otmphObSeZI3J7 2/uCY5e7gjXJOeiL2V4G7+e1JLlQpeKfPS3GR9Ci/iQq2AylAfzfJL7v1GQOXYb7zD3n/i1q+DstJ 75TS9X5zx4lXCwc+hjEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1umVb5-0000000Gfmg-0orE; Thu, 14 Aug 2025 10:54:15 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1umUQo-0000000GQqQ-1rIG for linux-arm-kernel@lists.infradead.org; Thu, 14 Aug 2025 09:39:35 +0000 Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4c2gG93jG7z2dMHD; Thu, 14 Aug 2025 17:40:33 +0800 (CST) Received: from dggpemf500011.china.huawei.com (unknown [7.185.36.131]) by mail.maildlp.com (Postfix) with ESMTPS id 460C11A016C; Thu, 14 Aug 2025 17:39:29 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by dggpemf500011.china.huawei.com (7.185.36.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 14 Aug 2025 17:39:27 +0800 Message-ID: <04df941a-f62d-e640-6619-e79dc88114b3@huawei.com> Date: Thu, 14 Aug 2025 17:39:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH -next v7 0/7] arm64: entry: Convert to generic irq entry Content-Language: en-US To: Mark Rutland References: <20250729015456.3411143-1-ruanjinjie@huawei.com> From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: kwepems500001.china.huawei.com (7.221.188.70) To dggpemf500011.china.huawei.com (7.185.36.131) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250814_023934_799012_02A0B2B5 X-CRM114-Status: GOOD ( 25.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, puranjay@kernel.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, liaochang1@huawei.com, oleg@redhat.com, kristina.martsenko@arm.com, linux-kernel@vger.kernel.org, broonie@kernel.org, chenl311@chinatelecom.cn, xen-devel@lists.xenproject.org, leitao@debian.org, ryan.roberts@arm.com, akpm@linux-foundation.org, mbenes@suse.cz, will@kernel.org, ardb@kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2025/8/12 19:19, Mark Rutland wrote: > Hi, > > This is looking pretty good now, thanks for continuing to work on this! > > I've left a couple of minor comments, and Ada has left a few more. If > you're able to address those and respin atop v6.17-rc1, I think we can > start figuring out how to queue this. Sure，I will revise these review comments based on v6.17-rc1 and release a new version after local testing. > > Mark. > > On Tue, Jul 29, 2025 at 09:54:49AM +0800, Jinjie Ruan wrote: >> Currently, x86, Riscv, Loongarch use the generic entry. Also convert >> arm64 to use the generic entry infrastructure from kernel/entry/*. >> The generic entry makes maintainers' work easier and codes more elegant, >> which will make PREEMPT_DYNAMIC and PREEMPT_LAZY use the generic entry >> common code and remove a lot of duplicate code. >> >> Since commit a70e9f647f50 ("entry: Split generic entry into generic >> exception and syscall entry") split the generic entry into generic irq >> entry and generic syscall entry, it is time to convert arm64 to use >> the generic irq entry. And ARM64 will be completely converted to generic >> entry in the upcoming patch series. >> >> The main convert steps are as follows: >> - Split generic entry into generic irq entry and generic syscall to >> make the single patch more concentrated in switching to one thing. >> - Make arm64 easier to use irqentry_enter/exit(). >> - Make arm64 closer to the PREEMPT_DYNAMIC code of generic entry. >> - Switch to generic irq entry. >> >> It was tested ok with following test cases on QEMU virt platform: >> - Perf tests. >> - Different `dynamic preempt` mode switch. >> - Pseudo NMI tests. >> - Stress-ng CPU stress test. >> - MTE test case in Documentation/arch/arm64/memory-tagging-extension.rst >> and all test cases in tools/testing/selftests/arm64/mte/*. >> >> The test QEMU configuration is as follows: >> >> qemu-system-aarch64 \ >> -M virt,gic-version=3,virtualization=on,mte=on \ >> -cpu max,pauth-impdef=on \ >> -kernel Image \ >> -smp 8,sockets=1,cores=4,threads=2 \ >> -m 512m \ >> -nographic \ >> -no-reboot \ >> -device virtio-rng-pci \ >> -append "root=/dev/vda rw console=ttyAMA0 kgdboc=ttyAMA0,115200 \ >> earlycon preempt=voluntary irqchip.gicv3_pseudo_nmi=1" \ >> -drive if=none,file=images/rootfs.ext4,format=raw,id=hd0 \ >> -device virtio-blk-device,drive=hd0 \ >> >> Changes in v7: >> - Rebased on v6.16-rc7 and remove the merged first patch. >> - Update the commit message. >> >> Changes in v6: >> - Rebased on 6.14 rc2 next. >> - Put the syscall bits aside and split it out. >> - Have the split patch before the arm64 changes. >> - Merge some tightly coupled patches. >> - Adjust the order of some patches to make them more reasonable. >> - Define regs_irqs_disabled() by inline function. >> - Define interrupts_enabled() in terms of regs_irqs_disabled(). >> - Delete the fast_interrupts_enabled() macro. >> - irqentry_state_t -> arm64_irqentry_state_t. >> - Remove arch_exit_to_user_mode_prepare() and pull local_daif_mask() later >> in the arm64 exit sequence >> - Update the commit message. >> >> Changes in v5: >> - Not change arm32 and keep inerrupts_enabled() macro for gicv3 driver. >> - Move irqentry_state definition into arch/arm64/kernel/entry-common.c. >> - Avoid removing the __enter_from_*() and __exit_to_*() wrappers. >> - Update "irqentry_state_t ret/irq_state" to "state" >> to keep it consistently. >> - Use generic irq entry header for PREEMPT_DYNAMIC after split >> the generic entry. >> - Also refactor the ARM64 syscall code. >> - Introduce arch_ptrace_report_syscall_entry/exit(), instead of >> arch_pre/post_report_syscall_entry/exit() to simplify code. >> - Make the syscall patches clear separation. >> - Update the commit message. >> >> Changes in v4: >> - Rework/cleanup split into a few patches as Mark suggested. >> - Replace interrupts_enabled() macro with regs_irqs_disabled(), instead >> of left it here. >> - Remove rcu and lockdep state in pt_regs by using temporary >> irqentry_state_t as Mark suggested. >> - Remove some unnecessary intermediate functions to make it clear. >> - Rework preempt irq and PREEMPT_DYNAMIC code >> to make the switch more clear. >> - arch_prepare_*_entry/exit() -> arch_pre_*_entry/exit(). >> - Expand the arch functions comment. >> - Make arch functions closer to its caller. >> - Declare saved_reg in for block. >> - Remove arch_exit_to_kernel_mode_prepare(), arch_enter_from_kernel_mode(). >> - Adjust "Add few arch functions to use generic entry" patch to be >> the penultimate. >> - Update the commit message. >> - Add suggested-by. >> >> Changes in v3: >> - Test the MTE test cases. >> - Handle forget_syscall() in arch_post_report_syscall_entry() >> - Make the arch funcs not use __weak as Thomas suggested, so move >> the arch funcs to entry-common.h, and make arch_forget_syscall() folded >> in arch_post_report_syscall_entry() as suggested. >> - Move report_single_step() to thread_info.h for arm64 >> - Change __always_inline() to inline, add inline for the other arch funcs. >> - Remove unused signal.h for entry-common.h. >> - Add Suggested-by. >> - Update the commit message. >> >> Changes in v2: >> - Add tested-by. >> - Fix a bug that not call arch_post_report_syscall_entry() in >> syscall_trace_enter() if ptrace_report_syscall_entry() return not zero. >> - Refactor report_syscall(). >> - Add comment for arch_prepare_report_syscall_exit(). >> - Adjust entry-common.h header file inclusion to alphabetical order. >> - Update the commit message. >> >> Jinjie Ruan (7): >> arm64: ptrace: Replace interrupts_enabled() with regs_irqs_disabled() >> arm64: entry: Refactor the entry and exit for exceptions from EL1 >> arm64: entry: Rework arm64_preempt_schedule_irq() >> arm64: entry: Use preempt_count() and need_resched() helper >> arm64: entry: Refactor preempt_schedule_irq() check code >> arm64: entry: Move arm64_preempt_schedule_irq() into >> __exit_to_kernel_mode() >> arm64: entry: Switch to generic IRQ entry >> >> arch/arm64/Kconfig | 1 + >> arch/arm64/include/asm/daifflags.h | 2 +- >> arch/arm64/include/asm/entry-common.h | 56 ++++ >> arch/arm64/include/asm/preempt.h | 2 - >> arch/arm64/include/asm/ptrace.h | 13 +- >> arch/arm64/include/asm/xen/events.h | 2 +- >> arch/arm64/kernel/acpi.c | 2 +- >> arch/arm64/kernel/debug-monitors.c | 2 +- >> arch/arm64/kernel/entry-common.c | 411 +++++++++----------------- >> arch/arm64/kernel/sdei.c | 2 +- >> arch/arm64/kernel/signal.c | 3 +- >> kernel/entry/common.c | 16 +- >> 12 files changed, 217 insertions(+), 295 deletions(-) >> create mode 100644 arch/arm64/include/asm/entry-common.h >> >> -- >> 2.34.1 >> >