From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5B2EC433E7 for ; Tue, 1 Sep 2020 16:11:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6ABDB204EC for ; Tue, 1 Sep 2020 16:11:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SclBQilg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C+h+cgcv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6ABDB204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pr3wHZuThkQ2Do7QRiVNU43nuyhQVZOz31Vqgaejf/o=; b=SclBQilgI1/6qIqJw/Xy6MgBg z9jA9qCr+RPwcfQJHoK2MOmpT4o3axT7H7lblXixOuAks2zTQI2AKHfgTD7SJOVhxpFE2MS6hIx0J SRnJawlmF5rQForVxQlT2HMVf570KCO/omVeu65llvzin7G+8xo8Cu6VcfxlW5YiM9bbjDofqksEu WANLypoA9FRLtBrEECZ51YKpXRoMiXp/SMHcr3+uYNgMkVvp6WjeokURQff3fYwJujETx0Nj3rvwK zwMbK6iS42mgpS5RMVIuwRTFmyugtdw8mcFka5XrPNF6CtdI4n6RacnYddb35jzxEKm2bjtJffgBX FqqFaBRIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD8rU-00070D-RH; Tue, 01 Sep 2020 16:10:20 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD8rR-0006zF-Qu; Tue, 01 Sep 2020 16:10:18 +0000 Received: by mail-pf1-x441.google.com with SMTP id u128so1049234pfb.6; Tue, 01 Sep 2020 09:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=NsQXaCw31y4r2uMbkl6htgoK/WBIwM078xbS0cXU+7w=; b=C+h+cgcvCdrvsyM+XY6TVnknhOFCDL5CwskerXbP75VOQCWFbZN3VDOoKK3mYDE2Ho 8xjUAX4TZXOr5ocf08At2G3jXdQXJXMFupaCuTuTXAoiKMbK4Vi3Q78rpCYWKBgOwzej lV3M/pKI9jlR+vlE1meAo8UfT7hEOtb97EepRRb0Vuk4nA5YMqzjfs6e/QSo8Yy+Mo3R y3u1rufk8yt3lNvVzPqtvAsa1UXgPCKr80Q3iKwWX9MMxdWS+YISCPaOk3ghRT/XfZvj z9nIlBWyKqiSbwDVHY7XB0jmbZ10rqZRfEL24/Xato3AxOJXYDsx+kYrEz/GtCtS23lW I9+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NsQXaCw31y4r2uMbkl6htgoK/WBIwM078xbS0cXU+7w=; b=BZGQOhz6ioP9V9m3Cd5Z5Shv+HAClX1gyD7xHIx0PgxDJtSDL5YDfi+04lfk5eJxfQ Znd4Y8+NlDXIqszHtcYuRBb6KbCfv5APylfkOPt4Z/aAanRtj25H9+nNCRXOFn4Zn/Ij N4aQ9ZTt2ls8Kdhb+vVtM3wMw9v7YnnrtrRD7PcCcX4Jp+VOtb3LyM11otMxUTLK5Kmo yOElbyGbc9zmqnEXrBcTPASXZvU59P0Gh1964FwVqY7Bw5kcaJjVPcicniQAUmvJTLn0 xK2zUjYnAi/eZZXkraOcl1njvfz5r7hByp19+boof6y9YzobotXOxnuhK1HC/KiDTZUU i3bA== X-Gm-Message-State: AOAM532il2YhPjpGQCMkCGS2eUyzIr9HNaS+b9cxGJ2c2i39CBnWYYyn ZUKd4842kpLX+8eg2EbjcEk= X-Google-Smtp-Source: ABdhPJwKtA1KUbqtGdo3afUnY5etbEnRl0rJyDOflcBsCus3lfPEuSBXspRQU1fIzltpiNIbRaOsAQ== X-Received: by 2002:a63:4e5e:: with SMTP id o30mr2091042pgl.254.1598976615541; Tue, 01 Sep 2020 09:10:15 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id c3sm2506092pfo.120.2020.09.01.09.10.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2020 09:10:14 -0700 (PDT) Subject: Re: [PATCH 1/2] serial: 8250: Simplify with dev_err_probe() To: Krzysztof Kozlowski , Greg Kroah-Hartman , Jiri Slaby , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Paul Cercueil , Lukas Wunner , linux-serial@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20200901153100.18827-1-krzk@kernel.org> From: Florian Fainelli Message-ID: <04f68fe6-2f92-031d-a96f-e93d7c741d88@gmail.com> Date: Tue, 1 Sep 2020 09:10:12 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.1.1 MIME-Version: 1.0 In-Reply-To: <20200901153100.18827-1-krzk@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_121017_872836_B4382A3C X-CRM114-Status: GOOD ( 20.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/1/2020 8:30 AM, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/tty/serial/8250/8250_bcm2835aux.c | 12 +++--------- > drivers/tty/serial/8250/8250_ingenic.c | 20 ++++++-------------- > 2 files changed, 9 insertions(+), 23 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c b/drivers/tty/serial/8250/8250_bcm2835aux.c > index 12d03e678295..fd95860cd661 100644 > --- a/drivers/tty/serial/8250/8250_bcm2835aux.c > +++ b/drivers/tty/serial/8250/8250_bcm2835aux.c > @@ -110,12 +110,8 @@ static int bcm2835aux_serial_probe(struct platform_device *pdev) > > /* get the clock - this also enables the HW */ > data->clk = devm_clk_get(&pdev->dev, NULL); > - ret = PTR_ERR_OR_ZERO(data->clk); > - if (ret) { > - if (ret != -EPROBE_DEFER) > - dev_err(&pdev->dev, "could not get clk: %d\n", ret); > - return ret; > - } > + if (IS_ERR(data->clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(data->clk), "could not get clk\n"); For 8250_bcm2835aux.c: Acked-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel