From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC7EDC7EE23 for ; Thu, 8 Jun 2023 09:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/0dsTQNmlqE02rmpeeqkeK8Q7P/tXQyr3u8HQ0JQ+fc=; b=3F457BpDaCaMVz 7jPXHqEW5w1dWDSibZYFY6fAXiDAAf/rUl+ieKogNTkST9IGXhvdRP118lXZFxWQQstrecpifmCZT LWZTOhMqdvL7YYKL9PGOF6+ta2BXZ8ROdNXRa8TRIGNgZVuHhbmC96tmuhmpDCaaQ6JpkwSf2vnFd JxDbmXBInN2m/IkNY5lmLHoDe2vtCq2QuBNmwySPw/0rVTlR97madrYXT891KvV1LsHxOnbOC6vTG Ezpr6bJ25aQZgI9FtdCmKUKOBZGN1Ro4U14mWsjJ2n4w51uERHnNAWIKnyZMxd7aMDwHWVXUNiLqg d0w2PhziBQNcFHaZyjug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7BuI-008gHE-1H; Thu, 08 Jun 2023 09:26:14 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7BuF-008gGT-20 for linux-arm-kernel@lists.infradead.org; Thu, 08 Jun 2023 09:26:13 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5149bdb59daso524684a12.2 for ; Thu, 08 Jun 2023 02:26:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686216366; x=1688808366; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=03BJWd8kwUz/PX6fs8czwd8z71E5lrJAOIWmRROBv7A=; b=BCIwoqj1/HqVJuDuxVAPMqTyjB7V+UwDfa6WmqI61Vv2CH/q907TPnwZe8lDCpshaP U4i7ixKUvm1351RYVjsAhT9Zv6VELRHMbQjnxeUjQkRXh35mJFHGoA+MV5Yk60gI/iQW CGABrPWuL+d7yOjaOTTOJAde32O0Noo0O2ksbE/w5wnMEL3923L0wk54rPaWnlGJ75k5 Jx4cQ4OjixStgbtr7fVmI0Upx0Hy79un2WUtUW2hW7eFYwepScbBNpuP4zD6/RbrxUN0 w9Tp8YFaarb6Zw632o/8V87KKfbZPJ7WoP1MzWj0Xku9FYsCdmx0rEO7iN4j8zy+ODNd ZviA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686216366; x=1688808366; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=03BJWd8kwUz/PX6fs8czwd8z71E5lrJAOIWmRROBv7A=; b=EZilm25NxSTtLX84tD4ZdMzG8Hkg49TCJtLJig1efUwhL6UcOp6pF4bf16+9b9usij CocgNaF8moaSy0Q6FQf8fO6cZxBxs4FtMPzMj0lCGF9p+JpDV073VM/xLpFwBLcAwmt4 4CusZw9CDKyl67kDziKrKDM/LtTfJeGaNeUZkH1nA5QuFJj03lSqAxJQP5ugra0Axh4U TOyj7i9d4czo8eySgfIjWHrHIEHnXws36eAfddzzDeuyqBnZP7IHWbyH9gR4m1FMzISe RXRHy/UjqDdP71RJ5L3qa8xdfTL2ic4jahEBXv1bvl8o/OSLIofFVSUQyJtszLsf8aRI npUA== X-Gm-Message-State: AC+VfDxfZtkhihEu8UtaGsmaaglNn6PvL18AnhAPqiVGay8s05HXmyN2 eAdu13stmv3LelFqhMTQhxaB8Q== X-Google-Smtp-Source: ACHHUZ7OEP3vwBVFqBeczcFqR9O9YzQQuofZmkKRaPneB03HPeNiGD9Xju5/x1O66AFVuWpIlRBApA== X-Received: by 2002:aa7:dc04:0:b0:514:9c80:e3ff with SMTP id b4-20020aa7dc04000000b005149c80e3ffmr6237809edu.2.1686216366279; Thu, 08 Jun 2023 02:26:06 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id g16-20020aa7c590000000b0051056dc47e0sm326588edq.8.2023.06.08.02.26.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 02:26:05 -0700 (PDT) Message-ID: <05038be8-f59d-5b2b-9b51-36094941f731@linaro.org> Date: Thu, 8 Jun 2023 11:26:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [v6 1/4] dt-bindings: pwm: Add ASPEED PWM Control documentation Content-Language: en-US To: Billy Tsai , "jdelvare@suse.com" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "thierry.reding@gmail.com" , "u.kleine-koenig@pengutronix.de" , "corbet@lwn.net" , "p.zabel@pengutronix.de" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "patrick@stwcx.xyz" References: <20230608021839.12769-1-billy_tsai@aspeedtech.com> <20230608021839.12769-2-billy_tsai@aspeedtech.com> <4dffd320-8e30-fb30-6ded-79519afddc21@linaro.org> <61278e12-ba39-4503-ca74-a7118b0f6e99@linaro.org> <9f8a9208-62d4-0c96-7d1c-a452d3d7e799@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_022611_663860_F5B62FBE X-CRM114-Status: GOOD ( 18.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/06/2023 10:57, Billy Tsai wrote: > On 08/06/2023 10:21, Billy Tsai wrote: > >> On 08/06/2023 09:47, Billy Tsai wrote: > >> >> > >> >> >> + > >> >> >> +allOf: > >> >> >> + - $ref: pwm.yaml# > >> >> >> + > >> >> >> +properties: > >> >> >> + compatible: > >> >> >> + enum: > >> >> >> + - aspeed,ast2600-pwm > >> >> >> + > >> >> >> + "#pwm-cells": > >> >> >> + const: 3 > >> >> > >> >> > 3 cells? For one PWM? What are they? > >> >> > >> >> channel, period and polarity. > >> > >> > Don't cut my responses. You wrote you have one PWM output, so only one > >> > channel. What do you put then in the channel? > >> > >> You need to put 0 in the cell of the channel, the example of the dts usage will like following: > > > If you always put 0 isn't this a proof that it's wrong? > > No, if your PWM controller only has one pwm output, then it should only be configured as 0. > This is the usage of the pwm-cells property. > https://github.com/torvalds/linux/blob/master/drivers/pwm/core.c#L129-L158 This is only when you use generic of_xlate. You do not have to use generic of_xlate if it does not suite you. Again you speak about the drivers, but we talk about bindings: https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/pwm/pwm.txt#L13 "controller specific" > https://github.com/torvalds/linux/blob/master/include/linux/pwm.h#LL299C20-L299C20 > All of the pwm driver with npwm = 1 will has the same usage. So it seems many simplified their drivers... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel