From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0348C282CE for ; Fri, 5 Apr 2019 16:28:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF8922146F for ; Fri, 5 Apr 2019 16:28:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BOVpZ2Sh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF8922146F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:Reply-To :List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Date:To:From:Subject:Message-ID: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rtLBPdr73Y2yyj2QQbXmSlX5GgTAT8Kbqd9zypmOmEU=; b=BOVpZ2ShuwWhUw+CCmYMwRJmp 8dJ3qebsXXEfP856PLkwggUdRGyaCc3sK7RpRO7tuUwrr32nxO6+6O8Spd9VDs3unLbT4rGOCoqmg IC2hQm54c+EXwKOcTmf/y2+onhrW6fnMIUW9NURERIkp+MqLD2nT3v3KfsAwdpkaZCN2TDBeIuxkW 3w9KFeQU+5HdGFXNWbEVARpWkMZRjIkN5yipXt24Em69BF7R2gVC9xIlsPu1Bhc7lB61yG0ElOBhU CP7O5r9PoV5Gklc/SfckqH4SrqjcRf1qqbFaFEi5aWlzo5aGNO4oN8Kyzip2dKYhDeVxnvUtzd/sD NXXadcokw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCRhB-0006D0-BX; Fri, 05 Apr 2019 16:28:01 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCRh7-0006C8-NR for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2019 16:27:59 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nicolas) with ESMTPSA id 17FF128226F Message-ID: <05078223a4098c96f6260f77e9ef2a01b966daa6.camel@collabora.com> Subject: Re: [PATCH RESEND v7 1/2] media: uapi: Add H264 low-level decoder API compound controls. From: Nicolas Dufresne To: Maxime Ripard Date: Fri, 05 Apr 2019 12:27:48 -0400 In-Reply-To: <20190405151552.biesirbs35uivk7d@flea> References: <7cd913545cfc80fa9999839c62c4bf7b354a7904.1554380738.git-series.maxime.ripard@bootlin.com> <20190405151552.biesirbs35uivk7d@flea> Organization: Collabora Ltd. User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190405_092758_028168_E776E77C X-CRM114-Status: GOOD ( 24.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Nicolas Dufresne Cc: "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Thomas Petazzoni , Alexandre Courbot , Jonas Karlman , Jens Kuske , linux-sunxi , Linux Kernel Mailing List , Jernej Skrabec , Tomasz Figa , Paul Kocialkowski , Chen-Yu Tsai , Hans Verkuil , Laurent Pinchart , Sakari Ailus , Guenter Roeck , Ezequiel Garcia , Pawel Osciak , Linux Media Mailing List Content-Type: multipart/mixed; boundary="===============3146303883966762198==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3146303883966762198== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-105qp6mZm6hZVbLbDG+d" --=-105qp6mZm6hZVbLbDG+d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le vendredi 05 avril 2019 =C3=A0 17:15 +0200, Maxime Ripard a =C3=A9crit : > Hi Nicolas, >=20 > On Thu, Apr 04, 2019 at 11:41:13AM -0400, Nicolas Dufresne wrote: > > > > > + * - __u16 > > > > > + - ``pic_width_in_mbs_minus1`` > > > > > + - > > > > > + * - __u16 > > > > > + - ``pic_height_in_map_units_minus1`` > > > > > + - > > > >=20 > > > > We recently had some reflection with Alex that this is redundant wi= th > > > > the width and height in the OUTPUT format. It may also apply to som= e > > > > other fields in these structs. I feel like they should be removed a= nd > > > > passed via corresponding generic V4L2 properties - format, selectio= n, > > > > etc. > > > >=20 > > > > The same problem is also present in the MPEG2 controls. In fact, th= ere > > > > was a patch already which used some fields from the controls to > > > > calculate the destination buffer strides, rather than bytesperline = in > > > > the format. > > > >=20 > > > > Since we're in staging, it could be done with a follow-up patch, th= ough. > > >=20 > > > Just my two cents. I played with some codecs a while back. IIRC some > > > specify a "codec" size in addition to the actual picture size, like > > > when the encoder does padding to fit the requirements of the codec > > > (spec). Is this needed anywhere? > >=20 > > With state-less encoders, the headers, which contains the crop > > information is created by userspace and for state less decoder, the > > headers that contains this information is parsed by userspace. So I > > believe that in theory, the accelerator does not strictly need to be > > aware of the cropped dimensions. > >=20 > > Another thing, is that there is not guarantied matches between e.g. > > depth of the chrome/luma and the final image buffers. Some hardware may > > have bandwidth limitation or internal converter and could possibly > > decode 10bit data into 8bit buffers. > >=20 > > A third reason why I would not try and encode this header information > > is that there can be multiple PPS/SPS at the same time, and I think > > it's confusing if the relevant information to differentiate them is > > removed. >=20 > Sorry if that sounds a bit dumb, but it's not really clear to me if > you're arguing for the removal of the data as Tomasz suggests, or if > you want to keep them. >=20 > The first paragrah seems to advocate for the former, but the two > others for the latter. I think the data should stay. As I said, there can be multiple SPS/PPS, while there is only one format. That being said, how does SPS/PPS activation works ? How do you tell the driver about all the SPS/PPS and which one is being activated ? >=20 > Thanks! > Maxime >=20 > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com --=-105qp6mZm6hZVbLbDG+d Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSScpfJiL+hb5vvd45xUwItrAaoHAUCXKeCBQAKCRBxUwItrAao HPxYAKCLokQMygHQVcEBVlfoU/0wx7JIPQCgigkxrrILs+98mkAhfw91CijNlVI= =lZ4c -----END PGP SIGNATURE----- --=-105qp6mZm6hZVbLbDG+d-- --===============3146303883966762198== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3146303883966762198==--