From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3302BC3F2C6 for ; Tue, 3 Mar 2020 23:30:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2A3720716 for ; Tue, 3 Mar 2020 23:30:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ManQaHLS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Cos45C9Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2A3720716 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/a7upCdIAkIVzAleJN9aJ4mpOxqdQKjvghwEwXMvIys=; b=ManQaHLSK6psZSISGhQ7xOBJZ KgolnisDY9H7cDKCuxhqkXNGxAzlKptNABTagLb88jHPy9muOciQ9d2rxx5YhgGCLFSHBGxobaSlv 09kVw3xxm6gOrVAWZCVJ2m1ZNNkpGr6cw/R98Nr7gqxEbIRaXnDzAq3XWpsTSaq5AMy7TER77WX/c Qk/cZTMoKdwHHkma7lYnWFj61XKK5q0D+xK4YftUOy322wMpV2aKIY2ImISJBFR3gChYqxKeK1TcV rHn+hMe7ucuMROeaaojpcb+bPE9059c4ncrAG95T5EBTIi91IoXOSnT9W0fC9fSERBxRw3lh2D+2X k0sAY80jA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9H03-0008Lb-RK; Tue, 03 Mar 2020 23:30:55 +0000 Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9Gzy-0008Kd-Qe for linux-arm-kernel@lists.infradead.org; Tue, 03 Mar 2020 23:30:53 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1583278251; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=J7FQkIMZ5j8fIoYnJpIQnIykDivoVUW88IiijYyPyhQ=; b=Cos45C9Y8dn2q8BRshqleGDEM+YiuKulR5CGiCT9w0mj6L6s+i2UrkCTdCbXJ+EK3EHbr9Nx xpQ68mBoGQeoID8OVqZpAU8mRTiHbFssZlVsqQdm/IVRmgsKXxsnWwSogW+V41FyO571PcZZ XV0QGI+LCo5XVdkna1aDPz0GEjE= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e5ee89f.7fe2f6503ed8-smtp-out-n01; Tue, 03 Mar 2020 23:30:39 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5DF79C4479C; Tue, 3 Mar 2020 23:30:38 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rishabhb) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2AE2FC433A2; Tue, 3 Mar 2020 23:30:37 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 03 Mar 2020 15:30:37 -0800 From: rishabhb@codeaurora.org To: Mathieu Poirier Subject: Re: [PATCH 6/6] remoteproc: qcom: Add notification types to SSR In-Reply-To: References: <1582167465-2549-1-git-send-email-sidgup@codeaurora.org> <1582167465-2549-7-git-send-email-sidgup@codeaurora.org> <20200227215940.GC20116@xps15> <1a615fcd5a5c435d1d8babe8d5c3f8c3@codeaurora.org> <20200228183832.GA23026@xps15> Message-ID: <050a8613cd00a84678b4478ef3387465@codeaurora.org> X-Sender: rishabhb@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200303_153051_520543_907DFB36 X-CRM114-Status: GOOD ( 33.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben-Cohen , tsoni@codeaurora.org, linux-arm-msm , linux-remoteproc , Linux Kernel Mailing List , Bjorn Andersson , Andy Gross , linux-remoteproc-owner@vger.kernel.org, Siddharth Gupta , psodagud@codeaurora.org, linux-arm-kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-03-03 10:05, Mathieu Poirier wrote: > On Mon, 2 Mar 2020 at 13:54, wrote: >> >> On 2020-02-28 10:38, Mathieu Poirier wrote: >> > On Thu, Feb 27, 2020 at 04:00:21PM -0800, rishabhb@codeaurora.org >> > wrote: >> >> On 2020-02-27 13:59, Mathieu Poirier wrote: >> >> > On Wed, Feb 19, 2020 at 06:57:45PM -0800, Siddharth Gupta wrote: >> >> > > The SSR subdevice only adds callback for the unprepare event. Add >> >> > > callbacks >> >> > > for unprepare, start and prepare events. The client driver for a >> >> > > particular >> >> > > remoteproc might be interested in knowing the status of the remoteproc >> >> > > while undergoing SSR, not just when the remoteproc has finished >> >> > > shutting >> >> > > down. >> >> > > >> >> > > Signed-off-by: Siddharth Gupta >> >> > > --- >> >> > > drivers/remoteproc/qcom_common.c | 39 >> >> > > +++++++++++++++++++++++++++++++++++---- >> >> > > include/linux/remoteproc.h | 15 +++++++++++++++ >> >> > > 2 files changed, 50 insertions(+), 4 deletions(-) >> >> > > >> >> > > diff --git a/drivers/remoteproc/qcom_common.c >> >> > > b/drivers/remoteproc/qcom_common.c >> >> > > index 6714f27..6f04a5b 100644 >> >> > > --- a/drivers/remoteproc/qcom_common.c >> >> > > +++ b/drivers/remoteproc/qcom_common.c >> >> > > @@ -183,9 +183,9 @@ EXPORT_SYMBOL_GPL(qcom_remove_smd_subdev); >> >> > > * >> >> > > * Returns pointer to srcu notifier head on success, ERR_PTR on >> >> > > failure. >> >> > > * >> >> > > - * This registers the @notify function as handler for restart >> >> > > notifications. As >> >> > > - * remote processors are stopped this function will be called, with >> >> > > the rproc >> >> > > - * pointer passed as a parameter. >> >> > > + * This registers the @notify function as handler for >> >> > > powerup/shutdown >> >> > > + * notifications. This function will be invoked inside the >> >> > > callbacks registered >> >> > > + * for the ssr subdevice, with the rproc pointer passed as a >> >> > > parameter. >> >> > > */ >> >> > > void *qcom_register_ssr_notifier(struct rproc *rproc, struct >> >> > > notifier_block *nb) >> >> > > { >> >> > > @@ -227,11 +227,39 @@ int qcom_unregister_ssr_notifier(void *notify, >> >> > > struct notifier_block *nb) >> >> > > } >> >> > > EXPORT_SYMBOL_GPL(qcom_unregister_ssr_notifier); >> >> > > >> >> > > +static int ssr_notify_prepare(struct rproc_subdev *subdev) >> >> > > +{ >> >> > > + struct qcom_rproc_ssr *ssr = to_ssr_subdev(subdev); >> >> > > + >> >> > > + srcu_notifier_call_chain(ssr->rproc_notif_list, >> >> > > + RPROC_BEFORE_POWERUP, (void *)ssr->name); >> >> > > + return 0; >> >> > > +} >> >> > > + >> >> > > +static int ssr_notify_start(struct rproc_subdev *subdev) >> >> > > +{ >> >> > > + struct qcom_rproc_ssr *ssr = to_ssr_subdev(subdev); >> >> > > + >> >> > > + srcu_notifier_call_chain(ssr->rproc_notif_list, >> >> > > + RPROC_AFTER_POWERUP, (void *)ssr->name); >> >> > > + return 0; >> >> > > +} >> >> > > + >> >> > > +static void ssr_notify_stop(struct rproc_subdev *subdev, bool >> >> > > crashed) >> >> > > +{ >> >> > > + struct qcom_rproc_ssr *ssr = to_ssr_subdev(subdev); >> >> > > + >> >> > > + srcu_notifier_call_chain(ssr->rproc_notif_list, >> >> > > + RPROC_BEFORE_SHUTDOWN, (void *)ssr->name); >> >> > > +} >> >> > > + >> >> > > + >> >> > > static void ssr_notify_unprepare(struct rproc_subdev *subdev) >> >> > > { >> >> > > struct qcom_rproc_ssr *ssr = to_ssr_subdev(subdev); >> >> > > >> >> > > - srcu_notifier_call_chain(ssr->rproc_notif_list, 0, (void >> >> > > *)ssr->name); >> >> > > + srcu_notifier_call_chain(ssr->rproc_notif_list, >> >> > > + RPROC_AFTER_SHUTDOWN, (void *)ssr->name); >> >> > > } >> >> > > >> >> > > /** >> >> > > @@ -248,6 +276,9 @@ void qcom_add_ssr_subdev(struct rproc *rproc, >> >> > > struct qcom_rproc_ssr *ssr, >> >> > > { >> >> > > ssr->name = ssr_name; >> >> > > ssr->subdev.name = kstrdup("ssr_notifs", GFP_KERNEL); >> >> > > + ssr->subdev.prepare = ssr_notify_prepare; >> >> > > + ssr->subdev.start = ssr_notify_start; >> >> > > + ssr->subdev.stop = ssr_notify_stop; >> >> > >> >> > Now that I have a better understanding of what this patchset is doing, I >> >> > realise >> >> > my comments in patch 04 won't work. To differentiate the subdevs of an >> >> > rproc I >> >> > suggest to wrap them in a generic structure with a type and an enum. >> >> > That way >> >> > you can differenciate between subdevices without having to add to the >> >> > core. >> >> Ok. I can try that. >> >> > >> >> > That being said, I don't understand what patches 5 and 6 are doing... >> >> > Registering with the global ssr_notifiers allowed to gracefully shutdown >> >> > all the >> >> > MCUs in the system when one of them would go down. But now that we are >> >> > using >> >> > the notifier on a per MCU, I really don't see why each subdev couldn't >> >> > implement >> >> > the right prepare/start/stop functions. >> >> > >> >> > Am I missing something here? >> >> We only want kernel clients to be notified when the Remoteproc they >> >> are >> >> interested >> >> in changes state. For e.g. audio kernel driver should be notified when >> >> audio >> >> processor goes down but it does not care about any other remoteproc. >> >> If you are suggesting that these kernel clients be added as subdevices >> >> then >> >> we will end up having many subdevices registered to each remoteproc. >> >> So we >> >> implemented a notifier chain per Remoteproc. This keeps the SSR >> >> notifications as >> >> the subdevice per remoteproc, and all interested clients can register >> >> to it. >> > >> > It seems like I am missing information... Your are referring to >> > "kernel >> > clients" and as such I must assume some drivers that are not part of >> > the >> > remoteproc/rpmsg subsystems are calling qcom_register_ssr_notifier(). >> > I must >> Yes these are not part of remoteproc framework and they will register >> for notifications. >> > also assume these drivers (or that functionality) are not yet upsream >> > because >> > all I can see calling qcom_register_ssr_notifier() is >> > qcom_glink_ssr_probe(). >> Correct.These are not upstreamed. > > Ok, things are starting to make sense. > >> > >> > Speaking of which, what is the role of the qcom_glink_ssr_driver? Is >> > the glink >> > device that driver is handling the same as the glink device registed in >> > adsp_probe() and q6v5_probe()? >> glink ssr driver will send out notifications to remoteprocs that have >> opened the >> "glink_ssr" channel that some subsystem has gone down or booted up. >> This >> helps notify >> neighboring subsystems about change in state of any other subsystem. > > I am still looking for an answer to my second question. Yes its the subdevice of the glink device that is registered in adsp_probe. It uses the "glink_ssr" glink channel. > >> > >> >> > >> >> > >> >> > > ssr->subdev.unprepare = ssr_notify_unprepare; >> >> > > ssr->rproc_notif_list = kzalloc(sizeof(struct srcu_notifier_head), >> >> > > GFP_KERNEL); >> >> > > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h >> >> > > index e2f60cc..4be4478 100644 >> >> > > --- a/include/linux/remoteproc.h >> >> > > +++ b/include/linux/remoteproc.h >> >> > > @@ -449,6 +449,21 @@ struct rproc_dump_segment { >> >> > > }; >> >> > > >> >> > > /** >> >> > > + * enum rproc_notif_type - Different stages of remoteproc >> >> > > notifications >> >> > > + * @RPROC_BEFORE_SHUTDOWN: unprepare stage of remoteproc >> >> > > + * @RPROC_AFTER_SHUTDOWN: stop stage of remoteproc >> >> > > + * @RPROC_BEFORE_POWERUP: prepare stage of remoteproc >> >> > > + * @RPROC_AFTER_POWERUP: start stage of remoteproc >> >> > > + */ >> >> > > +enum rproc_notif_type { >> >> > > + RPROC_BEFORE_SHUTDOWN, >> >> > > + RPROC_AFTER_SHUTDOWN, >> >> > > + RPROC_BEFORE_POWERUP, >> >> > > + RPROC_AFTER_POWERUP, >> >> > > + RPROC_MAX >> >> > > +}; >> >> > > + >> >> > > +/** >> >> > > * struct rproc - represents a physical remote processor device >> >> > > * @node: list node of this rproc object >> >> > > * @domain: iommu domain >> >> > > -- >> >> > > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >> >> > > a Linux Foundation Collaborative Project >> >> > > >> >> > > _______________________________________________ >> >> > > linux-arm-kernel mailing list >> >> > > linux-arm-kernel@lists.infradead.org >> >> > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel