From: Thomas BOURGOIN <thomas.bourgoin@foss.st.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Lionel Debieve <lionel.debieve@foss.st.com>,
<linux-crypto@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/7] crypto: stm32 - add new algorithms support
Date: Thu, 13 Jul 2023 09:59:48 +0200 [thread overview]
Message-ID: <050aa1fb-34ab-b9e0-7772-af53ec32d312@foss.st.com> (raw)
In-Reply-To: <CACRpkdYStm_dxo-FMo4Kdw_Lm3iG+xppf7O5W6cxtoiRy1DOsw@mail.gmail.com>
Hi Linus,
On 7/13/23 00:56, Linus Walleij wrote:
> Yes this fixes the bug and the tests pass fine 😄
Great news
> I wonder why SHA1 was affected? Same codepath?
Yes the number of CSR to save is the same for SHA256 and SHA1. You can
look at the 'Context swapping' chapter (47.3.3) in the reference manual
for UX500. There is a note at the end telling that you do not have to
save all 54 register if you do HASH operation, only 38 are necessary :
> If the context swap does not involve HMAC operations, registers
cs_rk0 to cs_rk7 and
> cs_rh0 to cs_rh7 can be ignored
Best regards,
Thomas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-13 8:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 7:37 [PATCH 0/7] Support of HASH on STM32MP13 Thomas BOURGOIN
2023-07-06 7:37 ` [PATCH 1/7] dt-bindings: crypto: add new compatible for stm32-hash Thomas BOURGOIN
2023-07-06 15:50 ` Krzysztof Kozlowski
2023-07-06 7:37 ` [PATCH 2/7] crypto: stm32 - add new algorithms support Thomas BOURGOIN
2023-07-06 22:09 ` Linus Walleij
2023-07-12 7:58 ` Thomas BOURGOIN
2023-07-12 22:56 ` Linus Walleij
2023-07-13 7:59 ` Thomas BOURGOIN [this message]
2023-07-06 7:37 ` [PATCH 3/7] crypto: stm32 - remove bufcnt in stm32_hash_write_ctrl Thomas BOURGOIN
2023-07-06 7:37 ` [PATCH 4/7] crypto: stm32 - fix loop iterating through scatterlist for DMA Thomas BOURGOIN
2023-07-06 7:37 ` [PATCH 5/7] crypto: stm32 - check request size and scatterlist size when using DMA Thomas BOURGOIN
2023-07-06 7:37 ` [PATCH 6/7] crypto: stm32 - fix MDMAT condition Thomas BOURGOIN
2023-07-06 21:42 ` Linus Walleij
2023-07-06 7:37 ` [PATCH 7/7] crypto: stm32 - remove flag HASH_FLAGS_DMA_READY Thomas BOURGOIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=050aa1fb-34ab-b9e0-7772-af53ec32d312@foss.st.com \
--to=thomas.bourgoin@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lionel.debieve@foss.st.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).