From: "Sriranjani P" <sriranjani.p@samsung.com>
To: "'Rob Herring'" <robh@kernel.org>
Cc: <krzysztof.kozlowski+dt@linaro.org>, <devicetree@vger.kernel.org>,
<alim.akhtar@samsung.com>, <pankaj.dubey@samsung.com>,
<ravi.patel@samsung.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>
Subject: RE: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
Date: Wed, 14 Dec 2022 10:11:13 +0530 [thread overview]
Message-ID: <051901d90f76$4e557040$eb0050c0$@samsung.com> (raw)
In-Reply-To: <20221209211004.GA3847427-robh@kernel.org>
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 10 December 2022 02:40
> To: Sriranjani P <sriranjani.p@samsung.com>
> Cc: krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org;
> alim.akhtar@samsung.com; pankaj.dubey@samsung.com;
> ravi.patel@samsung.com; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org
> Subject: Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add
> dedicated SYSREG compatibles to Exynos850
>
> On Wed, Dec 07, 2022 at 04:20:29PM +0530, Sriranjani P wrote:
> > Exynos850 has two different SYSREGs, hence add dedicated compatibles
> > for them and deprecate usage of generic Exynos850 compatible alone.
> >
> > Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> > ---
> > .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++---
> > 1 file changed, 12 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.
> > yaml
> > b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.
> > yaml index 4954790eda6c..a37452965100 100644
> > ---
> > a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.
> > yaml
> > +++
> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sys
> > +++ reg.yaml
> > @@ -17,7 +17,6 @@ properties:
> > - samsung,exynos3-sysreg
> > - samsung,exynos4-sysreg
> > - samsung,exynos5-sysreg
> > - - samsung,exynos850-sysreg
> > - samsung,exynosautov9-sysreg
> > - tesla,fsd-cam-sysreg
> > - tesla,fsd-fsys0-sysreg @@ -33,9 +32,17 @@ properties:
> > - const: samsung,exynos5433-sysreg
> > - const: syscon
> > - items:
> > - - const: samsung,exynos5433-sysreg
> > + - enum:
> > + - const: samsung,exynos5433-sysreg
>
> This says the compatible entry is "const: samsung,exynos5433-sysreg".
>
> That should be a schema warning. You did test this, right?
Thanks for pointing it out, somehow dtbs check not showed any error. Will
fix it in the next version.
>
> Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-14 4:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221207105040epcas5p187cb82e00083eb7106f78264a76a866b@epcas5p1.samsung.com>
2022-12-07 10:50 ` [PATCH v2 0/4] amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9 Sriranjani P
2022-12-07 10:50 ` [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 Sriranjani P
2022-12-09 21:10 ` Rob Herring
2022-12-14 4:41 ` Sriranjani P [this message]
2022-12-14 8:06 ` Krzysztof Kozlowski
2022-12-07 10:50 ` [PATCH v2 2/4] arm64: dts: exynos: " Sriranjani P
2022-12-07 10:50 ` [PATCH v2 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9 Sriranjani P
2022-12-07 10:50 ` [PATCH v2 4/4] arm64: dts: exynos: " Sriranjani P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='051901d90f76$4e557040$eb0050c0$@samsung.com' \
--to=sriranjani.p@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=ravi.patel@samsung.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).