Re: [PATCH v3 1/7] media: dt-bindings: Add qcom,qcs8300-camss compatible

[Vikram Sharma <quic_vikramsa@quicinc.com>]

On 9/10/2025 2:12 PM, Bryan O'Donoghue wrote:
> On 10/09/2025 08:42, Krzysztof Kozlowski wrote:
>> On 10/09/2025 09:26, Vikram Sharma wrote:
>>>
>>> On 9/10/2025 12:35 PM, Krzysztof Kozlowski wrote:
>>>> On 13/08/2025 07:37, Vikram Sharma wrote:
>>>>> Add the compatible string "qcom,qcs8300-camss" to support the
>>>>> Camera Subsystem (CAMSS) on the Qualcomm QCS8300 platform.
>>>>>
>>>>> The QCS8300 platform provides:
>>>>> - 2 x VFE (version 690), each with 3 RDI
>>>>> - 5 x VFE Lite (version 690), each with 6 RDI
>>>>> - 2 x CSID (version 690)
>>>>> - 5 x CSID Lite (version 690)
>>>>> - 3 x CSIPHY (version 690)
>>>>> - 3 x TPG
>>>>>
>>>>> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>> ---
>>>>>    .../bindings/media/qcom,qcs8300-camss.yaml    | 336 
>>>>> ++++++++++++++++++
>>>>>    1 file changed, 336 insertions(+)
>>>> So it turns out this code is wrong and you already sent fixes for it.
>>>
>>> Hi Krzysztof,
>>> Thanks for your comments. These bindings are tested with TPG (Test 
>>> Pattern Generator), As camera sensor testing was not possible at 
>>> that point.
>>
>> You cannot test bindings with TPG. It's impossible.
>>
>>> This is because Monaco-evk kit was not ready which can be used to 
>>> enable sensor.
>>>
>>> These Bindings are complete in its own, If someone want to use TPG.
>>
>> No. You do not understand - they are not complete if you add new
>> properties to them!
>>
>> How bindings could be complete if you add now supplies!?!?
Got it, Will post an updated version of this adding supplies and 
removing your RB.
>>
>>>
>>> My latest update in these bindings are for camera sensor enablement 
>>> which needs supplies too.
>>>
>>> Please let me know if this justification works to accept these 
>>> bindings it its current form and add supplies as a separate patch.
>>
>> NAK. Read writing bindings doc. Or internal docs.
>>
>> Best regards,
>> Krzysztof
>
> @Vikram
>
> Could you send an updated dt-bindings with the supplies included ASAP 
> as a v4 of this series ?
on it, Will Remove your RB and send v3.1 for this patch
>
> The -supplies in your email here look fine
>
> 20250909114241.840842-5-quic_vikramsa@quicinc.com
>
> Otherwise we will have to drop this binding and the associated driver 
> changes.
>
> ---
> bod

Best regards,

Vikram