From: zheng-yan.chen <zheng-yan.chen@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: <dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
"Jason-JH . Lin" <jason-jh.lin@mediatek.com>,
Singo Chang <singo.chang@mediatek.com>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH 3/3] arm64: dts: Modify gamma compatible for mt8195
Date: Wed, 24 Aug 2022 10:06:58 +0800 [thread overview]
Message-ID: <055d433d0b076af2e27e89c8576d39d2e4adc237.camel@mediatek.com> (raw)
In-Reply-To: <39f63588-bc88-a716-bc66-7f93c4aabc56@linaro.org>
On Tue, 2022-08-23 at 11:40 +0300, Krzysztof Kozlowski wrote:
> On 22/08/2022 12:19, zheng-yan.chen wrote:
> > Modify gamma compatible for mt8195.
> >
> > Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com>
> >
> > ---
> > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > index a50ebb5d145f..8504d01b103a 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > @@ -2021,8 +2021,8 @@
> > mediatek,gce-client-reg = <&gce0
> > SUBSYS_1c00XXXX 0x5000 0x1000>;
> > };
> >
> > - gamma0: gamma@1c006000 {
> > - compatible = "mediatek,mt8195-disp-gamma",
> > "mediatek,mt8183-disp-gamma";
> > + gamma0: disp_gamma@1c006000 {
>
> No, really, no.
>
> Not explained in commit msg, violates naming convention, violates
> coding
> style, not related to the patch at all.
>
> Best regards,
> Krzysztof
Sorry about that, I will change this "disp_gamma" back to "gamma".
Best Regards,
Zheng-Yan Chen
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-08-24 2:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 9:19 [PATCH 0/3] Add gamma lut support for mt8195 zheng-yan.chen
2022-08-22 9:19 ` [PATCH 1/3] dt-bindings: mediatek: Add gamma compatible " zheng-yan.chen
2022-08-23 8:38 ` Krzysztof Kozlowski
2022-08-24 2:03 ` zheng-yan.chen
2022-08-22 9:19 ` [PATCH 2/3] drm/mediatek: Add gamma lut support " zheng-yan.chen
2022-08-23 3:18 ` CK Hu
2022-08-24 7:03 ` zheng-yan.chen
2022-08-25 1:40 ` CK Hu
2022-08-30 6:33 ` zheng-yan.chen
2022-08-22 9:19 ` [PATCH 3/3] arm64: dts: Modify gamma compatible " zheng-yan.chen
2022-08-23 8:40 ` Krzysztof Kozlowski
2022-08-24 2:06 ` zheng-yan.chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=055d433d0b076af2e27e89c8576d39d2e4adc237.camel@mediatek.com \
--to=zheng-yan.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-jh.lin@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=singo.chang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).