From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7B0CC43458 for ; Thu, 2 Jul 2026 08:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id: Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:Subject:Mime-Version: Content-Type:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B/aVqZJf/C6PYZntLhN+QEiyL4o0Yeerfxoh48+jmzU=; b=vvqqLA1l98Nrqszq4QZ72QtQBC AfEkFwKq7Q5JN43x12R9FdKZ6L7zD82gUF35jJJuout6WVYF+IdFqu22p+fnQ9pYnRWuRZbqw9ILm H9J6toCifjXDRK6AI3pRILHeRjoIr55rq2FzMYSQwFlp+O5vbS9LWU1Ytyk/5kby38Kdw776mq1EW yFF0xclPrjjeNfhUF7HmDrpAtSUSk5szRBmI8FT6ezAMQqtUJOWpsfaI2z/rqDGwrmM/u5N2NL/lR 4MJIw5BR8sapKhMP4pJDrZ7ebpJKo8nzud5Ddl8yT968xApS3xivqrSnfF4NhjP8honoN9CFgzE0M WrnZ4Gvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfCpV-00000003sd7-0FV9; Thu, 02 Jul 2026 08:31:29 +0000 Received: from out-187.mta1.migadu.com ([95.215.58.187]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfCpS-00000003sc1-35Hl for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2026 08:31:28 +0000 Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782981083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B/aVqZJf/C6PYZntLhN+QEiyL4o0Yeerfxoh48+jmzU=; b=daAJ1xZfVM5So6P+S4D3GZ0fQbQQOQF+ts06Q8GMhDvpA25OfUGdTWy1E37X7s+VBBq3ka bX4f6z/dYmiOXQyt7Qk9rIbeWlpuAlt0D/4ccU/NxorPu+9jlQMoIwHxbTO6AUEdTZbVza 9hVa4sjDDW+fNVa+28uJBHMXnRr4ryY= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH v2 6/6] mm/mprotect: use huge_ptep_get() for hugetlb X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20260702051341.126509-7-dev.jain@arm.com> Date: Thu, 2 Jul 2026 16:30:44 +0800 Cc: osalvador@suse.de, akpm@linux-foundation.org, ljs@kernel.org, david@kernel.org, liam@infradead.org, riel@surriel.com, vbabka@kernel.org, harry@kernel.org, jannh@google.com, lance.yang@linux.dev, kas@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcampbell@nvidia.com, apopple@nvidia.com, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, j-nomura@ce.jp.nec.com, nao.horiguchi@gmail.com, ak@linux.intel.com, mel@csn.ul.ie, pfalcato@suse.de, jpoimboe@kernel.org, dave.hansen@intel.com, tglx@kernel.org, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, ryan.roberts@arm.com, anshuman.khandual@arm.com Content-Transfer-Encoding: quoted-printable Message-Id: <05E75034-5478-42C2-A4E2-BAA6C32A485B@linux.dev> References: <20260702051341.126509-1-dev.jain@arm.com> <20260702051341.126509-7-dev.jain@arm.com> To: Dev Jain X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260702_013126_924920_845AF3E9 X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Jul 2, 2026, at 13:13, Dev Jain wrote: >=20 > prot_none_hugetlb_entry() is the hugetlb callback for the early > mprotect(PROT_NONE) PFN permission walk on x86. >=20 > The callback passes the decoded PFN to pfn_modify_allowed(). For a > hugetlb callback, the pte pointer refers to a hugetlb entry. On > architectures where hugetlb entries need huge_ptep_get(), reading that > entry with ptep_get() can make the permission check use the wrong PFN. >=20 > Use huge_ptep_get() before decoding the hugetlb PFN. >=20 > Currently there is no path which can trigger a bug: huge_ptep_get() is = a > simple ptep_get() for x86, and the prot_none walk occurs only for x86. >=20 > So no need to backport - use the correct helper anyways. >=20 > Fixes: 42e4089c7890 ("x86/speculation/l1tf: Disallow non privileged = high MMIO PROT_NONE mappings") > Signed-off-by: Dev Jain Reviewed-by: Muchun Song Thanks.=