From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
oe-kbuild@lists.linux.dev, joro@8bytes.org, will@kernel.org,
robin.murphy@arm.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, heiko@sntech.de,
nicolas.dufresne@collabora.com, jgg@ziepe.ca
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
iommu@lists.linux.dev, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v4 3/5] iommu: Add verisilicon IOMMU driver
Date: Mon, 30 Jun 2025 18:44:12 +0200 [thread overview]
Message-ID: <05a7c67f-d1fa-4ad4-a794-cc081cd04abc@collabora.com> (raw)
In-Reply-To: <9d247bec-d206-495e-b8d6-23a7c3cc0882@suswa.mountain>
Le 30/06/2025 à 18:13, Dan Carpenter a écrit :
> Hi Benjamin,
>
> kernel test robot noticed the following build warnings:
>
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Benjamin-Gaignard/dt-bindings-vendor-prefixes-Add-Verisilicon/20250623-234734
> base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> patch link: https://lore.kernel.org/r/20250623153931.158765-4-benjamin.gaignard%40collabora.com
> patch subject: [PATCH v4 3/5] iommu: Add verisilicon IOMMU driver
> config: alpha-randconfig-r073-20250627 (https://download.01.org/0day-ci/archive/20250629/202506290711.T0HOr5wS-lkp@intel.com/config)
> compiler: alpha-linux-gcc (GCC) 8.5.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes: https://lore.kernel.org/r/202506290711.T0HOr5wS-lkp@intel.com/
>
> smatch warnings:
> drivers/iommu/vsi-iommu.c:657 vsi_iommu_probe() error: uninitialized symbol 'err'.
>
> vim +/err +657 drivers/iommu/vsi-iommu.c
>
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 639 static int vsi_iommu_probe(struct platform_device *pdev)
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 640 {
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 641 struct device *dev = &pdev->dev;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 642 struct vsi_iommu *iommu;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 643 int err;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 644
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 645 iommu = devm_kzalloc(dev, sizeof(*iommu), GFP_KERNEL);
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 646 if (!iommu)
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 647 return -ENOMEM;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 648
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 649 iommu->dev = dev;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 650
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 651 iommu->regs = devm_platform_ioremap_resource(pdev, 0);
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 652 if (IS_ERR(iommu->regs))
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 653 return -ENOMEM;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 654
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 655 iommu->num_clocks = devm_clk_bulk_get_all(dev, &iommu->clocks);
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 656 if (iommu->num_clocks < 0)
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 @657 return err;
>
> s/err/iommu->num_clocks/
I will fix that in next version but I will wait for more
comments/review before send it.
Regards,
Benjamin
>
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 658
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 659 err = clk_bulk_prepare(iommu->num_clocks, iommu->clocks);
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 660 if (err)
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 661 return err;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 662
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 663 iommu->irq = platform_get_irq(pdev, 0);
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 664 if (iommu->irq < 0)
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 665 return iommu->irq;
>
next prev parent reply other threads:[~2025-06-30 17:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 15:39 [PATCH v4 0/5] Add support for Verisilicon IOMMU used by media codec blocks Benjamin Gaignard
2025-06-23 15:39 ` [PATCH v4 1/5] dt-bindings: vendor-prefixes: Add Verisilicon Benjamin Gaignard
2025-06-23 15:39 ` [PATCH v4 2/5] dt-bindings: iommu: verisilicon: Add binding for VSI IOMMU Benjamin Gaignard
2025-06-23 16:15 ` Conor Dooley
2025-06-23 15:39 ` [PATCH v4 3/5] iommu: Add verisilicon IOMMU driver Benjamin Gaignard
2025-06-24 12:14 ` kernel test robot
2025-06-30 16:13 ` Dan Carpenter
2025-06-30 16:44 ` Benjamin Gaignard [this message]
2025-07-04 17:54 ` Jason Gunthorpe
2025-07-05 10:04 ` Benjamin Gaignard
2025-07-05 18:38 ` Jason Gunthorpe
2025-06-23 15:39 ` [PATCH v4 4/5] arm64: dts: rockchip: Add verisilicon IOMMU node on RK3588 Benjamin Gaignard
2025-06-23 15:39 ` [PATCH v4 5/5] arm64: defconfig: enable Verisilicon IOMMU Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05a7c67f-d1fa-4ad4-a794-cc081cd04abc@collabora.com \
--to=benjamin.gaignard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lkp@intel.com \
--cc=nicolas.dufresne@collabora.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox