From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0917EC04EB9 for ; Wed, 5 Dec 2018 17:04:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDDED2084C for ; Wed, 5 Dec 2018 17:04:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rGJtuc4Q"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="PhA8u2/u"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="SJxpkg4b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDDED2084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DjWOKGBSs4tGsPYw7AzVsBWAEJwo9cDcCCGWd2aTpjk=; b=rGJtuc4QwrkozW10BUgiOZyeV 4JklDu6ZBVrovQNYcON99A3b1DvtvtHkPkhj8yWoDvJYOJxxjeBY6J9mvOevD63QGLnZsdkIjWSgN Qm4Ygr7d6e5F1o9+P+VO4iV5nxcAJ6fguKSMAVyYZVR78SrKmrLdT6dIwnvfBPt16km644oAkp209 X7/Rxzy5exvJtWQdH/NrGD7x9BldRGqAt3U06wZFzRjUqqXa54FPc1ti/OU0q0zsBWfxoiPhdM8If /T4go5/OUdxVC5Zm6vvbm2YtYGXp5CJzwMMHDfvGuOMiYWGsaiG8hhQKzK7ckVSsqfW217p735NyR fHtx6Vb1A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUaax-00039n-Ed; Wed, 05 Dec 2018 17:04:19 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUaan-0002wS-ML for linux-arm-kernel@lists.infradead.org; Wed, 05 Dec 2018 17:04:17 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0A23A60C1B; Wed, 5 Dec 2018 17:03:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544029439; bh=l5wrf2APMXe+GdXL3WTzhpAX1FT2V1CmTAgBI6vfm78=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PhA8u2/ud3USDnxnKFpX7TiGp6V+Qzg2oPAyS8PiAtdJCnWTQOTdijqZrb8NqF++g Lm6Ba6y4GRBY61zqzC/0cftya4CRHJUE4SBhJ/cXrp1j/rv4vL114/JaTbDWXVaeq6 yPnScuRvYiuHjbDbG0y0dPxTRT4gbGI19J62cXVk= Received: from [10.226.60.81] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0B247610DA; Wed, 5 Dec 2018 17:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544029436; bh=l5wrf2APMXe+GdXL3WTzhpAX1FT2V1CmTAgBI6vfm78=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=SJxpkg4bASA8ghurOXEQCJGKkYjLUCdGWB59GKqGlZ+7EKO08Ba3iyFMEslq4TNFg YEpJ25i6NDSm0KfsDFCm74BtlShdMjg5TyZQCeJswx+PpxDnLCPp0QDppuYxhM5hqS SNfOEKAtvz8s4HsiaZKovLlW8t/PPdA7R0jYX3wY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0B247610DA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jhugo@codeaurora.org Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: msm8998: correct xo clock name To: Bjorn Andersson References: <1542314695-24071-1-git-send-email-jhugo@codeaurora.org> <1542314695-24071-2-git-send-email-jhugo@codeaurora.org> <0ba54ffd-1d47-5ae9-ae9c-4a03d57e6ff3@codeaurora.org> <20181205164843.GB1492@tuxbook-pro> From: Jeffrey Hugo Message-ID: <05b9ee40-d51e-3f80-8ca4-217fa6fbd51c@codeaurora.org> Date: Wed, 5 Dec 2018 10:03:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20181205164843.GB1492@tuxbook-pro> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181205_090409_762587_AAF0E789 X-CRM114-Status: GOOD ( 21.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Gonzalez , Stephen Boyd , MSM , Andy Gross , Georgi Djakov , Linux ARM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/5/2018 9:48 AM, Bjorn Andersson wrote: > On Wed 05 Dec 08:38 PST 2018, Jeffrey Hugo wrote: > >> On 12/5/2018 9:12 AM, Marc Gonzalez wrote: >>> On 15/11/2018 21:44, Jeffrey Hugo wrote: >>> >>>> The root parent clock of most msm8998 clock is the "xo" clock. The DT node >>>> is incorrectly named "xo_board", which prevents Linux from correctly >>>> parsing the clock tree, resulting in most clocks being unparented and >>>> unable to be manipulated. The end result is that we can't turn on clocks >>>> for peripherals like SD, so init usually fails. >>>> >>>> Fixes: 4807c71cc688 (arm64: dts: Add msm8998 SoC and MTP board support) >>>> Reviewed-by: Bjorn Andersson >>>> Signed-off-by: Jeffrey Hugo >>>> --- >>>> arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi >>>> index 78227cc..a948d4b 100644 >>>> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi >>>> @@ -53,7 +53,7 @@ >>>> }; >>>> clocks { >>>> - xo_board { >>>> + xo { >>>> compatible = "fixed-clock"; >>>> #clock-cells = <0>; >>>> clock-frequency = <19200000>; >>>> >>> >>> Isn't there going to be a problem for msm8998 in drivers/clk/qcom/clk-smd-rpm.c >>> which uses "xo_board" for parent_names? >> >> Looks like you are right. This doesn't seem to be the correct way to >> address the issue then. I'll have to dig in and take another look. >> > > The appropriate solution is to describe references between clock drivers > explicitly in DeviceTree and by that not rely on a global namespace. > That will also sort out any initialization ordering issues that we might > have. > > But this task has not yet made it off the todo lists where it lives... Ok, that sounds great, but doesn't seem like it helps anyone today. Looks like 8916 and 8974 explicitly register an xo clock off the xo_board clock in the respective gcc drivers. 8996 does not, but I don't know how functional 8996 really is on mainline. 845 seems to register the bi_tcxo clock (the 845 version of xo) in the rpmh driver, off of xo_board. Since both Marc and I are trying to get 8998 to work, it seems like one of those two solutions would be workable, short term. How do you suggest we proceed? -- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel