From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A8DCC433EF for ; Sun, 12 Jun 2022 15:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DS/OSdF8+gzQqtCygl57rvtFmjIJ9Im4axw87R8YhMI=; b=vAyBiVut1xWjrVw9NKeVZhUy4Z CQHHYnja71UH8U2LgfruuHxgB9vEtWSLzugcIBlNr4CwH6NpS+jmelg7KKwrRDzZBHtRzasjo7qOl eW/aSYaoGczgWubJKyKt4l36xqLBHBKjgGh0g8nmaZQodwBIkQQY4MfuzsNtZR/a78Moe7Prhk4lH VyDe4eIo4iiCaCI28WJ41D4ZPVI+RXPHSP8iDYh6zXB2niXAuhxaLj1WTx4gfSQVt8PgnKttMjHUs FC6b/hN67in8HWJEjEyDVIthiWJmEmBxk167U4GgIZ5N1JBqoelb9uHQw25Lw1WMBa21En75mDFvK kOjExRlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0PCV-00GsKn-P6; Sun, 12 Jun 2022 15:08:27 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0PCS-00GsIB-Cc for linux-arm-kernel@lists.infradead.org; Sun, 12 Jun 2022 15:08:25 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 20so5322372lfz.8 for ; Sun, 12 Jun 2022 08:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=YSTRMk+mv8/8mRawNcAG/kPCu35wvaQcd0rlFYK138I=; b=WZUvQkYJDroUcqOJ8upXuhmIANC6/o+ah0+qcs9McJPFpSN0c28tLw2Wmj64Ar8FrB LUmQ5RVuPXK91F6HqDrQajzE/jegZD9LnAUwXt2DreIV7DUKsJUcjt+6TANGzeR//cjS AHwa0iznhVsX48AqkojuRRGCeIrm5Wy/w2OVHxWjZHjImnWrfT4P4sixGHu+8R4KRdr0 JdCaqdEznAqgubv1Gd9OBKCCghkB/86+bGWuBx8YOq3ueTgxDtnwiVHeqZb4SMIt3FMj 15+lEWVqmCmha3PnTN3LkvMq4p3xOEP0HW3HLHRJPi+68EM2EsVL8D3VSbnfiA/xEGtj WmGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=YSTRMk+mv8/8mRawNcAG/kPCu35wvaQcd0rlFYK138I=; b=mkfuLTBcRpx1Q4a8T4Q6sk1r0hIdCgnWKw0MHeAS1LCV5yof3/LZoKVGA8Zztey/vS 4osTXxrjwP+I9moHBLXbNOt6onpWSiPpv56B344sX60/Nw/KqmzNVWsceGIJsYabCDHB flrlD5jaZ/uEM3rg/Hr5VGmXc9zJlxu1nOt31EBIjKs01HAp8abFB00mXYAeYw8b7krN T5wZgJ2Loo1O2RadfdDqPO6ZeJcH58XhpXhCfsVlTS0hy1rhLHrpgFvZuaxJDWLZGrMD L/Ui2eG1JJ70UyYf24NpyR1nDO2nZTFhjLIiBFvcs5GQwsdI5zWVFLAqqpiOHviQGQ92 4kDQ== X-Gm-Message-State: AOAM532d/nWCETOIWXR3AEfoxkA1JxCDx38aelhvnlJsAZPQMHUc3nb8 BdbUcPsMVUAPsTCBMrnGW/8= X-Google-Smtp-Source: ABdhPJyLgiK/n2xx4Qe5//vI4+DUPK3WLlmcmSPS95xxOHNSYLqB5p+YktGpTd9iX+kUMZKX3EvtNA== X-Received: by 2002:a05:6512:3d23:b0:478:fa1e:70fe with SMTP id d35-20020a0565123d2300b00478fa1e70femr33703531lfv.530.1655046502168; Sun, 12 Jun 2022 08:08:22 -0700 (PDT) Received: from [192.168.0.131] ([194.183.54.57]) by smtp.gmail.com with ESMTPSA id g2-20020a056512118200b00477c164293csm640383lfr.79.2022.06.12.08.08.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jun 2022 08:08:21 -0700 (PDT) Message-ID: <05c9128d-6228-40e5-ad69-1334a81d786e@gmail.com> Date: Sun, 12 Jun 2022 17:08:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/3] dt-bindings: leds: skyworks,aat1290: convert to dtschema Content-Language: en-US To: Krzysztof Kozlowski , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20220607085343.72414-1-krzysztof.kozlowski@linaro.org> <410c5c97-8ff7-2303-5e19-d6053d3779dd@linaro.org> From: Jacek Anaszewski In-Reply-To: <410c5c97-8ff7-2303-5e19-d6053d3779dd@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220612_080824_481591_B0F2D5E4 X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/10/22 12:12, Krzysztof Kozlowski wrote: > On 09/06/2022 22:28, Jacek Anaszewski wrote: >> Hi Krzysztof, >> >> On 6/7/22 10:53, Krzysztof Kozlowski wrote: >>> Convert the Skyworks Solutions, Inc. AAT1290 Current Regulator bindings >>> to DT Schema. >>> >>> Signed-off-by: Krzysztof Kozlowski >> [...] >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include >>> + #include >>> + >>> + // Ct = 220 nF, Rset = 160 kOhm >>> + led-controller { >>> + compatible = "skyworks,aat1290"; >>> + flen-gpios = <&gpj1 1 GPIO_ACTIVE_HIGH>; >>> + enset-gpios = <&gpj1 2 GPIO_ACTIVE_HIGH>; >>> + >>> + pinctrl-names = "default", "host", "isp"; >>> + pinctrl-0 = <&camera_flash_host>; >>> + pinctrl-1 = <&camera_flash_host>; >>> + pinctrl-2 = <&camera_flash_isp>; >>> + >>> + led { >>> + label = "flash"; >> >> Why are you adding label? It is deprecated, > > Eh, so it should be marked as deprecated:true, not just mentioned in the > description (common.yaml). I believe so. >> but has the precedence over >> new function and color for backwards compatibility, so it would make >> those unused by the driver now. Please drop the label from this example. > > I synced the example with DTS, but I can drop it. No problem. Yeah, let's avoid further confusion. -- Best regards, Jacek Anaszewski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel