From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D37D1C3DA59 for ; Fri, 19 Jul 2024 11:29:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Subject:Cc:To: From:Date:References:In-Reply-To:Message-Id:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r/mNmunF4XYM9lHwpvMhWNpNNiXBr+47HI8/H3udo78=; b=E/Fl7Ckj8Tsnh02FpV8/oNpglh vYbglyaQucRwuAZHdxev/grYtYzhkaSS7QoeIYfftZfht9B6cjknqc5YOGDkNYDFWPlQr+09w1X4H WtohsdxvcnNhQ76D1Ojf5fJm3DH1WZKxg4KS7rOr5QRDv0+o9Eh44qhZUEfyxGQhJBzT223C/rg9a LfEwUt5NgcKXVq1u/XS6vUnegWqGbhC+OExIfKhqIHvGKA5GLBNcTOGkgxUSA9+6OFSaHhHHI96BV T1sUg3MjTBXzELWqmPByn1E6Uks506uG8WCD8cqijY56pbP1gNo9s+fBoX29wdZ8vZMGiSYIc+rx+ 5Ewm035Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUlnm-00000002W2T-47UL; Fri, 19 Jul 2024 11:29:31 +0000 Received: from fhigh8-smtp.messagingengine.com ([103.168.172.159]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUlnR-00000002VxY-1XD8 for linux-arm-kernel@lists.infradead.org; Fri, 19 Jul 2024 11:29:11 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id B43EA11406A6; Fri, 19 Jul 2024 07:29:05 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 19 Jul 2024 07:29:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1721388545; x=1721474945; bh=r/mNmunF4X YM9lHwpvMhWNpNNiXBr+47HI8/H3udo78=; b=mQJI0s4DF6X7kQCMYF6YJh5swB hVCn49Q2d1G0mKvHpSRSmbKe4wrMVixnooQqY8TF3WP0z0owTaitdmK5dAql08eu 0X3vtrZOD9wCDK4AXyKJlGVvD8U/SLMSXbjKKoYoA9NNB8E61mIFrd6297ssmpoQ KuHjaDQig370CLzoXRP/eGT9TzvAxQkGnnUmUBc6+Y8FJTrf9RGnCs9D0C9dS3yS C/wCpRQW7KhOa6ioyBFr+NpS4ZmULn8457pCSk1rRAuGMlfFOwXfiDxoCHHiBnZW iPWecw1M4VYJUwRT7ke3p4ofvt+wYQDIvaw1f9krS2abS957LOYsLcEpKVtA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1721388545; x=1721474945; bh=r/mNmunF4XYM9lHwpvMhWNpNNiXB r+47HI8/H3udo78=; b=twhcLmvxiHKHfwtb934chH1dIsNbM6vYklhw7jqkMRaE BwX7uIDZjuCuRFCTCh82iCwJo4TunLcHP5NF0Ia8ynz+kWzLmaiQiEHZGCCQ2bF4 LAbiqGbIAhOwXnwIrtfrLO+l3XjKd+O7L2VNoXgnGZi9qc2PhRp65fibiK75CXTL 1MjcxJjTlZ959hcmsnCQAL1sf0RiMHYUQx+tDL6DXWODoiH8v2dsqKfnCc4LLeFV wCq860a5cndjxBM//OY9/kgo+NN3zDIVDKSamQAyOZOreDH94BNSCKkO3YLpzqNe bldCNOlSUY/y6xF/AIBC7pR5P7LKHVUaxa2ePBLBig== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrhedugdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeelffehffevveekgefffeffvdeigfffgefhhfduveetveefgfetudejfeeugffg jeenucffohhmrghinheplhhinhhugidrohhrghdruhhknecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5F153B6008D; Fri, 19 Jul 2024 07:29:05 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-568-g843fbadbe-fm-20240701.003-g843fbadb MIME-Version: 1.0 Message-Id: <05cacd03-686a-4ede-b485-7f4781f69b99@app.fastmail.com> In-Reply-To: <3808c973-1315-420c-900d-122a73a34f9e@quicinc.com> References: <20240622-md-arm-arch-arm-probes-kprobes-v1-1-0832bd6e45db@quicinc.com> <3808c973-1315-420c-900d-122a73a34f9e@quicinc.com> Date: Fri, 19 Jul 2024 13:28:45 +0200 From: "Arnd Bergmann" To: "Jeff Johnson" , "Russell King" Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240719_042909_493907_72D89AFD X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 9, 2024, at 21:53, Jeff Johnson wrote: > On 6/22/2024 9:34 PM, Jeff Johnson wrote: >> With ARCH=arm, make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o >> >> Add the missing invocation of the MODULE_DESCRIPTION() macro. >> >> Signed-off-by: Jeff Johnson >> --- >> arch/arm/probes/kprobes/test-core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c >> index 171c7076b89f..6e9041a76b8b 100644 >> --- a/arch/arm/probes/kprobes/test-core.c >> +++ b/arch/arm/probes/kprobes/test-core.c >> @@ -1664,6 +1664,7 @@ static void __exit kprobe_test_exit(void) >> >> module_init(run_all_tests) >> module_exit(kprobe_test_exit) >> +MODULE_DESCRIPTION("ARM kprobes test module"); >> MODULE_LICENSE("GPL"); >> >> #else /* !MODULE */ >> >> --- >> base-commit: 563a50672d8a86ec4b114a4a2f44d6e7ff855f5b >> change-id: 20240622-md-arm-arch-arm-probes-kprobes-34037098a2c3 > > I don't see this in linux-next yet so following up to see if anything else is > needed to get this merged. Hi Jeff, The arm tree uses a separate submission system for reviewed patches to get into the tree, see https://www.arm.linux.org.uk/developer/patches/info.php https://www.arm.linux.org.uk/developer/patches/section.php?section=0 I looked at this file as well during build testing and ended up combining the change with a cleanup, If you like, I can send my version instead, see below. Arnd diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c index 171c7076b89f..0c6639509eff 100644 --- a/arch/arm/probes/kprobes/test-core.c +++ b/arch/arm/probes/kprobes/test-core.c @@ -1650,24 +1650,16 @@ static int __init run_all_tests(void) return ret; } - +late_initcall(run_all_tests); /* * Module setup */ -#ifdef MODULE - static void __exit kprobe_test_exit(void) { } - -module_init(run_all_tests) module_exit(kprobe_test_exit) -MODULE_LICENSE("GPL"); -#else /* !MODULE */ - -late_initcall(run_all_tests); - -#endif +MODULE_DESCRIPTION("Test code for ARM kprobes"); +MODULE_LICENSE("GPL");