From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 822AFC71153 for ; Wed, 30 Aug 2023 02:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1kTNv0RoSSnKcZHZ8Omb536mD1blP617kChu2LOwX0Y=; b=dJiRkuGR/A2q5t NJ5oeBgAU91Jxd4vQvMEGc06ja4eyeYgnIw9+PaQRCnMoN04RVR4B/fasY/aP6oM4+HYcc6LN18O3 Ky/DUpX/lwcoM/ULBOJs9La91txsJtNgGG6BozQNLCTRLgLoeOthUw7YRdVUc5DLejCX3PKqi4pqS VRXF+chTN37G44hf4ilJ0z5d6Mzf1yrdmqF/VwcCp2EYfCLrEs5SYUMk36QFCBCNvKMK34f9DD9k+ YIPzptGNjiYHUJRWzBjwYIdyXECo88p8rsC3GlP1E+9eof4cEYDNRF3cuvD1ygWllbq1jABH+SR5H XzckgVT9mbEHSC6YRhVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbB5J-00CfiK-1y; Wed, 30 Aug 2023 02:37:33 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbB5G-00Cfco-0w; Wed, 30 Aug 2023 02:37:32 +0000 X-UUID: 2597cd6a46de11ee912e1518a6540028-20230829 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=daKvlSztN9gWUbn4hEBeWRkhRvb2mM4oTQf//jh7i5A=; b=ihkgeJsw399ezPRZ9Bgr2d1wj0GxHqxM3sOBXgGIfEbtxLxwlbCUV4k+qmaT8xo+Ssb6SgAiOB+2Neakuy5p3CYhYf1hdrQV2plwbTARXW6XPdUU0DezMVt1/F26VReQZOPGmRvstkgfi4s5rLxqmEiP6t5OKNoiB1PnZqddT6s=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.31,REQID:e9163c2e-a213-48c9-8e61-19b101e82b37,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:0ad78a4,CLOUDID:8b8818ef-9a6e-4c39-b73e-f2bc08ca3dc5,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 2597cd6a46de11ee912e1518a6540028-20230829 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2010784474; Tue, 29 Aug 2023 19:37:22 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 30 Aug 2023 10:36:46 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 30 Aug 2023 10:36:46 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fvZ+gyHfbaMJ/KStNTrNgmbnzHbVDjFnqdTSImnmlOoAQr9u7A2Lx/Do06XfZ3y5WpN8WUiFO+WSy9I/sFZNmk96JymCqXZtU1nAH+/2ZptiKn1oProc0Ud75Tw7uOMpWH6+Cc8hPXE+Bgn78C7X9QBZ5gvPwNTiOyPtt7C1LcO/5YBX3f09UvpSqHOQl2Xa/Pbpemf6Vyh02DjSJsDsVNktU8dE+0NjmWXXPI8/HczT2e5tHPD64lYTKYxQEQVXeTcE/SqLCqxF9DuxOAaLccTffdLbbnQXQ2Yc9hFTDIiMi0c1b0KRT+L91XiWQmR9RIMQ2qmUeW4Xox2hM/FKEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=daKvlSztN9gWUbn4hEBeWRkhRvb2mM4oTQf//jh7i5A=; b=KYetsy1iWrN5Gp4eyslslUFfKEXONpLhBrpl+Slnc5QY3iG9x4DoyR9drylApI4fnBnEYPRH6uLM9Ows6P/L60eGxsq1xEEcD+CJMP2HziqiYqPC0DfDfJ7UsJz1xHxeEbvxP8OmBrMiITIdQV/ED4ybUzOk+h1rMcEtTgPesM+RyBgLs/75yvwr8TNHlffrrIODxE+PAo841pdtiWU8QiWGWw9fib2gN6n0iKRHrlTmMBcd+AgzauJVK8T2C2DMyYXBfri04kfDDqjgJVSxK2HNIvVAPA+dy50qSJPO40TZoCcGx4+YfK9GfkNbibAjxtEgluzbXf2wp2+x7zIZeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=daKvlSztN9gWUbn4hEBeWRkhRvb2mM4oTQf//jh7i5A=; b=Rb9ITRjozfjAyk4erTmGPOGc/BlUqD/OwoAJH2bFsH9lpifjFtvMJFwMbmGEZOED0aG8pizICI2gt9lURE7axX7u2MYg/LrrybC/VKooW2auqRCwKzJeE5FXPOT/uwD6/7KpA1fDuIxtDK4Yp3lfaBkRIE3BsfbAw6YiVaf1D1k= Received: from SL2PR03MB4204.apcprd03.prod.outlook.com (2603:1096:100:53::15) by TYZPR03MB5391.apcprd03.prod.outlook.com (2603:1096:400:38::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.35; Wed, 30 Aug 2023 02:36:38 +0000 Received: from SL2PR03MB4204.apcprd03.prod.outlook.com ([fe80::b6ae:482a:3913:2a8b]) by SL2PR03MB4204.apcprd03.prod.outlook.com ([fe80::b6ae:482a:3913:2a8b%7]) with mapi id 15.20.6699.035; Wed, 30 Aug 2023 02:36:38 +0000 From: =?utf-8?B?VGluZ0hhbiBTaGVuICjmsojlu7fnv7Ap?= To: "mathieu.poirier@linaro.org" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-remoteproc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "conor+dt@kernel.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "andersson@kernel.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v16 08/14] remoteproc: mediatek: Probe SCP cluster on multi-core SCP Thread-Topic: [PATCH v16 08/14] remoteproc: mediatek: Probe SCP cluster on multi-core SCP Thread-Index: AQHZwPzfA0+mOQOixkOGHD+Ys/vp1rAAMNyAgAIiwQA= Date: Wed, 30 Aug 2023 02:36:37 +0000 Message-ID: <060bd5a5de40c5a6feda867959bedf8cf78007d8.camel@mediatek.com> References: <20230728023959.12293-1-tinghan.shen@mediatek.com> <20230728023959.12293-9-tinghan.shen@mediatek.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SL2PR03MB4204:EE_|TYZPR03MB5391:EE_ x-ms-office365-filtering-correlation-id: 9e16b55b-2f2a-4b1d-587d-08dba901ef6d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7BIwCAeLoOz99AZ3E7G+2TkFzPpJbdIt3+whhWn9n9aZjHeecA4dqVjF71rEhQ8zf4ROejVfg9V4k/LiDOg3SjOhqqzQI3UaAuoma3/3EQOiu3+zDgOqQpG3pEED1DFieQogUWvHgDUwbDX0eL+PoCb/Je0c4bucU8piSZjs1Jio2SISn5Oh3kZblAQN01S44IpQ9RJMbgV6RrwPfGtb7wqh3n77/hff500TQBP2weSvuYHEiLknPPaWNDAl7PgXAnA4pO1FU55KUb7mg2H5M5PFFY0PRryCrHs44mBidUA1qJMVo3RqvtiNLut16c3rV7cdFalZBQPKcF0qbxzmqg5K/BXVwKEAK3YHQ11g22YmzXLX8dkqm8/NgFsPRqvAdjf2fZB/Ojp8WWfDoJrLLo/SmbkOKTEbiBbNmI4/hvH3dZVAvy9d6A/LFrpgZd47wMbmi+c30nJwhgW7tsGPNkwmI3NeIGvtd0Rz08VUauEzropcKx6fOeVBMm3JPsZ2In8q1i3I0hxLttHjZrhWASc+qB4Br0/kg8zge2XO1LIHg9EEVrqt1ZKdu5/ZXEwsl6EwMqckon8StM/QFhaa0B8JqOHSnuQQfRBYVt9ikXexoDHuVdV+Rsuj9sOruYjk3bDOpzB34zP2b28hc3+bAXpYc3tHS0epdofYQOyeBaTB5QnYsLobkGboHX5A/9IqqUVEb/iI6kAj5vBnUz/PqA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR03MB4204.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(366004)(396003)(346002)(376002)(39860400002)(451199024)(1800799009)(186009)(8936002)(6486002)(6506007)(71200400001)(6512007)(478600001)(83380400001)(76116006)(26005)(91956017)(7416002)(66446008)(2616005)(64756008)(6916009)(316002)(54906003)(66946007)(8676002)(66556008)(4326008)(5660300002)(41300700001)(66476007)(2906002)(85182001)(36756003)(86362001)(38100700002)(38070700005)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VzBXQ0tiYmM2V2VlUFhVdEdxZ04xcTZHN0huM08xUzNjUnRpVm5NQWIzdFhI?= =?utf-8?B?S3QzeUMyM3RtVjlGdG5UK0x5KzIvQTJjaW4vZEhnUDZYZ3ZrOVY5QWsxVnNV?= =?utf-8?B?T0pETWJVcGhaeC9peWhVR3J1OWlJeDhWc0RhZExOaVE0OUFucjVlb1FTaytH?= =?utf-8?B?emlabThwL1ZMa0Q4eUlPZlU1cXJ1NGFtcUNjWjBxdUtVbTl5RGo3MW9RRmJ6?= =?utf-8?B?cFFteTVQak1FQ21ldTIxaDNIaFFHUnZiVEQ4TnJhRFRDVkZXRVBZN1JpVGFr?= =?utf-8?B?a1dISmx0cVIzVnNJaFBETzlJd0x3dzFVQS9Rek5GS09USjhvMnZrbXRWSW10?= =?utf-8?B?STJOaUI5TWJBMWZ2dDE4a2U5OXpQQVR4VHdsd0FaUE5ZMUd0TS9Fb1FRMVNX?= =?utf-8?B?enpmaGk4Z3hpQk15OCtFY21ESURORzNVV1pBa3VYTlQxUHN5UjM3K2hINUFT?= =?utf-8?B?R3AxL1hyMngxdjJBSjhaSkRDUmk2MUhmdUd6NGR5MnNVQ2EvWFkxR3NPUDlT?= =?utf-8?B?bFpGTHAzQ09iKzY3QktWa0ZSYS9DQk5wS1VTanljVURjRlUxTmNoVTlrZlRO?= =?utf-8?B?V2w5RkxjOVJUc2VqbDFRWnV3UVJBNG1KMXNIUE5VYWdGZTduTjkvcWxQVE9Z?= =?utf-8?B?MDVJSWlTbWQ2VzRkNXpyRktPK1NYVHJpZmNCeE9LMTRrWnEzQ3lYYVZHdjAr?= =?utf-8?B?VkpZRDZ2OURzRHdraXowdlM5aXRCYXVxTGZUSlVOZmszQjBBektZc2NwVGIz?= =?utf-8?B?Q3crVFk5cHR6UmFRK0JqeTFreE54ZnNMOVI0clpGQ0NmZ2laODA3TzNCSng2?= =?utf-8?B?blM4NXErdnlXdVRXNDNoMnozMUFLUVhBZmg3bjhrVXgyczM3dW00ZXdoazkx?= =?utf-8?B?N3NwVy9YK1VIcVdoT2JLbjNIOS9QVCtZOGRyN01FK1UwbUdNdmVVa2FmSGh2?= =?utf-8?B?bTUxWDFlVmdNbVNiMVpaR0ljc2x2MU9hTzYrOUxWc2xXWG40V2RsKzBiWHBC?= =?utf-8?B?M0lobUtpVXo5OGpWTlFSZWI1ZEU2eG4yZHRqVjlhVUNocXNBUjBwcmRPWndS?= =?utf-8?B?RVZLckg3RGdCUXY2QVc1VnltNS9lUWpZMWNBWmk3NmJxZGJOcjRpaVFnY1Js?= =?utf-8?B?K2xjbWVYM09xWDdscDZKUXNEZVFRb0kzdTd2MHUweEtLUDFydWZWeHovYXh3?= =?utf-8?B?cmRIbURLTHNQdHovY3cwU1F4SlN3U1drd1NldkJMR2w2N05IUFJCaElzSEVU?= =?utf-8?B?V1lLMkd2cUNVM0cwMU16cm9lR0NDTVQzdUFwU0ZCWC9wNDJwM2VHdTBhM2wz?= =?utf-8?B?cUlwVkhUWmpWL1VYNjc1VnA5UlhpaTJBSFZSem9sZS9HSU1IV0pUQy81Z1pT?= =?utf-8?B?WmFmVlQwRytOTHdrVGVFdldiUGNZVzZSamovdnE5dzRBSW91bWxGV1FVaVZo?= =?utf-8?B?d0MzaC8rdytUZFpBRi90ak4zRFVka3YwaUkzb0NjRGtnVmFiaUZ1SE1IN2Vk?= =?utf-8?B?eFE2bjB5ZFpJRjNzWW03N0paRjlKUWtHM2V3c1Ixa1hNOTVpc1crT1BDRU1l?= =?utf-8?B?aDk4ZWhudGNkQmpYZkFoZ3dKN3pMYkRyQ0lPTHAvZjJsSHIvd2ptUmpJcHl1?= =?utf-8?B?ckVjVERwZXRBKzlqbUJWQUtMTDBPMTA0ZmxNUEFOZ1RtMjlHbGZDbHlyZnA0?= =?utf-8?B?VVY0TXhjNGMvKytvU2duOUZZd0RzM0lSNUJWT2lVN08vcTYvV2wxdDBDR1Yx?= =?utf-8?B?WWJraXNweGZoN0ZuQk5YTWFoVVFuYmVhaGwzbXNHTVJERnhPeVpIbmlnUGN0?= =?utf-8?B?dHpEVWxzR1lJcHpmRDAxbHRYVG4yTUgzVTg4dm9YdXhkUGZvdWlib1V4a21K?= =?utf-8?B?V2J4SjJvbkU4VkZ3eTZTalZBQ3k4VkdPOCs0UkdUS3pnNFM5cnVyaGJvSnBQ?= =?utf-8?B?TTI1aWRuMEo0YVVsSytwV0hZUHpENWtlRXBGMmNKSkVnWDFYL1Q4UC9PU2Jq?= =?utf-8?B?M243a3dpUy9zVHM0SXBSV1ArTGdMLzQzUjlWTFo4REc3SzZEd0k5ck02V2JN?= =?utf-8?B?bm1KZXZGQk1FbUdNcmlvWmRGK3MxeU8xbEF6cTZSbzhQckZrN2draVhSRFVo?= =?utf-8?B?b0JWWUhoaVFjY2ZPVnprWWNhblFtbW1TT2s3ekpxdStHekRZd05LalBuMXAx?= =?utf-8?B?bFE9PQ==?= Content-ID: <9E4E5A9A5526AF48B4C25D6A967FB9EE@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SL2PR03MB4204.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e16b55b-2f2a-4b1d-587d-08dba901ef6d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2023 02:36:37.9495 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FMWGoJbjKR9CsMCZE2KpNSnPrJatzD5ezjdcdmbmepiln5lBgHb6sLZqpQz8g1tIPcL4qMSXu++wOkitW8Ap4mcULKbWB6JMaQchqoD5EvA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB5391 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_193730_340794_B48B7E0D X-CRM114-Status: GOOD ( 24.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On Mon, 2023-08-28 at 11:59 -0600, Mathieu Poirier wrote: > Hi Tinghan, > > On Fri, Jul 28, 2023 at 10:39:53AM +0800, Tinghan Shen wrote: > > The difference of single-core SCP and multi-core SCP device tree is > > the presence of child device nodes described SCP cores. The SCP > > driver populates the platform device and checks the child nodes > > to identify whether it's a single-core SCP or a multi-core SCP. > > > > Add the remoteproc instances of multi-core SCP to the SCP cluster list. > > When the SCP driver is removed, it cleanup resources by walking > > through the cluster list. > > > > Signed-off-by: Tinghan Shen > > Reviewed-by: AngeloGioacchino Del Regno > > --- > > drivers/remoteproc/mtk_scp.c | 118 +++++++++++++++++++++++++++++++++-- > > 1 file changed, 113 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > > index d67dcabdab9e..d9242c3eb0d7 100644 > > --- a/drivers/remoteproc/mtk_scp.c > > +++ b/drivers/remoteproc/mtk_scp.c > > @@ -855,7 +855,8 @@ static void scp_remove_rpmsg_subdev(struct mtk_scp *scp) > > } > > > > static struct mtk_scp *scp_rproc_init(struct platform_device *pdev, > > - struct mtk_scp_of_cluster *scp_cluster) > > + struct mtk_scp_of_cluster *scp_cluster, > > + const struct mtk_scp_of_data *of_data) > > { > > struct device *dev = &pdev->dev; > > struct device_node *np = dev->of_node; > > @@ -878,7 +879,7 @@ static struct mtk_scp *scp_rproc_init(struct platform_device *pdev, > > scp = rproc->priv; > > scp->rproc = rproc; > > scp->dev = dev; > > - scp->data = of_device_get_match_data(dev); > > + scp->data = of_data; > > scp->cluster = scp_cluster; > > platform_set_drvdata(pdev, scp); > > > > @@ -951,15 +952,15 @@ static void scp_free(struct mtk_scp *scp) > > mutex_destroy(&scp->send_lock); > > } > > > > -static int scp_cluster_init(struct platform_device *pdev, > > - struct mtk_scp_of_cluster *scp_cluster) > > +static int scp_add_single_core(struct platform_device *pdev, > > + struct mtk_scp_of_cluster *scp_cluster) > > { > > struct device *dev = &pdev->dev; > > struct list_head *scp_list = &scp_cluster->mtk_scp_list; > > struct mtk_scp *scp; > > int ret; > > > > - scp = scp_rproc_init(pdev, scp_cluster); > > + scp = scp_rproc_init(pdev, scp_cluster, of_device_get_match_data(dev)); > > if (IS_ERR(scp)) > > return PTR_ERR(scp); > > > > @@ -975,6 +976,102 @@ static int scp_cluster_init(struct platform_device *pdev, > > return 0; > > } > > > > +static int scp_add_multi_core(struct platform_device *pdev, > > + struct mtk_scp_of_cluster *scp_cluster) > > +{ > > + struct device *dev = &pdev->dev; > > + struct device_node *np = dev_of_node(dev); > > + struct platform_device *cpdev; > > + struct device_node *child; > > + struct list_head *scp_list = &scp_cluster->mtk_scp_list; > > + const struct mtk_scp_of_data **cluster_of_data; > > + struct mtk_scp *scp, *temp; > > + int core_id = 0; > > + int ret; > > + > > + cluster_of_data = (const struct mtk_scp_of_data **)of_device_get_match_data(dev); > > + > > + for_each_available_child_of_node(np, child) { > > + if (!cluster_of_data[core_id]) { > > + ret = -EINVAL; > > + dev_err(dev, "Not support core %d\n", core_id); > > + of_node_put(child); > > + goto init_fail; > > + } > > + > > + cpdev = of_find_device_by_node(child); > > + if (!cpdev) { > > + ret = -ENODEV; > > + dev_err(dev, "Not found platform device for core %d\n", core_id); > > + of_node_put(child); > > + goto init_fail; > > + } > > + > > + scp = scp_rproc_init(cpdev, scp_cluster, cluster_of_data[core_id]); > > + put_device(&cpdev->dev); > > + if (IS_ERR(scp)) { > > + ret = PTR_ERR(scp); > > + dev_err(dev, "Failed to initialize core %d rproc\n", core_id); > > + of_node_put(child); > > + goto init_fail; > > + } > > + > > + ret = rproc_add(scp->rproc); > > + if (ret) { > > + dev_err(dev, "Failed to add rproc of core %d\n", core_id); > > + of_node_put(child); > > + scp_free(scp); > > + goto init_fail; > > + } > > + > > + list_add_tail(&scp->elem, scp_list); > > + core_id++; > > + } > > + > > + platform_set_drvdata(pdev, scp); > > + > > Here we are setting the platform device for @pdev to the last @scp that was > created, which is needed because (1) scp_rproc_init() is calling > platform_set_drvdata() on the child platform devices and (2) we need a handle to > the cluster list in scp_remove(). > > Please add a comment with the above just before calling platform_set_drvdata(). > Otherwise it will be very difficult for people not familiar with the driver to > understand what is going on. > > Otherwise I think we are done. > > Thanks, > Mathieu Ok, I'll add the comment at next version. I would like to express my sincere gratitude for your review comments to make this series better. I truly appreciate the time and effort you have dedicated to providing feedback. Thank you so much. Best regards, TingHan > > > + return 0; > > + > > +init_fail: > > + list_for_each_entry_safe_reverse(scp, temp, scp_list, elem) { > > + list_del(&scp->elem); > > + rproc_del(scp->rproc); > > + scp_free(scp); > > + } > > + > > + return ret; > > +} > > + > > +static int scp_is_single_core(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct device_node *np = dev_of_node(dev); > > + struct device_node *child; > > + > > + child = of_get_next_available_child(np, NULL); > > + if (!child) > > + return dev_err_probe(dev, -ENODEV, "No child node\n"); > > + > > + of_node_put(child); > > + return of_node_name_eq(child, "cros-ec-rpmsg"); > > +} > > + > > +static int scp_cluster_init(struct platform_device *pdev, struct mtk_scp_of_cluster *scp_cluster) > > +{ > > + int ret; > > + > > + ret = scp_is_single_core(pdev); > > + if (ret < 0) > > + return ret; > > + > > + if (ret) > > + ret = scp_add_single_core(pdev, scp_cluster); > > + else > > + ret = scp_add_multi_core(pdev, scp_cluster); > > + > > + return ret; > > +} > > + > > static int scp_probe(struct platform_device *pdev) > > { > > struct device *dev = &pdev->dev; > > @@ -1007,6 +1104,10 @@ static int scp_probe(struct platform_device *pdev) > > > > INIT_LIST_HEAD(&scp_cluster->mtk_scp_list); > > > > + ret = devm_of_platform_populate(dev); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to populate platform devices\n"); > > + > > ret = scp_cluster_init(pdev, scp_cluster); > > if (ret) > > return ret; > > @@ -1101,12 +1202,19 @@ static const struct mtk_scp_of_data mt8195_of_data_c1 = { > > .host_to_scp_int_bit = MT8195_CORE1_HOST_IPC_INT_BIT, > > }; > > > > +static const struct mtk_scp_of_data *mt8195_of_data_cores[] = { > > + &mt8195_of_data, > > + &mt8195_of_data_c1, > > + NULL > > +}; > > + > > static const struct of_device_id mtk_scp_of_match[] = { > > { .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data }, > > { .compatible = "mediatek,mt8186-scp", .data = &mt8186_of_data }, > > { .compatible = "mediatek,mt8188-scp", .data = &mt8188_of_data }, > > { .compatible = "mediatek,mt8192-scp", .data = &mt8192_of_data }, > > { .compatible = "mediatek,mt8195-scp", .data = &mt8195_of_data }, > > + { .compatible = "mediatek,mt8195-scp-dual", .data = &mt8195_of_data_cores }, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, mtk_scp_of_match); > > -- > > 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel