From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20CA9C432C1 for ; Tue, 24 Sep 2019 14:20:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E72F4214DA for ; Tue, 24 Sep 2019 14:20:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="do9mQS18"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S5hzl7zj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E72F4214DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f7KOzD/DdEC5mb5uVXJAtmHOZX8ZngLjPxukaRBxgyg=; b=do9mQS1809nr62 bxoetKiVzNU3LCzOgY3TVb5UIlWX3hjj5+qD8ADjeXoV1kF7jPTNHqemmZyiagwBlGK2iB7+Q46Ys mith8Yd4qOlRtv4uHGD9uYMRIqswXauNuXaewKII/Yz484caePJPU2Sf3i0UgSMLZ1NZ79d3SAwJt a6qHiJj21/X6//HL21XyGuZVw9HbeZomDpcq8uWlst5i+kSkxJw5eJMkdwBMjv7FJq6L76IT0gPK8 HQ0oB4YJ/4WgQq1Z93ZayaiBGxunuGTOU554hoTbKP+z6lO+FCxJ1Z3sannbc7NCeRNO5JAR++T4p fvgkpGDF32sq+Dj8LhDQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iClg2-0005Rq-GN; Tue, 24 Sep 2019 14:20:26 +0000 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iClfy-0005QK-Aw for linux-arm-kernel@lists.infradead.org; Tue, 24 Sep 2019 14:20:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1569334820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L4qybsnzerq1m1MESjNMamZC3PQ0Zg5C9AXa25MzaeU=; b=S5hzl7zjPCC4xdxYATZsJFUeD5SwePMdNYoYSZ4DWF8ZQjpDShr8tbUBHs1przxCZKDJG/ 66cbqpUbE9CqRlYpqZ2rid1SeDwxyAYITH9tUQ+XjsyCjw/rHqAvtkyFL3J76JvVaOrGiq 9653Eu+f+Pn18ZqIIi5JGer7yQOK/d4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-uOio7rzjOGeB8BRAOgKvPw-1; Tue, 24 Sep 2019 10:20:18 -0400 Received: by mail-wm1-f71.google.com with SMTP id 190so94211wme.4 for ; Tue, 24 Sep 2019 07:20:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sEyk6USuWuluG4dEpZivpllBkGUrYY+s2EB287d40EY=; b=gLypt/shV8bHuKpJAH2c2CLD+GGwrJrRdwzq1iodRCRapGwv9rEZsjpmOZomVfgbB7 aJL8NNSyOBwudyG6OYO80vRsfs2xmBtCh0AZ4tO1HJ9rlveqv2VO8pMZzgUw+jJcw/Ui pebahYqdjQZzhtrl7qFfkDMdop/7easE3RSkuk3MEiSy1iwb52/btnpsUEqMqxIA4VzY TJF8IGLoKARNTi7gxcm5DKdaFFySGXOA/tZ+RC1HIitPw3MwjBqzcDlZJJYXQ/q/DdMN D182qhTKh7cxCf8UK3UF/IZNPNN/3DGQSyNqpsBnVDMWYIO5WPxSu1jNqD5ANf8Ivres 2h2Q== X-Gm-Message-State: APjAAAXLABn8xkA6VqTw54cqSTyUiUvyuhb/ZXIf4ii4frDXrpsF1z2P NVkoutDYj3/jWc+3PObcE06yTh4uBvT0E3zKindzt+4V/DpNq0LDJRhqOSqkdHRVhe2PHQATFg5 eIqEvK0hIzFdSXNsX3g2WgSE0VitSjVDtJ+A= X-Received: by 2002:a5d:69c7:: with SMTP id s7mr2469145wrw.295.1569334817102; Tue, 24 Sep 2019 07:20:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqx4LF7gV2lQhhn+yrMAt/0oOF5J6XmW/oOSZQJqYKd8ZZoV90deJE9Ub18ZwCF1a3Rr5w2N/g== X-Received: by 2002:a5d:69c7:: with SMTP id s7mr2469108wrw.295.1569334816822; Tue, 24 Sep 2019 07:20:16 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:9520:22e6:6416:5c36? ([2001:b07:6468:f312:9520:22e6:6416:5c36]) by smtp.gmail.com with ESMTPSA id h125sm183749wmf.31.2019.09.24.07.20.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2019 07:20:15 -0700 (PDT) Subject: Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm. To: "Jianyong Wu (Arm Technology China)" , "netdev@vger.kernel.org" , "yangbo.lu@nxp.com" , "john.stultz@linaro.org" , "tglx@linutronix.de" , "sean.j.christopherson@intel.com" , "maz@kernel.org" , "richardcochran@gmail.com" , Mark Rutland , Will Deacon , Suzuki Poulose References: <20190918080716.64242-1-jianyong.wu@arm.com> <20190918080716.64242-5-jianyong.wu@arm.com> <83ed7fac-277f-a31e-af37-8ec134f39d26@redhat.com> <629538ea-13fb-e666-8df6-8ad23f114755@redhat.com> From: Paolo Bonzini Message-ID: <06264d8a-b9c0-5f19-db2c-6190976a2a05@redhat.com> Date: Tue, 24 Sep 2019 16:20:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-MC-Unique: uOio7rzjOGeB8BRAOgKvPw-1 X-Mimecast-Spam-Score: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190924_072022_450306_98F09442 X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Justin He \(Arm Technology China\)" , "kvm@vger.kernel.org" , Steve Capper , "linux-kernel@vger.kernel.org" , "Kaly Xin \(Arm Technology China\)" , nd , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/09/19 06:57, Jianyong Wu (Arm Technology China) wrote: >> On 19/09/19 11:46, Jianyong Wu (Arm Technology China) wrote: >>>> On 18/09/19 11:57, Jianyong Wu (Arm Technology China) wrote: >>>>> Paolo Bonzini wrote: >>>>>> This is not Y2038-safe. Please use ktime_get_real_ts64 instead, >>>>>> and split the 64-bit seconds value between val[0] and val[1]. >>> >>> Val[] should be long not u32 I think, so in arm64 I can avoid that >>> Y2038_safe, but also need rewrite for arm32. >> >> I don't think there's anything inherently wrong with u32 val[], and as you >> notice it lets you reuse code between arm and arm64. It's up to you and >> Marc to decide. >> > To compatible 32-bit, Integrates second value and nanosecond value as a nanosecond value then split it into val[0] and val[1] and split cycle value into val[2] and val[3], > In this way, time will overflow at Y2262. > WDYT? So if I understand correctly you'd multiply by 10^9 (or better shift by 30) the nanoseconds. That works, but why not provide 5 output registers? Alternatively, take an address as input and write there. Finally, on x86 we added an argument for the CLOCK_* that is being read (currently only CLOCK_REALTIME, but having room for extensibility in the API is always nice). Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel