public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 09/10] ARM: S5PC100: Modify platform data for pl330 driver
Date: Wed, 12 Oct 2011 13:52:12 +0900	[thread overview]
Message-ID: <063501cc889a$b52eb520$1f8c1f60$%kim@samsung.com> (raw)
In-Reply-To: <CAJuYYwSj4D1bMbUtaPe=33GrS=e1_7+POHRWCb8Yzgpv8_Muzg@mail.gmail.com>

Thomas Abraham wrote:
> 
> Hi Anca,
> 
> On 12 October 2011 09:41, Anca Emanuel <anca.emanuel@gmail.com> wrote:
> > On Mon, Oct 10, 2011 at 9:15 PM, Thomas Abraham
> > <thomas.abraham@linaro.org> wrote:
> > <spnip>
> >
> >> +u8 pdma1_peri[] = {
> >> + ? ? ? DMACH_UART0_RX,
> >> + ? ? ? DMACH_UART0_TX,
> >> + ? ? ? DMACH_UART1_RX,
> >> + ? ? ? DMACH_UART1_TX,
> >> + ? ? ? DMACH_UART2_RX,
> >> + ? ? ? DMACH_UART2_TX,
> >> + ? ? ? DMACH_UART3_RX,
> >> + ? ? ? DMACH_UART3_TX,
> >> + ? ? ? DMACH_IRDA,
> >> + ? ? ? DMACH_I2S0_RX,
> >> + ? ? ? DMACH_I2S0_TX,
> >> + ? ? ? DMACH_I2S0S_TX,
> >> + ? ? ? DMACH_I2S1_RX,
> >> + ? ? ? DMACH_I2S1_TX,
> >> + ? ? ? DMACH_I2S2_RX,
> >> + ? ? ? DMACH_I2S2_TX,
> >> + ? ? ? DMACH_SPI0_RX,
> >> + ? ? ? DMACH_SPI0_TX,
> >> + ? ? ? DMACH_SPI1_RX,
> >> + ? ? ? DMACH_SPI1_TX,
> >> + ? ? ? DMACH_SPI2_RX,
> >> + ? ? ? DMACH_SPI2_TX,
> >> + ? ? ? DMACH_PCM0_RX,
> >> + ? ? ? DMACH_PCM1_TX,
> >
> > typo ? ?DMACH_PCM0_TX
> 
> Yes. That is a mistake. I cross-checked others with the user manual
> and they are fine.
> 

OK, I think you don't need to re-send because I can fix it when I apply.
It would be helpful to me if you could check your patches again :)

If any problems, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


> Thanks for pointing this out.
> 
> >
> >> + ? ? ? DMACH_PCM1_RX,
> >> + ? ? ? DMACH_PCM1_TX,
> >> + ? ? ? DMACH_MSM_REQ0,
> >> + ? ? ? DMACH_MSM_REQ1,
> >> + ? ? ? DMACH_MSM_REQ2,
> >> + ? ? ? DMACH_MSM_REQ3,
> >> ?};
> >

  reply	other threads:[~2011-10-12  4:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-10 18:15 [PATCH v6 00/10] Add device tree support for PL330 dma controller driver Thomas Abraham
2011-10-10 18:15 ` [PATCH v6 01/10] DMA: PL330: move filter function into driver Thomas Abraham
2011-10-10 18:15   ` [PATCH v6 02/10] DMA: PL330: Infer transfer direction from transfer request instead of platform data Thomas Abraham
2011-10-10 18:15     ` [PATCH v6 03/10] ARM: EXYNOS4: Modify platform data for pl330 driver Thomas Abraham
2011-10-10 18:15       ` [PATCH v6 04/10] DMA: PL330: Add device tree support Thomas Abraham
2011-10-10 18:15         ` [PATCH v6 05/10] ARM: SAMSUNG: Add device tree support for pl330 dma engine wrappers Thomas Abraham
2011-10-10 18:15           ` [PATCH v6 06/10] ARM: EXYNOS4: Limit usage of pl330 device instance to non-dt build Thomas Abraham
2011-10-10 18:15             ` [PATCH v6 07/10] ARM: Exynos4: Add a alias for pdma clocks Thomas Abraham
2011-10-10 18:15               ` [PATCH v6 08/10] ARM: S5P64x0: Modify platform data for pl330 driver Thomas Abraham
2011-10-10 18:15                 ` [PATCH v6 09/10] ARM: S5PC100: " Thomas Abraham
2011-10-10 18:15                   ` [PATCH v6 10/10] ARM: S5PV210: " Thomas Abraham
2011-10-12  3:59                     ` Boojin Kim
2011-10-12  3:58                   ` [PATCH v6 09/10] ARM: S5PC100: " Boojin Kim
2011-10-12  4:11                   ` Anca Emanuel
2011-10-12  4:34                     ` Thomas Abraham
2011-10-12  4:52                       ` Kukjin Kim [this message]
2011-10-12 11:51                   ` [PATCH v7 " Thomas Abraham
2011-10-12  4:04         ` [PATCH v6 04/10] DMA: PL330: Add device tree support Boojin Kim
2011-10-12  5:36       ` [PATCH v6 03/10] ARM: EXYNOS4: Modify platform data for pl330 driver Thomas Abraham
2011-10-12  8:08         ` Boojin Kim
2011-10-12  8:13           ` Thomas Abraham
2011-10-12 11:46       ` [PATCH v7 " Thomas Abraham
2011-10-12  4:01     ` [PATCH v6 02/10] DMA: PL330: Infer transfer direction from transfer request instead of platform data Boojin Kim
2011-10-11 12:06 ` [PATCH v6 00/10] Add device tree support for PL330 dma controller driver Kukjin Kim
2011-10-11 15:05   ` Thomas Abraham
2011-10-11 16:49   ` Vinod Koul
2011-10-12  5:03     ` Kukjin Kim
2011-10-12  5:20       ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='063501cc889a$b52eb520$1f8c1f60$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox