From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC
Date: Wed, 12 Oct 2011 14:16:45 +0900 [thread overview]
Message-ID: <063801cc889e$22a12c20$67e38460$%kim@samsung.com> (raw)
In-Reply-To: <4E944508.4050202@arm.com>
Marc Zyngier wrote:
>
> Hi Changwan,
>
> On 11/10/11 13:22, Changhwan Youn wrote:
> >> Kukjin, could you please comment on the presence of a common memory
> >> region for the distributor? This seem quite odd...
> >
> > Some registers in Distributor are banked for PPI and SGI support (banked
> interrupts).
> > The register for pending and enable status of these interrupts are
> > banked.
>
> Right, that explains it then.
>
> > Marc, I think the approach in your patch is much better than mine if it
doesn't hurt
> > the performance of other platforms which use the common gic code.
>
> It probably doesn't hurt the general case too much (I expect a bit more
> pressure on the d-cache because of the per-cpu stuff, but nothing to be
> too worried about).
>
> > I'll re-work the exynos4 interrupt code based on your patch though
> > I'm not sure that it's possible to be merged in merge window.
>
> My main concern at the moment is that mainline is broken as far as
> EXYNOS4 is concerned (there's a race with the EOI hook), so that should
> get fixed first.
>
Hi Marc,
OK. I agree with Will and your opinions and I think Changhwan can fix it as
per your suggestion, but he needs fixed/updated regarding gic codes to avoid
re-work and conflicts with others. So it would be better to us if he could
fix it after merging your patches even probably at the end of upcoming merge
window. I hope he can do it before v3.2-rc1.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2011-10-12 5:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 7:34 [PATCH 0/7] ARM: EXYNOS4: Adds External GIC Changhwan Youn
2011-06-20 7:34 ` [PATCH 1/7] ARM: EXYNOS4: Add external GIC io memory mapping Changhwan Youn
2011-06-30 5:14 ` MyungJoo Ham
2011-06-30 6:54 ` MyungJoo Ham
2011-07-04 10:25 ` Kukjin Kim
2011-06-20 7:34 ` [PATCH 2/7] ARM: EXYNOS4: modify interrupt mappings for external GIC Changhwan Youn
2011-06-20 7:34 ` [PATCH 3/7] ARM: EXYNOS4: set the affinity of mct1 interrupt using IRQ_MCT_L1 Changhwan Youn
2011-06-20 7:34 ` [PATCH 4/7] ARM: GIC: move gic_chip_data structure declaration to header Changhwan Youn
2011-07-04 9:38 ` Kukjin Kim
2011-06-20 7:34 ` [PATCH 5/7] ARM: EXYNOS4: Add support external GIC Changhwan Youn
2011-10-05 13:55 ` Marc Zyngier
2011-10-06 6:30 ` Kukjin Kim
2011-10-06 8:18 ` Marc Zyngier
2011-10-07 9:44 ` Marc Zyngier
2011-10-07 10:54 ` Kukjin Kim
2011-10-07 15:16 ` Will Deacon
2011-10-10 13:02 ` Marc Zyngier
2011-10-11 12:22 ` Changhwan Youn
2011-10-11 13:30 ` Marc Zyngier
2011-10-12 5:16 ` Kukjin Kim [this message]
2011-11-02 11:15 ` Marc Zyngier
2011-11-02 11:29 ` Kukjin Kim
2011-10-13 11:09 ` Russell King - ARM Linux
2011-10-13 17:51 ` Will Deacon
2011-06-20 7:34 ` [PATCH 6/7] ARM: EXYNOS4: Remove clock event timers using ARM private timers Changhwan Youn
2011-06-20 7:34 ` [PATCH 7/7] ARM: EXYNOS4: Add chained enrty/exit function to uart interrupt handler Changhwan Youn
2011-06-21 0:01 ` [PATCH 0/7] ARM: EXYNOS4: Adds External GIC Kyungmin Park
2011-07-16 6:55 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='063801cc889e$22a12c20$67e38460$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).