From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A90F3C30658 for ; Fri, 5 Jul 2024 03:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s5fIlGKLbmHYDo0tO1/ZM35cd+CYT9rRts//EQ2h1qw=; b=Q+b0me50O74PF+vaQopxF1Dj9T 9YcZtLz+gIMsAhnTE2xriiGhz6eQ+oeDmVPT5K+Cs70CsC8SUii7EGKTrska4fA04EgBaJjmNnfDg V2bIQ7x8PSI4b9yAakLRd38RpiJAposoYuCgNm/g2Uk7v9w0fqlr8ZBY/+pr2RsnayMlSxGTzjYZv rqS3gkn+cSlgIUXJOYHG5YgvjO2CP+zF3mZD/GieI6OWUUcdWO8dupcGZef4GnLFActfqfu5RYj60 MEXoHSdpboWrDbEO3PxYSCSLP16WgQ84fYmW2V3jxhxHWPF6MB+14/gmW2xlfQZztw8sZMf41V1bF KFHzoUOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPZuY-0000000Eqhb-1lqP; Fri, 05 Jul 2024 03:47:02 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPZuH-0000000EqgR-3IIC for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2024 03:46:47 +0000 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4650gRHb019873; Fri, 5 Jul 2024 03:46:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= s5fIlGKLbmHYDo0tO1/ZM35cd+CYT9rRts//EQ2h1qw=; b=aVvjLct+I8/KUsC4 CZncgxHL8/Cd0lg/2WyAwKbH4XuHty198cTV9C9JeKVrAmauYMNdYdmJoSNSYZ9o UeEabu4aZqneickg5ZRkBgQR8ZYtG4KbCpKnuJCRkzcnSUwHodzgj0vSNwKKxT0B jGQj5pIq8+wBtWMu+RkeeBhdeW91pyEJ5MR0xelv9TxrwVSWJE2AqnDb3c877duA mS9uW1hj1gg55thSrlnW4WaHoP9QsKWrxrQ3LJcJltuOm3VnAtgToy8GDbYa3m5g E9aGyDjJAKMR2rmZeA8Ef84ERnQqkhCqnfUPT4heDkDwC1WtSAQgT82TGMiigJVO Ua+0qQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4050cycxnw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 05 Jul 2024 03:46:37 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 4653kaMG019567 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 5 Jul 2024 03:46:36 GMT Received: from [10.131.33.37] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 4 Jul 2024 20:46:32 -0700 Message-ID: <064274c4-3783-c59e-e293-dd53a8595d8e@quicinc.com> Date: Fri, 5 Jul 2024 09:16:29 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] pmdomain: arm: Fix debugfs node creation failure Content-Language: en-US To: Sudeep Holla CC: , , , , , , , , , References: <20240703110741.2668800-1-quic_sibis@quicinc.com> From: Sibi Sankar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ARZJ0NLPV21P96IVhRlNQqO5XxVO7jnb X-Proofpoint-ORIG-GUID: ARZJ0NLPV21P96IVhRlNQqO5XxVO7jnb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-04_21,2024-07-03_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 mlxlogscore=621 priorityscore=1501 adultscore=0 mlxscore=0 impostorscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407050026 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_204645_978560_86327D56 X-CRM114-Status: GOOD ( 20.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/4/24 16:02, Sudeep Holla wrote: > On Wed, Jul 03, 2024 at 04:37:41PM +0530, Sibi Sankar wrote: >> The domain attributes returned by the perf protocol can end up >> reporting identical names across domains, resulting in debugfs >> node creation failure. Fix this duplication by appending the >> domain-id to the domain name. Hey Sudeep, Thanks for taking time to review the patch :) >> >> Logs: >> debugfs: Directory 'NCC' with parent 'pm_genpd' already present! >> debugfs: Directory 'NCC' with parent 'pm_genpd' already present! >> > > If there are 2 perf domains for a device or group of devices, there must > be something unique about each of these domains. Why can't the firmware > specify the uniqueness or the difference via the name? > > The example above seems firmware is being just lazy to update it. Also > for the user/developer/debugger, the unique name might be more useful > than just this number. > > So please use the name(we must now have extended name if 16bytes are less) > to provide unique names. Please stop working around such silly firmware > bugs like this, it just makes using debugfs for anything useful harder. This is just meant to address firmware that are already out in the wild. That being said I don't necessarily agree with the patch either since it's penalizing firmware that actually uses a proper name by appending something inherently less useful to it. Since, the using of an unique domain name isn't required by the spec, the need for it goes under the radar for vendors. Mandating it might be the right thing to do since the kernel seems inherently expect that. -Sibi > > -- > Regards, > Sudeep