From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 524FFEB64DB for ; Thu, 22 Jun 2023 08:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CAESuZzKGJF5FiFrlZ5lXfera8wpC98TbQYK+FHxZzg=; b=W8E7NGu71hGO7K OHpG+G1iRKGT5RPb0bFqg+B6iGaibef6wPSz3exAFqFxDOiQ6RU+5tT7EkqaSMYOAd+yWFLdnvmUC tFPotmATC/2ody7miw/W8ynmC+bc5DPaZ/tWlFgJ1XgIhRe6KqmRWyoklVmDb+tW8igEcQzoDOTHn EZ3czh6NyZw1GAMEz4ZRcErfmooGdsIbfQMCvsiDB/jnjEiiQYWyunIew1bW55cm8Uouq4p6+5xhX viPthAev0SHsECa9v7NeqFBGBfyYE96eC2EWmKnvYPZN6228S3rd8mm5w0iWcOLiuuTiItHDWConV AVrkHlZcVnLU+x0yUlQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCFWY-00HOOv-0p; Thu, 22 Jun 2023 08:18:38 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCFWS-00HOO5-1v for linux-arm-kernel@lists.infradead.org; Thu, 22 Jun 2023 08:18:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687421910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9165t1I/uhRF5KMhHJE8BVUjT2kznhbBzSsVByfD1j8=; b=b76e0IWlozi8Uceg3duJ/H0NciSSCvTgQt+glXQbFK2fHhMtfglOdQlcojoLUEnma+AzMG 4xANRTqOWQGL8Kp1EISbE84/6u8FYab9ZNhyg7MFAOqMn4iCeS+7TTCS//tTmwgYaq4h7F xLJahFCuFtq+RwepG+ciGSE7j1CepKE= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-P9yLoCJTNkiyDaeF-FIB9Q-1; Thu, 22 Jun 2023 04:18:28 -0400 X-MC-Unique: P9yLoCJTNkiyDaeF-FIB9Q-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-51a5c1e9fbdso480253a12.1 for ; Thu, 22 Jun 2023 01:18:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687421907; x=1690013907; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9165t1I/uhRF5KMhHJE8BVUjT2kznhbBzSsVByfD1j8=; b=fkHwbirQniSUXjby1gg8wzieY0+8DeQe+7uYe2/W5TWDkYPThZagUUaAGMuAi/IGHV harDkKvbbnT8CWevn1tRbQkMRfiQmOikfreAEH7hFnT7umkLEAwxmz207iaPW8cZc/hT F6S+m2/tMP/9q+BrtKeGZWuPonlcyiJiTBDGBs+uQ5mCCxhllVIz1alZ+RQ1Lkliy8Al LFuDFWmNBFVs/hq0YeMBDa8OgQicMb/wVHV8pr48VmXogcqJtIrUaogiKN3X2SBC+fQb jYOgoQ2K2hpJXpU+Hlq2BAb0E2ler0UP4/Hc001uwDfZafoHVY7K+Eoprfa9qBO05lGD Xmvw== X-Gm-Message-State: AC+VfDwEuMAmleekmClU73FqdMVWAJA1joV+uT7+yV0+oaFpSFLWBp7N ph0dkkRQjuUxbNPzUL5Zs0lUU4bPYHP9SqxMp/JAEelOz5a0DaJb+mwtfHuZDln8uQk9fMZH/HJ bERL4fjLrQlQtDMAvMQKIGkVK6eCVnbSr2cg= X-Received: by 2002:a05:6402:1d49:b0:51b:d59f:8518 with SMTP id dz9-20020a0564021d4900b0051bd59f8518mr5910649edb.16.1687421907436; Thu, 22 Jun 2023 01:18:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6g0HUfA5kMm9iiZnbdF5JVa1vaSBMAPniXZ2SxZ+md/CR90yZZSiif6KqMQdRlA4FZqjbJXg== X-Received: by 2002:a05:6402:1d49:b0:51b:d59f:8518 with SMTP id dz9-20020a0564021d4900b0051bd59f8518mr5910591edb.16.1687421907045; Thu, 22 Jun 2023 01:18:27 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id s6-20020a056402014600b0051bdf152295sm1639168edu.76.2023.06.22.01.18.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jun 2023 01:18:26 -0700 (PDT) Message-ID: <0652c9c8-27ee-0af9-9aa8-a2909142d405@redhat.com> Date: Thu, 22 Jun 2023 10:18:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH net-next 1/6] platform/x86: intel_pmc_core: Add IPC mailbox accessor function and add SoC register access To: Choong Yong Liang , Rajneesh Bhardwaj , David E Box , Mark Gross , Jose Abreu , Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?Q?Marek_Beh=c3=ban?= , Jean Delvare , Guenter Roeck , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Philipp Zabel , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Wong Vee Khee , Jon Hunter , Jesse Brandeburg , Revanth Kumar Uppala , Shenwei Wang , Andrey Konovalov , Jochen Henneberg Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, bpf@vger.kernel.org, Voon Wei Feng , Tee Min , Michael Sit Wei Hong , Lai Peter Jun Ann References: <20230622041905.629430-1-yong.liang.choong@linux.intel.com> <20230622041905.629430-2-yong.liang.choong@linux.intel.com> From: Hans de Goede In-Reply-To: <20230622041905.629430-2-yong.liang.choong@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230622_011832_793583_EEECEDC4 X-CRM114-Status: GOOD ( 35.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 6/22/23 06:19, Choong Yong Liang wrote: > From: "David E. Box" > > - Exports intel_pmc_core_ipc() for host access to the PMC IPC mailbox > - Add support to use IPC command allows host to access SoC registers > through PMC firmware that are otherwise inaccessible to the host due to > security policies. > > Signed-off-by: David E. Box > Signed-off-by: Chao Qin > Signed-off-by: Choong Yong Liang This seem to be 2 patches in 1: 1. Move core.h to include/linux/intel_pmc_core.h 2. The actual adding of IPC mailbox accessor function and add SoC register access I wonder if you really need to move the entire core.h ? IMHO it would be better to just add a new header with just the bits which you actually need to export the desired functionality. If you do believe that you really need to move core.h please split this into 2 separate patches and please place the header in a x86 specific place, e.g. : include/linux/platform_data/x86/ Also note that a somewhat big refactor, to add support for multiple PMCs for Meteor Lake is on its way to linux-next. Currently this is available in my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Please base a next version of this on this. There also is the question of how to merge this. Assuming this is ready for merging once 6.5-rc1 is out then I can merge this intel_pmc_core change into an immutable branch and send a pull-req to the net folks for this. Regards, Hans > --- > MAINTAINERS | 1 + > drivers/platform/x86/intel/pmc/adl.c | 2 +- > drivers/platform/x86/intel/pmc/cnp.c | 2 +- > drivers/platform/x86/intel/pmc/core.c | 63 ++++++++++++++++++- > drivers/platform/x86/intel/pmc/icl.c | 2 +- > drivers/platform/x86/intel/pmc/mtl.c | 2 +- > drivers/platform/x86/intel/pmc/spt.c | 2 +- > drivers/platform/x86/intel/pmc/tgl.c | 2 +- > .../core.h => include/linux/intel_pmc_core.h | 27 +++++++- > 9 files changed, 95 insertions(+), 8 deletions(-) > rename drivers/platform/x86/intel/pmc/core.h => include/linux/intel_pmc_core.h (95%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index cb14589d14ab..bdb08a79a5f8 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10581,6 +10581,7 @@ L: platform-driver-x86@vger.kernel.org > S: Maintained > F: Documentation/ABI/testing/sysfs-platform-intel-pmc > F: drivers/platform/x86/intel/pmc/ > +F: include/linux/intel_pmc_core* > > INTEL PMIC GPIO DRIVERS > M: Andy Shevchenko > diff --git a/drivers/platform/x86/intel/pmc/adl.c b/drivers/platform/x86/intel/pmc/adl.c > index 5cbd40979f2a..b6a376c536c0 100644 > --- a/drivers/platform/x86/intel/pmc/adl.c > +++ b/drivers/platform/x86/intel/pmc/adl.c > @@ -8,7 +8,7 @@ > * > */ > > -#include "core.h" > +#include > > /* Alder Lake: PGD PFET Enable Ack Status Register(s) bitmap */ > const struct pmc_bit_map adl_pfear_map[] = { > diff --git a/drivers/platform/x86/intel/pmc/cnp.c b/drivers/platform/x86/intel/pmc/cnp.c > index 7fb38815c4eb..504034cc5ec3 100644 > --- a/drivers/platform/x86/intel/pmc/cnp.c > +++ b/drivers/platform/x86/intel/pmc/cnp.c > @@ -8,7 +8,7 @@ > * > */ > > -#include "core.h" > +#include > > /* Cannon Lake: PGD PFET Enable Ack Status Register(s) bitmap */ > const struct pmc_bit_map cnp_pfear_map[] = { > diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c > index da6e7206d38b..0d60763c5144 100644 > --- a/drivers/platform/x86/intel/pmc/core.c > +++ b/drivers/platform/x86/intel/pmc/core.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -26,7 +27,9 @@ > #include > #include > > -#include "core.h" > +#define PMC_IPCS_PARAM_COUNT 7 > + > +static const struct x86_cpu_id *pmc_cpu_id; > > /* Maximum number of modes supported by platfoms that has low power mode capability */ > const char *pmc_lpm_modes[] = { > @@ -53,6 +56,63 @@ const struct pmc_bit_map msr_map[] = { > {} > }; > > +int intel_pmc_core_ipc(struct pmc_ipc_cmd *ipc_cmd, u32 *rbuf) > +{ > + struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL }; > + union acpi_object params[PMC_IPCS_PARAM_COUNT] = { > + {.type = ACPI_TYPE_INTEGER,}, > + {.type = ACPI_TYPE_INTEGER,}, > + {.type = ACPI_TYPE_INTEGER,}, > + {.type = ACPI_TYPE_INTEGER,}, > + {.type = ACPI_TYPE_INTEGER,}, > + {.type = ACPI_TYPE_INTEGER,}, > + {.type = ACPI_TYPE_INTEGER,}, > + }; > + struct acpi_object_list arg_list = { PMC_IPCS_PARAM_COUNT, params }; > + union acpi_object *obj; > + int status; > + > + if (!pmc_cpu_id || !ipc_cmd || !rbuf) > + return -EINVAL; > + > + /* > + * 0: IPC Command > + * 1: IPC Sub Command > + * 2: Size > + * 3-6: Write Buffer for offset > + */ > + params[0].integer.value = ipc_cmd->cmd; > + params[1].integer.value = ipc_cmd->sub_cmd; > + params[2].integer.value = ipc_cmd->size; > + params[3].integer.value = ipc_cmd->wbuf[0]; > + params[4].integer.value = ipc_cmd->wbuf[1]; > + params[5].integer.value = ipc_cmd->wbuf[2]; > + params[6].integer.value = ipc_cmd->wbuf[3]; > + > + status = acpi_evaluate_object(NULL, "\\IPCS", &arg_list, &buffer); > + if (ACPI_FAILURE(status)) > + return -ENODEV; > + > + obj = buffer.pointer; > + /* Check if the number of elements in package is 5 */ > + if (obj && obj->type == ACPI_TYPE_PACKAGE && obj->package.count == 5) { > + const union acpi_object *objs = obj->package.elements; > + > + if ((u8)objs[0].integer.value != 0) > + return -EINVAL; > + > + rbuf[0] = objs[1].integer.value; > + rbuf[1] = objs[2].integer.value; > + rbuf[2] = objs[3].integer.value; > + rbuf[3] = objs[4].integer.value; > + } else { > + return -EINVAL; > + } > + > + return 0; > +} > +EXPORT_SYMBOL(intel_pmc_core_ipc); > + > static inline u32 pmc_core_reg_read(struct pmc_dev *pmcdev, int reg_offset) > { > return readl(pmcdev->regbase + reg_offset); > @@ -1130,6 +1190,7 @@ static int pmc_core_probe(struct platform_device *pdev) > mutex_init(&pmcdev->lock); > core_init(pmcdev); > > + pmc_cpu_id = cpu_id; > > if (lpit_read_residency_count_address(&slp_s0_addr)) { > pmcdev->base_addr = PMC_BASE_ADDR_DEFAULT; > diff --git a/drivers/platform/x86/intel/pmc/icl.c b/drivers/platform/x86/intel/pmc/icl.c > index 2f11b1a6daeb..f18048ff9382 100644 > --- a/drivers/platform/x86/intel/pmc/icl.c > +++ b/drivers/platform/x86/intel/pmc/icl.c > @@ -8,7 +8,7 @@ > * > */ > > -#include "core.h" > +#include > > const struct pmc_bit_map icl_pfear_map[] = { > {"RES_65", BIT(0)}, > diff --git a/drivers/platform/x86/intel/pmc/mtl.c b/drivers/platform/x86/intel/pmc/mtl.c > index e8cc156412ce..7897f5fe9881 100644 > --- a/drivers/platform/x86/intel/pmc/mtl.c > +++ b/drivers/platform/x86/intel/pmc/mtl.c > @@ -9,7 +9,7 @@ > */ > > #include > -#include "core.h" > +#include > > const struct pmc_reg_map mtl_reg_map = { > .pfear_sts = ext_tgl_pfear_map, > diff --git a/drivers/platform/x86/intel/pmc/spt.c b/drivers/platform/x86/intel/pmc/spt.c > index e16982236778..95ce490cf5d6 100644 > --- a/drivers/platform/x86/intel/pmc/spt.c > +++ b/drivers/platform/x86/intel/pmc/spt.c > @@ -8,7 +8,7 @@ > * > */ > > -#include "core.h" > +#include > > const struct pmc_bit_map spt_pll_map[] = { > {"MIPI PLL", SPT_PMC_BIT_MPHY_CMN_LANE0}, > diff --git a/drivers/platform/x86/intel/pmc/tgl.c b/drivers/platform/x86/intel/pmc/tgl.c > index c245ada849d0..a1719d809497 100644 > --- a/drivers/platform/x86/intel/pmc/tgl.c > +++ b/drivers/platform/x86/intel/pmc/tgl.c > @@ -8,7 +8,7 @@ > * > */ > > -#include "core.h" > +#include > > #define ACPI_S0IX_DSM_UUID "57a6512e-3979-4e9d-9708-ff13b2508972" > #define ACPI_GET_LOW_MODE_REGISTERS 1 > diff --git a/drivers/platform/x86/intel/pmc/core.h b/include/linux/intel_pmc_core.h > similarity index 95% > rename from drivers/platform/x86/intel/pmc/core.h > rename to include/linux/intel_pmc_core.h > index 9ca9b9746719..82810e8b92a2 100644 > --- a/drivers/platform/x86/intel/pmc/core.h > +++ b/include/linux/intel_pmc_core.h > @@ -250,7 +250,16 @@ enum ppfear_regs { > #define MTL_LPM_STATUS_OFFSET 0x1700 > #define MTL_LPM_LIVE_STATUS_OFFSET 0x175C > > -extern const char *pmc_lpm_modes[]; > +#define IPC_SOC_REGISTER_ACCESS 0xAA > +#define IPC_SOC_SUB_CMD_READ 0x00 > +#define IPC_SOC_SUB_CMD_WRITE 0x01 > + > +struct pmc_ipc_cmd { > + u32 cmd; > + u32 sub_cmd; > + u32 size; > + u32 wbuf[4]; > +}; > > struct pmc_bit_map { > const char *name; > @@ -427,4 +436,20 @@ static const struct file_operations __name ## _fops = { \ > .release = single_release, \ > } > > +#if IS_ENABLED(CONFIG_INTEL_PMC_CORE) > +/** > + * intel_pmc_core_ipc() - PMC IPC Mailbox accessor > + * @ipc_cmd: struct pmc_ipc_cmd prepared with input to send > + * @rbuf: Allocated u32[4] array for returned IPC data > + * > + * Return: 0 on success. Non-zero on mailbox error > + */ > +int intel_pmc_core_ipc(struct pmc_ipc_cmd *ipc_cmd, u32 *rbuf); > +#else > +static inline int intel_pmc_core_ipc(struct pmc_ipc_cmd *ipc_cmd, u32 *rbuf) > +{ > + return -ENODEV; > +} > +#endif /* CONFIG_INTEL_PMC_CORE */ > + > #endif /* PMC_CORE_H */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel