From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56FF4C6FD19 for ; Thu, 16 Mar 2023 19:22:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9Y+LZB0NZZ2QcfQNWFC+nHhYZXccz8bhNkzRzzmy4TI=; b=rQP13O54X6sAfo kmV/412EEcQTiI3qLXMZwN/osuZM0LCURfcKwan0bRw3mZ+gBTlv2htjgiaVl2dAVXi3F+WdZFIaD 8RUYNxTiP7JU/btqVt6LuRinJrQ2JwKg4/sWEvBGnZjQEMlaKCV6AqjcFyHZ6dDAtzNQNPc67OqV8 v9O+suqAd7amG0Spv3Vjfm8wziwjewOP5T5paf04bnM1o6BwDAoqVi34TneV1BQfsmxxVCSU6B/bB rm6I/wQfnnB0yv/NKx/ozPLUKWC29tYNLEh9oZZyMpOo8Xvy4dgNULa/5+xt0j75UmHnwkcTXkFoX BJ9QreHcGWLUilJWdc1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pct9n-00HLiO-2r; Thu, 16 Mar 2023 19:20:59 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pct9l-00HLhn-1N for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 19:20:58 +0000 Received: by mail-ed1-x52d.google.com with SMTP id r11so11827504edd.5 for ; Thu, 16 Mar 2023 12:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678994453; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I6W9kUfmlY3tEraL4nU9eY/Af3MdcpRFdLZzCUy+85U=; b=hVfamywI7Z36xHj6XfceRT3rEYu7wfXqO1XRTmOt0XtuS1PkmzUQX16lsH2KqLEfeV d255f9CAmKEI7EjqrU+c2cWlBUD0/GqyV9J10tpEQV7fjFsPcfLEIB8cu57VtX7rUDek 4UanuNT7Ya6abBq+7caHifRqkiFOySFpEFbTnXAGI11fG0/r91wVhtxEmL9DFt2KZ+v9 61m93BAFn1HQ/DoFe2qm/JF3HyET+PE7ufKR1sVG3VDpherQkPZwxCxGbZFJj/Mf+ZmD KzSeMCcilkxHvT6YH859eyYaRNj29AaCjaDhv1aCh46FqqymjR95pJOp7h4ME5sShC6V 8VDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678994453; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I6W9kUfmlY3tEraL4nU9eY/Af3MdcpRFdLZzCUy+85U=; b=iRcvBrCuahjP3Rtsw2e5U5uQ1yKNN5O1rAlETZb6rD9QKCe/vvxprLnO4XIlMWb0Sa SajkVnDdZ+EuMKYHsIy2XpFSgYI+dOsFiIjq93h55OfTBOEvnWRx+jButwEVVC/PZuqa 6k+bNs0XQCDamdqW5+8rVxM+5AKIzU3mfsYi02PDASR0eReFM2Bk+TK1owUBrZEyOig5 kY7nSn89GsNJjjyVeOI9gT5jelLB/iDt7JwDwtxPOlTkZJ3ZJkc7hi9MyLxp71YbjP8t 28GkIiR7AkXxVsjtsdazia6txGxSMGW+Uw6qUdPBd8ISJR0FQTg1JxuBwQr+wHlRyZqo yvIg== X-Gm-Message-State: AO0yUKUjV5d9xd7rpp3vDGz43UKSwkVeF+IhMxQYk7AweJ9ktpdpEAWt pHs+H4JQazLL1qmSoywP7nXlWg== X-Google-Smtp-Source: AK7set8t10Jjk9M0yulDUJsBcv70/mUwE18d9PBfWRZHveo8W0esOHyL0XnxuDdXiwksCvF4lp4NSg== X-Received: by 2002:aa7:db96:0:b0:4fa:d2b1:9176 with SMTP id u22-20020aa7db96000000b004fad2b19176mr672063edt.22.1678994453564; Thu, 16 Mar 2023 12:20:53 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:9827:5f65:8269:a95f? ([2a02:810d:15c0:828:9827:5f65:8269:a95f]) by smtp.gmail.com with ESMTPSA id k12-20020a50ce4c000000b004af70c546dasm143487edj.87.2023.03.16.12.20.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 12:20:53 -0700 (PDT) Message-ID: <066ca8a9-783d-de4f-aa49-86748e5ee716@linaro.org> Date: Thu, 16 Mar 2023 20:20:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH net-next 01/11] dt-bindings: net: snps,dwmac: Update interrupt-names Content-Language: en-US To: Andrew Halaney Cc: linux-kernel@vger.kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, bhupesh.sharma@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, richardcochran@gmail.com, linux@armlinux.org.uk, veekhee@apple.com, tee.min.tan@linux.intel.com, mohammad.athari.ismail@intel.com, jonathanh@nvidia.com, ruppala@nvidia.com, bmasney@redhat.com, andrey.konovalov@linaro.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, ncai@quicinc.com, jsuraj@qti.qualcomm.com, hisunil@quicinc.com References: <20230313165620.128463-1-ahalaney@redhat.com> <20230313165620.128463-2-ahalaney@redhat.com> <20230316161525.fwzfyj3fhekfwafd@halaney-x13s> From: Krzysztof Kozlowski In-Reply-To: <20230316161525.fwzfyj3fhekfwafd@halaney-x13s> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_122057_467070_9B080E55 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/03/2023 17:15, Andrew Halaney wrote: > On Thu, Mar 16, 2023 at 08:13:24AM +0100, Krzysztof Kozlowski wrote: >> On 13/03/2023 17:56, Andrew Halaney wrote: >>> From: Bhupesh Sharma >>> >>> As commit fc191af1bb0d ("net: stmmac: platform: Fix misleading >>> interrupt error msg") noted, not every stmmac based platform >>> makes use of the 'eth_wake_irq' or 'eth_lpi' interrupts. >>> >>> So, update the 'interrupt-names' inside 'snps,dwmac' YAML >>> bindings to reflect the same. >>> >>> Acked-by: Krzysztof Kozlowski >>> Signed-off-by: Bhupesh Sharma >>> Signed-off-by: Andrew Halaney >>> --- >>> >>> I picked this up from: >>> https://lore.kernel.org/netdev/20220929060405.2445745-2-bhupesh.sharma@linaro.org/ >>> No changes other than collecting the Acked-by. >>> >>> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> index 16b7d2904696..52ce14a4bea7 100644 >>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> @@ -105,8 +105,8 @@ properties: >>> minItems: 1 >>> items: >>> - const: macirq >>> - - const: eth_wake_irq >>> - - const: eth_lpi >>> + - enum: [eth_wake_irq, eth_lpi] >>> + - enum: [eth_wake_irq, eth_lpi] >> >> I acked it before but this is not correct. This should be: >> + - enum: [eth_wake_irq, eth_lpi] >> + - enum: eth_lpi > > Would > + - enum: [eth_wake_irq, eth_lpi] > + - const: eth_lpi > be more appropriate? With the suggested change above I get the following > error, but with the above things seem to work as I expect: > > (dtschema) ahalaney@halaney-x13s ~/git/redhat/stmmac (git)-[stmmac|rebase-i] % git diff HEAD~ > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 16b7d2904696..ca199a17f83d 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -105,8 +105,8 @@ properties: > minItems: 1 > items: > - const: macirq > - - const: eth_wake_irq > - - const: eth_lpi > + - enum: [eth_wake_irq, eth_lpi] > + - enum: eth_lpi Eh, right, obviously should be here const, so: - const: eth_lpi Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel