From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Joel Stanley" <joel@jms.id.au>
Cc: "Arnd Bergmann" <arnd@arndb.de>, "Rob Herring" <robh@kernel.org>,
"Zev Weiss" <zev@bewilderbeest.net>,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Pengutronix Kernel Team" <kernel@pengutronix.de>
Subject: Re: [PATCH 04/40] soc/aspeed: aspeed-uart-routing: Convert to platform remove callback returning void
Date: Tue, 26 Sep 2023 11:01:37 +0930 [thread overview]
Message-ID: <066ea199-30fe-44e8-a3ef-aca3ca92605c@app.fastmail.com> (raw)
In-Reply-To: <20230925095532.1984344-5-u.kleine-koenig@pengutronix.de>
On Mon, 25 Sep 2023, at 19:24, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-26 1:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de>
2023-09-25 9:54 ` [PATCH 01/40] soc/aspeed: aspeed-lpc-ctrl: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-26 1:33 ` Andrew Jeffery
2023-09-25 9:54 ` [PATCH 02/40] soc/aspeed: aspeed-lpc-snoop: " Uwe Kleine-König
2023-09-26 1:30 ` Andrew Jeffery
2023-09-25 9:54 ` [PATCH 03/40] soc/aspeed: aspeed-p2a-ctrl: " Uwe Kleine-König
2023-09-26 1:32 ` Andrew Jeffery
2023-09-25 9:54 ` [PATCH 04/40] soc/aspeed: aspeed-uart-routing: " Uwe Kleine-König
2023-09-26 1:31 ` Andrew Jeffery [this message]
2023-09-25 9:54 ` [PATCH 05/40] soc/fsl: dpaa2-console: " Uwe Kleine-König
2023-09-25 9:54 ` [PATCH 06/40] soc/fsl: cpm: qmc: " Uwe Kleine-König
2023-09-27 6:44 ` Herve Codina
2023-09-25 9:54 ` [PATCH 07/40] soc/fsl: cpm: tsa: " Uwe Kleine-König
2023-09-27 6:44 ` Herve Codina
2023-09-25 9:55 ` [PATCH 14/40] soc/mediatek: mtk-devapc: " Uwe Kleine-König
2023-09-26 9:23 ` AngeloGioacchino Del Regno
2023-09-25 9:55 ` [PATCH 15/40] soc/mediatek: mtk-mmsys: " Uwe Kleine-König
2023-09-26 9:23 ` AngeloGioacchino Del Regno
2023-09-25 9:55 ` [PATCH 30/40] soc/rockchip: io-domain: " Uwe Kleine-König
2023-10-01 22:58 ` Heiko Stuebner
2023-09-25 9:55 ` [PATCH 31/40] soc/samsung: exynos-chipid: " Uwe Kleine-König
2023-09-28 5:52 ` (subset) " Krzysztof Kozlowski
2023-09-25 9:55 ` [PATCH 33/40] soc/ti: k3-ringacc: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 34/40] soc/ti: knav_dma: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 35/40] soc/ti: knav_qmss_queue: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 36/40] soc/ti: pm33xx: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 37/40] soc/ti: pruss: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 38/40] soc/ti: smartreflex: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 39/40] soc/ti: wkup_m3_ipc: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 40/40] soc/xilinx: zynqmp_power: " Uwe Kleine-König
2023-10-02 9:13 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=066ea199-30fe-44e8-a3ef-aca3ca92605c@app.fastmail.com \
--to=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=joel@jms.id.au \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).