linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] pinctrl: Add pinctrl-s3c24xx driver
Date: Sun, 12 May 2013 00:28:50 +0900	[thread overview]
Message-ID: <067401ce4e5c$3cee48d0$b6cada70$%kim@samsung.com> (raw)
In-Reply-To: <201305111726.49491.heiko@sntech.de>

Heiko St?bner wrote:
> 
> Am Freitag, 10. Mai 2013, 02:32:05 schrieb Kukjin Kim:
> > Heiko St?bner wrote:
> > > The s3c24xx pins follow a similar pattern as the other Samsung SoCs
> and
> > > can therefore reuse the already introduced infrastructure.
> > >
> > > The s3c24xx SoCs have one design oddity in that the first 4 external
> > > interrupts do not reside in the eint pending register but in the main
> > > interrupt controller instead. We solve this by forwarding the external
> > > interrupt from the main controller into the irq domain of the pin bank.
> > > The masking/acking of these interrupts is handled in the same way.
> > >
> > > Furthermore the S3C2412/2413 SoCs contain another oddity in that they
> > > keep the same 4 eints in the main interrupt controller and eintpend
> > > register and requiring ack operations to happen in both. This is
> solved
> > > by using different compatible properties for the wakeup eint node
> which
> > > set a property accordingly.
> > >
> > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > > Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> > > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Looks good to me.
> >
> > Linus, if you want me to take into samsung tree, please let me know.
> 
> in v4 Linus said:
> 
> "Are you taking this through the Samsung tree?"
> 
> This would also enable me to put the s3c2416 devicetree support on top of
> it
> in this cycle, which of course needs the pinctrl driver.
> 
OK, will apply into samsung tree.

Thanks.

- Kukjin

      reply	other threads:[~2013-05-11 15:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03 13:52 [PATCH v5] pinctrl: Add pinctrl-s3c24xx driver Heiko Stübner
2013-05-10  0:32 ` Kukjin Kim
2013-05-11 15:26   ` Heiko Stübner
2013-05-11 15:28     ` Kukjin Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='067401ce4e5c$3cee48d0$b6cada70$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).