From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B16EC433ED for ; Tue, 27 Apr 2021 17:43:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F2A561164 for ; Tue, 27 Apr 2021 17:43:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F2A561164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P8x5oo/2Ak88joghPt8lfE0ZZ9DAlf9XiwcOrBMIL9c=; b=GlX8ceddFl8BG5FUsoNULOAOO bHbKH3+H0elI+KLj9N8NFjrRurMtU4PTCKmuuyJ8L5JyJEhuusnYF8JD0UtJ5jaIUJZ2PWsaO3Ahd ehP4wmO3xNlZ6xmI/dkeu4pOLprU1ABq6JblUy0FvUJO54xyoZrd+jbFWx3RMr+Gft6fuEJUY1pvp CzWFoDvVAQVTTO0S8CKpbkg+nZpeePUh3XCNuGChhPGqAiip4xyXBoWFPGljCdUljHRPqNFNzaaFB MYQao7zLHbNoNLsekA2/zfX7s8wl8uPyOOATDnyACdz7y6JyjCPAARBFrVGSVfeky+daE5xzYnUAb kYXZg/DgA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbRiL-001ySW-35; Tue, 27 Apr 2021 17:41:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbRiI-001ySH-4L for linux-arm-kernel@desiato.infradead.org; Tue, 27 Apr 2021 17:41:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=EfL7GXc8hwCKj4rhRCv7ccQntQXv7jjHdStoIaSQ+Lw=; b=Gsc39HQY+RYzw6rJSIbcNyxdPM +uRo4mHD6K0D6C36pCQEJLHEAW/cuO7Rp/ux+jXhYSor3b7BtTDkXD/E5zBWzQy4ryVTGSiNJL0tr 3e4BckMpY7uWpcEAy7IAloMa3hlcOT7txPGdIulZMdz3N4ETfUIKD8+5fyuwUoHQnLEt1ugLk9dAd mK84yGnZk+GmL0Lv9c2x0MgCz8FAFdvFHghYAMRoTEVEEp/SiiBtVP/l1m3uDXStRmlsQCWgq0K1N OtsvsEpgf6RLplZUKJXDvsKbijR9BYQmlS5Uwp58VHRs6RF7fh3+76nT8u8Z1F95IjO5wgK77DEQB 5gK7wPaA==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbRiE-00GtSR-DQ for linux-arm-kernel@lists.infradead.org; Tue, 27 Apr 2021 17:41:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9695731B; Tue, 27 Apr 2021 10:41:14 -0700 (PDT) Received: from [10.57.61.101] (unknown [10.57.61.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3EF583F694; Tue, 27 Apr 2021 10:41:13 -0700 (PDT) Subject: Re: [PATCH v2 2/3] ACPI/IORT: Add Qualcomm Snapdragon platforms to iort_plat_info[] To: Shawn Guo , Will Deacon Cc: Bjorn Andersson , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20210402035602.9484-1-shawn.guo@linaro.org> <20210402035602.9484-3-shawn.guo@linaro.org> From: Robin Murphy Message-ID: <06a62dc7-f2d8-7b74-3240-adf8504c5063@arm.com> Date: Tue, 27 Apr 2021 18:41:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210402035602.9484-3-shawn.guo@linaro.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210427_104130_537339_61EF1939 X-CRM114-Status: GOOD ( 20.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-04-02 04:56, Shawn Guo wrote: > The SMMU driver on Qualcomm Snapdragon platforms needs to hook up some > QCOM specific arm_smmu_impl. Define model identifier for QCOM SMMU and > add Qualcomm SC8180X platform to iort_plat_info[], so that SMMU > driver can detect the model and handle QCOM specific arm_smmu_impl. > > Some device chooses to use manufacturer name in IORT table, like Lenovo > Flex 5G, while others use SoC vendor name, such as Microsoft Surface Pro > X and Samsung Galaxy Book S. Just to clarify, my expectation was that the relevant match table and its usage would be private to arm-smmu-qcom. There didn't seem to be any obvious reason that couldn't work, but please do enlighten me if I've overlooked something. Robin. > Signed-off-by: Shawn Guo > --- > drivers/acpi/arm64/iort.c | 5 +++++ > include/linux/acpi_iort.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index e2a96d2d399a..f88b8c0a7d84 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -1467,6 +1467,11 @@ static struct acpi_platform_list iort_plat_info[] __initdata = { > /* HiSilicon Hip08 Platform */ > {"HISI ", "HIP08 ", 0, ACPI_SIG_IORT, greater_than_or_equal, > "Erratum #162001800", IORT_SMMU_V3_PMCG_HISI_HIP08}, > + /* Qualcomm Snapdragon Platform */ > + { "LENOVO", "CB-01 ", 0x8180, ACPI_SIG_IORT, equal, > + "QCOM SMMU", IORT_SMMU_QCOM }, > + { "QCOM ", "QCOMEDK2", 0x8180, ACPI_SIG_IORT, equal, > + "QCOM SMMU", IORT_SMMU_QCOM }, > { } > }; > > diff --git a/include/linux/acpi_iort.h b/include/linux/acpi_iort.h > index 678cdf036948..66c859ea2abf 100644 > --- a/include/linux/acpi_iort.h > +++ b/include/linux/acpi_iort.h > @@ -21,6 +21,7 @@ > */ > #define IORT_SMMU_GENERIC 0x00000000 /* Generic SMMU */ > #define IORT_SMMU_V3_PMCG_HISI_HIP08 0x00000001 /* HiSilicon HIP08 PMCG */ > +#define IORT_SMMU_QCOM 0x00000002 /* QCOM SMMU */ > > struct iort_smmu_pdata { > struct acpi_iort_node *node; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel