linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] ARM: EXYNOS: Add missing static to file-scope declarations
Date: Tue, 03 Feb 2015 13:10:02 +0900	[thread overview]
Message-ID: <06c201d03f67$48da45b0$da8ed110$@kernel.org> (raw)
In-Reply-To: <1420819476-23344-1-git-send-email-k.kozlowski@samsung.com>

Krzysztof Kozlowski wrote:
> 
> The 'pm_data', 'exynos_release_ret_regs' and
> 'exynos5420_release_ret_regs' are not exported nor used outside of
> suspend.c file. Make them static.
> 
> This fixes following sparse warnings:
> arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static?
> arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared.
> Should it be static?
> arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared.
> Should it be static?
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/mach-exynos/suspend.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
> index 342797b9bf3b..fef091f8e59f 100644
> --- a/arch/arm/mach-exynos/suspend.c
> +++ b/arch/arm/mach-exynos/suspend.c
> @@ -75,7 +75,7 @@ struct exynos_pm_data {
>  	int (*cpu_suspend)(unsigned long);
>  };
> 
> -struct exynos_pm_data *pm_data;
> +static struct exynos_pm_data *pm_data;
> 
>  static int exynos5420_cpu_state;
>  static unsigned int exynos_pmu_spare3;
> @@ -98,7 +98,7 @@ static const struct exynos_wkup_irq exynos5250_wkup_irq[] = {
>  	{ /* sentinel */ },
>  };
> 
> -unsigned int exynos_release_ret_regs[] = {
> +static unsigned int exynos_release_ret_regs[] = {
>  	S5P_PAD_RET_MAUDIO_OPTION,
>  	S5P_PAD_RET_GPIO_OPTION,
>  	S5P_PAD_RET_UART_OPTION,
> @@ -109,7 +109,7 @@ unsigned int exynos_release_ret_regs[] = {
>  	REG_TABLE_END,
>  };
> 
> -unsigned int exynos5420_release_ret_regs[] = {
> +static unsigned int exynos5420_release_ret_regs[] = {
>  	EXYNOS_PAD_RET_DRAM_OPTION,
>  	EXYNOS_PAD_RET_MAUDIO_OPTION,
>  	EXYNOS_PAD_RET_JTAG_OPTION,
> --

Looks ok to me, how about re-spin this patch including following?

...
+static unsigned int exynos3250_release_ret_regs[] = {
...

Thanks,
Kukjin

  reply	other threads:[~2015-02-03  4:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 16:04 [RESEND PATCH] ARM: EXYNOS: Add missing static to file-scope declarations Krzysztof Kozlowski
2015-02-03  4:10 ` Kukjin Kim [this message]
2015-02-03  8:06   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='06c201d03f67$48da45b0$da8ed110$@kernel.org' \
    --to=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).