From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/6] Exynos4 NURI: configure regulators and PMIC (MAX8997)
Date: Thu, 21 Jul 2011 01:59:15 +0900 [thread overview]
Message-ID: <06c401cc46fe$5e9348d0$1bb9da70$%kim@samsung.com> (raw)
In-Reply-To: <1309421729-11172-3-git-send-email-myungjoo.ham@samsung.com>
MyungJoo Ham wrote:
>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
(snip)
> +#include <linux/mfd/max8997.h>
(snip)
>
> +static void __init nuri_power_init(void)
> +{
> + int gpio;
> + int irq_base = IRQ_GPIO_END + 1;
> +
> + nuri_max8997_pdata.irq_base = irq_base;
> + irq_base += MAX8997_IRQ_NR;
Oops :(
arch/arm/mach-exynos4/mach-nuri.c: In function 'nuri_power_init':
arch/arm/mach-exynos4/mach-nuri.c:1051: error: 'MAX8997_IRQ_NR' undeclared
(first use in this function)
arch/arm/mach-exynos4/mach-nuri.c:1051: error: (Each undeclared identifier
is reported only once
arch/arm/mach-exynos4/mach-nuri.c:1051: error: for each function it appears
in.)
make[2]: *** [arch/arm/mach-exynos4/mach-nuri.o] Error 1
So need to add inclusion of <linux/mfd/max8997-private.h> on this file.
I fixed it.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> +
> + gpio = EXYNOS4_GPX0(7);
> + gpio_request(gpio, "AP_PMIC_IRQ");
> + s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(0xf));
> + s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
> +}
> +
> /* USB EHCI */
> static struct s5p_ehci_platdata nuri_ehci_pdata;
>
> @@ -361,6 +980,7 @@ static void __init nuri_ehci_init(void)
>
> static struct platform_device *nuri_devices[] __initdata = {
> /* Samsung Platform Devices */
> + &s3c_device_i2c5, /* PMIC should initialize first */
> &emmc_fixed_voltage,
> &s3c_device_hsmmc0,
> &s3c_device_hsmmc2,
> @@ -387,10 +1007,13 @@ static void __init nuri_machine_init(void)
> {
> nuri_sdhci_init();
> nuri_tsp_init();
> + nuri_power_init();
>
> i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs));
> s3c_i2c3_set_platdata(&i2c3_data);
> i2c_register_board_info(3, i2c3_devs, ARRAY_SIZE(i2c3_devs));
> + s3c_i2c5_set_platdata(NULL);
> + i2c5_devs[I2C5_MAX8997].irq = gpio_to_irq(EXYNOS4_GPX0(7));
> i2c_register_board_info(5, i2c5_devs, ARRAY_SIZE(i2c5_devs));
>
> nuri_ehci_init();
> --
> 1.7.4.1
next prev parent reply other threads:[~2011-07-20 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 8:15 [PATCH v3 0/6] ARM: EXYNOS4: NURI Board Configuration Update MyungJoo Ham
2011-06-30 8:15 ` [PATCH v3 1/6] ARM: EXYNOS4: Increase NR_IRQS for devices with more IRQs MyungJoo Ham
2011-07-20 17:04 ` Kukjin Kim
2011-07-21 2:18 ` MyungJoo Ham
2011-07-21 5:43 ` MyungJoo Ham
2011-06-30 8:15 ` [PATCH v3 2/6] Exynos4 NURI: configure regulators and PMIC (MAX8997) MyungJoo Ham
2011-07-20 16:59 ` Kukjin Kim [this message]
2011-06-30 8:15 ` [PATCH v3 3/6] Exynos4 NURI: configure MAX17042 fuel gauge MyungJoo Ham
2011-06-30 8:15 ` [PATCH v3 4/6] Exynos4 NURI: configure ADC MyungJoo Ham
2011-06-30 8:15 ` [PATCH v3 5/6] Exynos4 NURI: configure MAX8903 secondary charger MyungJoo Ham
2011-06-30 8:15 ` [PATCH v3 6/6] Exynos4 NURI: configure rtc-s3c MyungJoo Ham
2011-07-16 7:15 ` [PATCH v3 0/6] ARM: EXYNOS4: NURI Board Configuration Update Kukjin Kim
2011-07-20 15:40 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='06c401cc46fe$5e9348d0$1bb9da70$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).