From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Sangwook Shin'" <sw617.shin@samsung.com>, <krzk@kernel.org>,
<wim@linux-watchdog.org>, <linux@roeck-us.net>,
<semen.protsenko@linaro.org>, <dongil01.park@samsung.com>,
<khwan.seo@samsung.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-watchdog@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v6 2/5] watchdog: s3c2410_wdt: Fix max_timeout being calculated larger
Date: Thu, 18 Sep 2025 09:11:47 +0530 [thread overview]
Message-ID: <06c401dc284e$2bec2a50$83c47ef0$@samsung.com> (raw)
In-Reply-To: <20250818021826.623830-3-sw617.shin@samsung.com>
Hi Sangwook
> -----Original Message-----
> From: Sangwook Shin <sw617.shin@samsung.com>
> Sent: Monday, August 18, 2025 7:48 AM
> To: krzk@kernel.org; alim.akhtar@samsung.com; wim@linux-watchdog.org;
> linux@roeck-us.net; semen.protsenko@linaro.org;
> dongil01.park@samsung.com; khwan.seo@samsung.com
> Cc: linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
> linux-watchdog@vger.kernel.org; linux-kernel@vger.kernel.org; Sangwook Shin
> <sw617.shin@samsung.com>
> Subject: [PATCH v6 2/5] watchdog: s3c2410_wdt: Fix max_timeout being
> calculated larger
>
> Fix the issue of max_timeout being calculated larger than actual value.
> The calculation result of freq / (S3C2410_WTCON_PRESCALE_MAX + 1) /
> S3C2410_WTCON_MAXDIV is smaller than the actual value because the
> remainder is discarded during the calculation process. This leads to a larger
> calculated value for max_timeout compared to the actual settable value.
> To resolve this issue, the order of calculations in the computation process has
> been adjusted.
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> Signed-off-by: Sangwook Shin <sw617.shin@samsung.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
next prev parent reply other threads:[~2025-09-18 3:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250818022433epcas2p37fe2cdc20b32b23ee894ceb636717a53@epcas2p3.samsung.com>
2025-08-18 2:18 ` [PATCH v6 0/5] Increase max timeout value of s3c2410 watchdog Sangwook Shin
2025-08-18 2:18 ` [PATCH v6 1/5] watchdog: s3c2410_wdt: Replace hardcoded values with macro definitions Sangwook Shin
2025-08-21 15:34 ` Guenter Roeck
2025-08-18 2:18 ` [PATCH v6 2/5] watchdog: s3c2410_wdt: Fix max_timeout being calculated larger Sangwook Shin
2025-08-18 22:27 ` Sam Protsenko
2025-08-21 15:34 ` Guenter Roeck
2025-09-18 3:41 ` Alim Akhtar [this message]
2025-08-18 2:18 ` [PATCH v6 3/5] watchdog: s3c2410_wdt: Increase max timeout value of watchdog Sangwook Shin
2025-08-21 15:35 ` Guenter Roeck
2025-09-18 3:53 ` Alim Akhtar
2025-08-18 2:18 ` [PATCH v6 4/5] watchdog: s3c2410_wdt: exynosautov920: Enable QUIRK_HAS_32BIT_CNT Sangwook Shin
2025-08-21 15:35 ` Guenter Roeck
2025-09-18 3:57 ` Alim Akhtar
2025-08-18 2:18 ` [PATCH v6 5/5] watchdog: s3c2410_wdt: exynosautov9: Enable supported features Sangwook Shin
2025-08-21 15:35 ` Guenter Roeck
2025-09-18 4:05 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='06c401dc284e$2bec2a50$83c47ef0$@samsung.com' \
--to=alim.akhtar@samsung.com \
--cc=dongil01.park@samsung.com \
--cc=khwan.seo@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=semen.protsenko@linaro.org \
--cc=sw617.shin@samsung.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).