From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDD06C433EF for ; Sun, 3 Apr 2022 15:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+BhKEGVZdaV31mOurGrVUvWwnoJf0C5MxeL14xzPoZE=; b=IOLMDIT/lPttWK yebNIC9fZlUkXIM7IYjKYuceidAZYwQtUROQOy+3ejsUhmGHZ1aO+k2EBSzJ+rmzIIv7gsRh2A5dU KQhd9Gx2eg7VxaL4irNR7+EMLygIjvea5zIi/xm60LIwxjdEFVnFSvsOuRfUwCAg0yu2tIfUAljQh OUN0LQaw50/2N7SzydzhwU9s9LU9ub98WPlr7Zm2Nh2zlmuH8kkHL4ejJAYIHy6kPKdCYSb/UtuV/ tbVkSF3i4eByTvW8xWee62X5RJv9UMAK9EiqClyOnW6xNGJSjxx/9kFPEHa9xMW0HZQ8++hajSXwP qsMVpai+dXOn7bcx8+dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nb2UF-00Blo0-T5; Sun, 03 Apr 2022 15:49:56 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nb2UB-00Blm1-VY for linux-arm-kernel@lists.infradead.org; Sun, 03 Apr 2022 15:49:53 +0000 Received: by mail-ej1-x62e.google.com with SMTP id bh17so15238093ejb.8 for ; Sun, 03 Apr 2022 08:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Nl7mx8m7EnlbDwYYwvHzo6XZQrrQmR8xseakEJu/ApQ=; b=MAqUTVvxlESuAw6otRHcDSI7aSiMb/pzHxYyyc8ocwlSKeZ0QbusTy+3VVAT4PMjjZ r35T4x1/aKMCNukK3w5y4OjNLkM0JGY1j+bYY3bZiDiQBTONI3EcfWOlbKrHIEqQEpQm PulMplT17U+A4s8Q+qHr5FI/pw98uxA0mwdUGTLc3nomLuZLeeHl7TX+K04794pLORF+ OHiLPHqoQ8zeryorwhj0pYSbudxizi0JyQik9ge8WsZmBPAgYW679WPOg3T1LhmTKCAq CiZapoJ1nG8IcKCUzTyQJocZdDtPgCWWrBCInKFEIy1voIhcjpOjGk3xCcCwsX+n1NoL GiGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Nl7mx8m7EnlbDwYYwvHzo6XZQrrQmR8xseakEJu/ApQ=; b=hsH75OzFWWuZm8hviRbSD0eF7AQp4uTH1t7brO1pYG2NuQ5TAqZWLcMuUt5Z3JoIn4 x7z6PHjibWOpfdMxe2AZ+aIB297+/Vd3TmJY8djc3WsYvUsevf2J4m+mKYvNdmc2EOpm 9ptgnBijDUqLH6sjm6bPpDcrDaACkpaZ/U7SsdTj5ndpowXQ1qM/0Vq8/D4Cl5LLIShk 9XU0m4g5THs+edPS5z/aRV3iuMdryLFFLmHxhOcC0flsgzIz12FPQkF2qBFujy2SMXpb DGWNSmvS0WSVFlEp+qOqk81r9wCSEMw5HV7xMNNEULLwk4BlgjzMJAmPnNC48nYYYAkw SDXQ== X-Gm-Message-State: AOAM530w2V0qJVbhr8hlR2NNNL9Dfeg8Zcy8nmFYHPV8qseyi6z5QkFD LcR3Zpkv0w63AuVtggIaI3HYFQ== X-Google-Smtp-Source: ABdhPJx3rcnv1yKUNSctVm5332uQ8CUzIarsgEIAO55wHKNgl2rFifkjJnDT+yD+tVwKZKX0hGsBGA== X-Received: by 2002:a17:907:6d0a:b0:6db:f0f8:6528 with SMTP id sa10-20020a1709076d0a00b006dbf0f86528mr7426771ejc.466.1649000989905; Sun, 03 Apr 2022 08:49:49 -0700 (PDT) Received: from [192.168.0.172] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id ep16-20020a1709069b5000b006daa26de2fbsm3313742ejc.153.2022.04.03.08.49.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Apr 2022 08:49:49 -0700 (PDT) Message-ID: <06ef6b4b-c8e8-549b-54be-9eecf59a7757@linaro.org> Date: Sun, 3 Apr 2022 17:49:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 3/4] dt-bindings: spi: add binding doc for spi-mtk-snfi Content-Language: en-US To: Chuanhong Guo , Miquel Raynal Cc: linux-spi@lists.infradead.org, Mark Brown , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Richard Weinberger , Vignesh Raghavendra , Roger Quadros , Thomas Bogendoerfer , Cai Huoqing , Florian Fainelli , Colin Ian King , Wolfram Sang , Paul Cercueil , Pratyush Yadav , Yu Kuai , "open list:SPI SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , open list , "open list:NAND FLASH SUBSYSTEM" References: <20220403131154.1267887-1-gch981213@gmail.com> <20220403131154.1267887-4-gch981213@gmail.com> <817dda10-39db-adfc-376d-a3d5e037937e@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220403_084952_071328_B6DFD8B7 X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/04/2022 17:45, Chuanhong Guo wrote: > Hi! > > On Sun, Apr 3, 2022 at 11:37 PM Krzysztof Kozlowski > wrote: >> [...] >>> + compatible: >>> + enum: >>> + - mediatek,mt7622-snand >>> + - mediatek,mt7629-snand >> >> One blank line, please. > > I'll fix this in the next version. > >> >>> + reg: >>> + items: >>> + - description: core registers >>> + >>> + interrupts: >>> + items: >>> + - description: NFI interrupt >>> + >>> + clocks: >>> + items: >>> + - description: clock used for the controller >>> + - description: clock used for the SPI bus >>> + >>> + clock-names: >>> + items: >>> + - const: nfi_clk >>> + - const: pad_clk >>> + >>> + ecc-engine: >> >> The nand-chip.yaml defines a nand-ecc-engine, so how about using that >> one? I know mtk-nand.txt uses ecc-engine, but for new schema better to >> use properties from existing YAML. > > The ecc-engine code is shared between mtk_nand.c and this driver, and > the property name is defined in the shared part. I left it as-is so that > existing dt for mtk_nand doesn't break. This can be easily fixed with: np = of_parse_phandle(of_node, "nand-ecc-engine", 0); if (!np) { /* Backwards compatible */ np = of_parse_phandle(of_node, "ecc-engine", 0); } I would like to avoid having one property in generic NAND schema and keep adding something slightly different everywhere else. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel