From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA749C25B76 for ; Thu, 30 May 2024 16:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1yWg2gjHACbhjPEzVJ2iXsUg5Z9sDyRQjE8xfOcqbIg=; b=i64veYchhJIEsR KHMDP4//so8biaeqZhx+Bnhl3+BzwjdNxI2OKTG//KVOZcdP2vAdaNVwIpOnWUTb33RWwnSt4LOnT OFoCEklNj6X/p0qLnTzpBj6wABtlyEjTYp1WTarzdHP2bTc3fF9Y4b6UDaQhDOyshVdHUW0Dck0lp I7NYhWvQY6Lav9DQ/HwAkeEEd7+k3e9JJGVRsRkodM9ncqbuooyP9J7gvAsoAGhTaye7sYGNFtcmi l/yspNZWkpomfK/sh1L4X3DWD3ZMUrGXkoZ7tx+ekDY7P2QIhigjvrO23P7HJ8Oo7MaQCr32SiVYf 7Fv8KJ+oud0ww5cfKa3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCibU-00000007q3v-3lOu; Thu, 30 May 2024 16:26:13 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCibP-00000007q3I-0xtH; Thu, 30 May 2024 16:26:11 +0000 X-UUID: 4ef61d421ea111efbf6c7d4f5c147266-20240530 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=Xm62PcRRGCC+D/J8EG5PMaYOEe7x5l59012VZNfy9ak=; b=BlgA0tPEvfGv06GWkY28pLFSVMfUfVpnqNi4NNMJsOxO3dQMVFojJJWtNhz7z1ImOoir768P88QaTUZ1iiQe7/v7EQGWxqG4eZPSGfA6ek/DPBz8LhwpB7qFwyKAXFmbnD26Fmn3AYCf9dbqhtAI5100PMx5CNXRrrDLZHL/xJM=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.39,REQID:c5606f9b-5396-4d18-a4fa-81472e3d62bb,IP:0,U RL:25,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:25 X-CID-META: VersionHash:393d96e,CLOUDID:cce20144-4544-4d06-b2b2-d7e12813c598,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:1,EDM:-3,IP:nil,U RL:11|42|1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0, LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULN X-UUID: 4ef61d421ea111efbf6c7d4f5c147266-20240530 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 940714755; Thu, 30 May 2024 09:26:03 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS09N2.mediatek.inc (172.21.101.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 30 May 2024 09:26:00 -0700 Received: from SINPR02CU002.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 31 May 2024 00:26:00 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CbL5leAVmVKxaXbskaHSflW+cWHr4Ofc4nueVVFCo+I2Y72NP14U+sO23tGXxSFXTQujEqF2GlvsmABQLSitmllnpEaRN+t7ptGE3Dm6XzkOXnXHe4TA54SnF3HHWlESen9+3ZQTJoYSpEfbkjwIbg/vFhmiF3lcXYwrANv8gTKI6WI5rbVcoTftYta7Skj2uAxTAy/rtOw60QHo3ObFDUubL9HhC8ljSOxLJwguqKuvrSG6xKTU7n/VpXjj1LERpgFjBg41FpvS6KAecBK9xqHFL5vWCa6v+vFUkmlgHHNC+7gTl+U9Z2fR0A+jx0Qw1N8OpQGBocTrTExGrrw8Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xm62PcRRGCC+D/J8EG5PMaYOEe7x5l59012VZNfy9ak=; b=D3pK0YizZZuFAtiOsYioAugWBUm1A9QBfT0gb9K8l7fd1tNvHbE/uqQLIMh2P76o+PJ/25Z4Y+CX01KtCOr/5MJ/FJwtFQMswzNgRlgXPBMf8uJSYTeQdycXptr/SCjsIcxpIM2kk4M8Z1xrjtN+ziQFKCwQQDzOtQHSTAcboXixPr8nHoeIf7xmFKH98H13ApBNDzkhJjd88jpJSrFLAyfQaxQd/o/aJ79MSw6aFPJ8aHXsGjqeAT25Y1JOEn5HIMam4QZEeuBioQ8Yax5dDDJ1mMtt5va1SQxM/rXkPX7uaqZMfM5Ko4YN2EZnNxtB5TFVHnjo2BC1FfaGM/P9iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xm62PcRRGCC+D/J8EG5PMaYOEe7x5l59012VZNfy9ak=; b=IOcXn6aUj1IbjHbGZNUQFHnalxN1CcCz3G2dDRb8DJY6GXqxfazVrbG9FIeHsZb0F8ebr9TiyVR+tRmJQFHg2fi4zx0Wn/jVDzCadtZGUmWCIz1JT72V6T2nUZCnxMSmoFbni26mLZXxvbGor6fh+I8yMF+6k7+G1LaIMVoJIzo= Received: from KL1PR03MB6226.apcprd03.prod.outlook.com (2603:1096:820:8c::14) by SG2PR03MB6540.apcprd03.prod.outlook.com (2603:1096:4:1d4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.16; Thu, 30 May 2024 16:25:58 +0000 Received: from KL1PR03MB6226.apcprd03.prod.outlook.com ([fe80::f3:c11:8422:7ce3]) by KL1PR03MB6226.apcprd03.prod.outlook.com ([fe80::f3:c11:8422:7ce3%3]) with mapi id 15.20.7656.007; Thu, 30 May 2024 16:25:56 +0000 From: =?utf-8?B?U2t5TGFrZSBIdWFuZyAo6buD5ZWf5r6kKQ==?= To: "linux@armlinux.org.uk" CC: "andrew@lunn.ch" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "kuba@kernel.org" , "pabeni@redhat.com" , "edumazet@google.com" , "netdev@vger.kernel.org" , "dqfext@gmail.com" , =?utf-8?B?U3RldmVuIExpdSAo5YqJ5Lq66LGqKQ==?= , "matthias.bgg@gmail.com" , "davem@davemloft.net" , "hkallweit1@gmail.com" , "daniel@makrotopia.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH net-next v5 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 Thread-Topic: [PATCH net-next v5 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 Thread-Index: AQHaskSsuAYxyIGHGE6fd61psDix3LGvlbQAgABh2AA= Date: Thu, 30 May 2024 16:25:56 +0000 Message-ID: <0707897b44cfbc479cd08a092829a8bfc480281b.camel@mediatek.com> References: <20240530034844.11176-1-SkyLake.Huang@mediatek.com> <20240530034844.11176-6-SkyLake.Huang@mediatek.com> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: KL1PR03MB6226:EE_|SG2PR03MB6540:EE_ x-ms-office365-filtering-correlation-id: beeeff37-37d8-4f19-6a64-08dc80c52f23 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230031|376005|1800799015|7416005|366007|38070700009; x-microsoft-antispam-message-info: =?utf-8?B?WjFUOFN2cGl6cWx4cFRjTHR2YkJZMUpiQURpam0vMUVYb08yTWNBMWJHLzVQ?= =?utf-8?B?QVNsWnZHalNyL2RMNUtUVnR3cEFXamNHSDJqQkl2Lzc2b3d5TWh5SjJkd1NC?= =?utf-8?B?V3J5WEZqajdUOUN6VWhybmcyYVN1VjJDV3lhN2h3eTg3LzRzSHJnNEtNdVBY?= =?utf-8?B?ODlualQ2STRhZTBjVERjcEppMldWdDI4MVN2NDhwQ1l1RDgrc1NySkVNK0Vv?= =?utf-8?B?RDZ6NEJEcklMZnIxM0thOG1uZmUzRTljbE1mbTljdWZwMlRjTU03OUZQUGpv?= =?utf-8?B?bHJsVW1sbEkrc3JWdFRVMUJvcGNhTWVGWDNtMWdJbVJmZSs1bHRxK1VnRTRh?= =?utf-8?B?UGZ4MFZ1K3U0bjRraUdwRVo0SWlFWDNzODVkYmZ4OHEzanpFN3EvY09oa29L?= =?utf-8?B?ajV2SXRqcmlZRDJucEVFWDVIcVJ2YTlpOXZlNEV5aVkyMjVIYmRMNTNuL3o1?= =?utf-8?B?OS81WHFWS2UydDg3WE92MVJ0dWcyVjRtY0JSM2NzMDZCNk9NTXVHcFphQlRk?= =?utf-8?B?MnExcXZ3UWNKWUJ4S0t3anJPbHQ3QVNsK2ZUUzhYNURWcElqamYwMVdtYVJ1?= =?utf-8?B?Y2tZMU9YNmpiVE9TODdDZTM0V0ZGZlcwWndaQ0VBOStkdHZUTVRGS3JxWG1r?= =?utf-8?B?S3I4ZjRVQ3pWSUh3dHlJSUtvUGNyd3RWMklMYVZ5ZEs2bWRwS1YwTWVWZGhO?= =?utf-8?B?bWxEK0ZDd1BaSTF5YitIa210d2o3WUJEUW9KRU41THJVVU5HdXBvYnNuSFUv?= =?utf-8?B?ZEhjUElhZy9qK205VXNEYUE1NGpyemp6dEwwYkJsUkZjeDYxVURZTEJtT1BU?= =?utf-8?B?c1FnTEI1OHRNUlJ6SWExdFUrTzU2ajVhQjhsQ1IrVDJ0dWk2TUt4RGx4L2gx?= =?utf-8?B?M2NxRUFzZ2ZYZWVGSlgwdkZvSTM1N01ZVkZDYm1RS1luT1QzNThyREFITWEv?= =?utf-8?B?ZnNLUDZuT2Zhc2VGWDJwcTNDbjY1eHBZamN5SzR1L0JzUy8rMHk0eGhGdnMx?= =?utf-8?B?MXJMdXN0OE9qazJ1RjJwQWU4RmRUY1QvbnJoUHhWMVd6ZjBCeHEra05hMkxD?= =?utf-8?B?YktGS3ZUZHAzOEFVbExnYjhkUjU2cDR5WXo1UXlhNnJkTW9GNVd1ZTlVZzNY?= =?utf-8?B?MjdwVVVJSUZlQmZUNm5PdjFiWWRnV0pBZER5ZGxNWWVlZGFXbjV3L3pZL3dY?= =?utf-8?B?dnNQVHJIN09YdStmZ3FLUE8vZm5JQy9VaXAwMmQ0ZDBXSlBFMDRlQysyUXg1?= =?utf-8?B?Y3FJSUNCM1pEQlI5MlYyQ1RvL1RGcTMxRjNnYmR5SzBDb09yZVFIaXpxaGs5?= =?utf-8?B?dFdMV3NUKzZXeEd3REg4Zktnd1NpRXZEVWpaK3ViVW03UVlyQXBjRlF6bkdt?= =?utf-8?B?K1NiT1h0cnAzS1IwN3B5SHdCWGpXeGtyVVhVREFkZXdoa2s1TWNvbk1GcUNY?= =?utf-8?B?YW1OWm1UY2hmZmpuMlZuczRndFN2RVRvL1BydnhuVy9kMGx5eGo3TWkyck9o?= =?utf-8?B?NXZEenpDbDIxZS9lTG1lQnJEWWozcFEvUW9CZnhtRG5XeW96a2U1RG5LZ01X?= =?utf-8?B?Y29MUXBhU0lGRzI2anlMb2NGaU00T1A0WDdiVitRQTFVWXV2UXlTOUIvZGxB?= =?utf-8?B?c3Jwb1pXcHJCdEJPYTgwSGVsVU5sNkVpSVp6bHd6bU8vWDFqR1hPSXdXb3ds?= =?utf-8?B?UUVEVnpDVUNhV1VDRjBZZVo3ZWh5aHprTk9jTmYyYzJtSVFqL3FGTXhRPT0=?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:KL1PR03MB6226.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(7416005)(366007)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SU1HY1JaYmx5Q3lrajRTWFJ3bEdXeWYrUmlMdHF5MHBDQlR5WjZpOHVOQWxj?= =?utf-8?B?S28xcUhQRWw5ZzEwV3ZnU2tBd2kxS05EZGlBWldXdWZhdEQrTGdwcnhuZStm?= =?utf-8?B?azB1QUZWZ01FV2pVWFUyWHEvV1RNVnFVTHJleHV5eXF4MkhQVHNGMlROUzE1?= =?utf-8?B?VmJHS1NncU1mb0tDWFJLYUdhTFkyUWRMT1lkWU9LTFdlMHhvLzFlcXQyeEhX?= =?utf-8?B?RmR6SUFpT0Z3cUxsMk9wRUFiOHFDcVd3ZkIyMkQxbTZuaWQwOEFyTENzenN2?= =?utf-8?B?cStRb3ZSbGhha1kxR29UeXluL000SWNuVHFJZkEvYUpFNWVlNVU2Y3dhS3dv?= =?utf-8?B?aHhiTEJZZzE0ZFBYd0h6NkkrWGZTWWJmeVExcThRcU10MS9qZkJDMndDcnM5?= =?utf-8?B?YWpNZVVXNkZjM0lHRE1lUy9CeEV4RitBdElqYTRrTVRWbEhrcGdUUFhMZGY1?= =?utf-8?B?M3p3QUcrbDgyQXordENJNHdhTmo3aDlLODMrYlRvMml4eEJVY1NFWFl4VW92?= =?utf-8?B?WmplQkxlNlgzU1hMdXhoNXpId2xLb2VuREVXSGkzVnpTK1VrMXZtWFJjN3Iy?= =?utf-8?B?R0wwTmsyVW95SERJLzV4VHhNM3VnT0xwYTZSQnZOT2dLTEV4aS95RzJDdmpr?= =?utf-8?B?N1JLRVFJaXY5clJXazdtVm5kbW5QSWdrZ05Wa2VycEtsZEZpOTdtc3dIMG94?= =?utf-8?B?cHVvMEsrTHF3MnhjdVY4ekozV1J4KzJHZ1hjM3JydkRXU3drdFRCMmpPWDlo?= =?utf-8?B?WjYwbzAzdUd3c1RReDdMbkc5RERpUUdYVnovU0RLZUdZNERTWDYrN2Z4VzAx?= =?utf-8?B?bnQxYmh1aW1UN1pjY2ROTGh5SmRIOWphRXBLTjZ4REtlaXdnNVgrMGxmZkc5?= =?utf-8?B?cEEvbTJvMFVyczJGblkvVWZtR3dlUWxGV1RPYVdlOHJsTk4yZ05iTldJUkZT?= =?utf-8?B?dUdkblpRK0g4M29UMUttUmhVRmsvTUNXVUM0NHRTcFQ2U2t4VEh3Qjk4dnNO?= =?utf-8?B?dTBkY2Y4QlhuUEszZUljZFBTNlBOQ0d2YURKOEF6d2JaNVdLVEF1Z1VQb1g4?= =?utf-8?B?cFh4MERsR0VKcllQdEU3Y1huRFMxV1I4Q3QyZGhIc3NCbDBIcTY4RWxlOUdG?= =?utf-8?B?S1d3QWk0ZGtvcXE1TjBMc2l2a2hSYnNmOTk5cVY4ZzUyaG55Sk9FckRXOXNY?= =?utf-8?B?WFdWZ3lHd01sOGwwVkJsN2xuRHRuWWU3ZVN1U2xnNkxldE05UUtIZHdNNERZ?= =?utf-8?B?RVV6VG1DSzRvNG1ZZ3ZrOXpNZWRmOEVRMDh5U0IzYWZuQzYyN2ZKeXJYRmZ4?= =?utf-8?B?SnJneHpoUTlwSW11eXMzblVRdXFCdk5OaEttM0FOUzZkdkhneTU1QU9kbk5I?= =?utf-8?B?YTViTFkzY3E5dHUvTFNPODA4U0hXY2ozSzRvUWVkRncwdnBickd5ZmNsVzVL?= =?utf-8?B?blROL2MrZ2lHREI1Y0Ivai9DazRQNlNFeEhrd25ranE3WWpVc09GdllVUVBo?= =?utf-8?B?eXcwYmxKd2I0K2pPWGFIcjBqSVhtcmI1QzZsclFjYStHamxYRndBREN1eWVz?= =?utf-8?B?UXJscTI3UDRKWE9HT2VXSnAvQ1ZraGtxcld6aHAzU2xRV2trQStvUXR1VDcw?= =?utf-8?B?aVBUWm0yTVZPU21jQis1QWNUQWZWekViMmwrR3l6cGZZODVRYTBGOVozTldn?= =?utf-8?B?RlVTbUg1cFMwOVVXQnJldzZDbitrOFpIUjRKeVlIVXFkN0dXTXNsWjNIRm9Y?= =?utf-8?B?bEl4SFlrL0JCM25EUG9JcWtQNWttT3NETzg2SHhRUk1OVER5WDU0Yzlxb3h5?= =?utf-8?B?Z2lDOUp1UWp4U0dhczhxaUNQeTljaDJDd3BieVpmM0t3Yjd2Vzh1R1BlKzRZ?= =?utf-8?B?WkdXU2dEOXpkNzhuSy8zVkIrVVVFalFyUWFvRTRYakpEVXlXQ0dUY2VMOW9j?= =?utf-8?B?UUwxamE5aDc4YkRRZHhJUXQzbCtSaGc0NC85cFNDS0JxdDh3UjRXMVkwWVp5?= =?utf-8?B?OGdBUjU3c3ljUXcvQzJtZXIrbTdvY0ZYbDhWSkRma0RYTHFNMThSbUJrVThm?= =?utf-8?B?ZllTekR6dFR0Um5QOUhZSzk1aWt3OVhndmFQdDRuSTV2cG9SbkFxcGhxWitQ?= =?utf-8?B?a3prcFJpZUJXQktkS1hia3JuUCtGeFV2ZVFTeE4xRURrVlg0OXBMaTNYOXJQ?= =?utf-8?B?Umc9PQ==?= Content-ID: <7129ED40843F724B8D23A281322484D3@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: KL1PR03MB6226.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: beeeff37-37d8-4f19-6a64-08dc80c52f23 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2024 16:25:56.7274 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qswb6izFHuyIwcaZZhsc5fu/haPzbm9tmUaQLqu9Rt5ZChqwg7Psq3wBQ3R0tDIXniz0hTedWnWWjGU6RhplXQQYUjAoOEIM2tb01prAJ5g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR03MB6540 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240530_092607_351032_BDA5C854 X-CRM114-Status: GOOD ( 26.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2024-05-30 at 11:35 +0100, Russell King (Oracle) wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Thu, May 30, 2024 at 11:48:44AM +0800, Sky Huang wrote: > > +static int mt798x_2p5ge_phy_config_aneg(struct phy_device *phydev) > > +{ > > +bool changed = false; > > +u32 adv; > > +int ret; > > + > > +/* In fact, if we disable autoneg, we can't link up correctly: > > + * 2.5G/1G: Need AN to exchange master/slave information. > > + * 100M: Without AN, link starts at half duplex(According to IEEE > 802.3-2018), > > + * which this phy doesn't support. > > + * 10M: Deprecated in this ethernet phy. > > + */ > > +if (phydev->autoneg == AUTONEG_DISABLE) > > +return -EOPNOTSUPP; > > We have another driver (stmmac) where a platform driver is wanting to > put a hack in the ksettings_set() ethtool path to error out on > disabling AN for 1G speeds. This sounds like something that is > applicable to more than one hardware (and I've been wondering whether > it is universally true that 1G copper links and faster all require > AN to function.) > > Thus, I'm wondering whether this is something that the core code > should > be doing. > Yeah..As far as I know, 1G/2.5G/5G/10G speed require AN to decide master/slave role. Actually I can use force mode by calling genphy_c45_pma_set_forced, which will set correspoding C45 registers. However, after that, this 2.5G PHY can't still link up with partners. I'll leave EOPNOTSUPP here temporarily. Hope phylib can be patched someday. > > +/* This phy can't handle collision, and neither can (XFI)MAC it's > connected to. > > + * Although it can do HDX handshake, it doesn't support CSMA/CD > that HDX requires. > > + */ > > What the MAC can and can't do really has little bearing on what link > modes the PHY driver should be providing. It is the responsibility of > the MAC driver to appropriately change what is supported when > attaching > to the PHY. If using phylink, this is done by phylink via the MAC > driver > telling phylink what it is capable of via mac_capabilities. > > > +static int mt798x_2p5ge_phy_get_rate_matching(struct phy_device > *phydev, > > + phy_interface_t iface) > > +{ > > +if (iface == PHY_INTERFACE_MODE_XGMII) > > +return RATE_MATCH_PAUSE; > > You mention above XFI... > > XFI is 10GBASE-R protocol to XFP module electrical standards. > SFI is 10GBASE-R protocol to SFP+ module electrical standards. > > phy_interface_t is interested in the protocol. So, given that you > mention XFI, why doesn't this test for PHY_INTERFACE_MODE_10GBASER? > We have 2 XFI-MAC on mt7988 platform. One is connected to internal 2.5Gphy(SoC built-in), as we discussed here (We don't test this phy for 10G speed.) Another one is connected to external 10G phy. > > +static int mt798x_2p5ge_phy_probe(struct phy_device *phydev) > > +{ > > +struct mtk_i2p5ge_phy_priv *priv; > > + > > +priv = devm_kzalloc(&phydev->mdio.dev, > > + sizeof(struct mtk_i2p5ge_phy_priv), GFP_KERNEL); > > +if (!priv) > > +return -ENOMEM; > > + > > +switch (phydev->drv->phy_id) { > > +case MTK_2P5GPHY_ID_MT7988: > > +/* The original hardware only sets MDIO_DEVS_PMAPMD */ > > +phydev->c45_ids.mmds_present |= (MDIO_DEVS_PCS | MDIO_DEVS_AN | > > + MDIO_DEVS_VEND1 | MDIO_DEVS_VEND2); > > No need for parens on the RHS. The RHS is an expression in its own > right, and there's no point in putting parens around the expression > to turn it into another expression! > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! Do you mean these two line? +phydev->c45_ids.mmds_present |= (MDIO_DEVS_PCS | MDIO_DEVS_AN | + MDIO_DEVS_VEND1 | MDIO_DEVS_VEND2); What do you mean by "RHS is an expression in its own right"? I put parens here to enhance readability so we don't need check operator precedence again. Sky _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel