From: claudiu beznea <claudiu.beznea@tuxon.dev>
To: nicolas.ferre@microchip.com,
linux-arm-kernel@lists.infradead.org, jerry.ray@microchip.com
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] ARM: dts: at91: sama5d3_eds: remove TDES use
Date: Fri, 6 Oct 2023 11:15:49 +0300 [thread overview]
Message-ID: <070a6f48-20a4-4e26-a071-0600a6ecea36@tuxon.dev> (raw)
In-Reply-To: <20230928145655.215481-1-nicolas.ferre@microchip.com>
Hi, Nicolas, Jerry,
On 28.09.2023 17:56, nicolas.ferre@microchip.com wrote:
> From: Nicolas Ferre <nicolas.ferre@microchip.com>
>
> TDES doesn't probe because of lack of DMA channels left on this
> controller. As we don't need TDES HW engine, we prefer to keep DMA
> channels for other usage.
> Disable TDES for this board.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> Hi,
>
> Tell me what you think about this move. I think it makes sense but tell me if
> application could suffer from this lack of TDES engine.
It anyway fails to probe. I have nothing against unless its probing could
be fixed. Jerry, are you good with applying this?
Thank you,
Claudiu Beznea
>
> Regards,
> Nicolas
>
> arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> index c287b03d768b..fddd786f8483 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> @@ -284,6 +284,10 @@ timer1: timer@1 {
> };
> };
>
> +&tdes {
> + status = "disabled";
> +};
> +
> &usb0 { /* USB Device port with VBUS detection. */
> atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>;
> pinctrl-names = "default";
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-10-06 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 14:56 [RFC PATCH] ARM: dts: at91: sama5d3_eds: remove TDES use nicolas.ferre
2023-10-06 8:15 ` claudiu beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=070a6f48-20a4-4e26-a071-0600a6ecea36@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=alexandre.belloni@bootlin.com \
--cc=jerry.ray@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).