From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B807FC54E4A for ; Fri, 8 Mar 2024 16:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n3Y9WD0txyef5izvVlYd1L2tlBWzyOlk8PfK/3OtsQw=; b=T7r9pbajSIlkWS c1sPdXZHZ6MtgPofycPzRq8cY/pAir4yc759NjcIEerWHBOhHDEi+IocR4Ss/S0LjqBpWBCQK4SpY 23BdI1kAEQ/0Of2Bu8cmPFsjiRGkqazP2nqBgOK6quPysn+NTwh+x3rTwYkBfDDxcEV0GyGr7Gfyn ivq+YcMmVdSGux8brHkL2blPr0kVqws7oVjyD68SZdWqw4L8rSjFabl1O/kfQW7nopYkeC2PK1WF2 HYaFwLJPflaUdGsqJBgK2yjsM6XoSlrep9lpUIvsG1wWrcdMDfX4ohp0+XpTz5zxGxicHkUoTaI4j SsD0U5yPerYRqBGayFZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ridLJ-0000000AGaF-2iLy; Fri, 08 Mar 2024 16:45:09 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ridLG-0000000AGYS-2WIJ for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 16:45:08 +0000 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-56759dc7ea6so2967796a12.1 for ; Fri, 08 Mar 2024 08:45:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709916305; x=1710521105; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=moh66olstaqC8k5HVpIpRheeNiWvToG+jcGIMhhKvEQ=; b=tcT++NDN7QEE4jt08Hyi7wwl3pTGlIfSZbCv9wFG0UE57QpUVb4VRSYG+s2l6rWGuA pci1kMSw/zxQMM7O23Si0/Vm82LQwOVtM6ACPFOMPLwY49HWMHB+MJFczudT+k0EFRcX IWy3bpizWeyswDlioD2ZZ7b2Ma4RStWx4eNct+Eok6N8nonxzn6sBaj37D3Su9lncjDK Em9ODMAni7nnDuVNdDpqcOlBZFXAN8ouMLr7zK5j04ovwzKCYtlM7sC8uwemnUwa+a4/ ZmDB+xqCqgh+1VXocrSTdOItSKzahj7I3+R+rzhzqJen1ieO94I84UxDhnbNYic437Fd ZtvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709916305; x=1710521105; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=moh66olstaqC8k5HVpIpRheeNiWvToG+jcGIMhhKvEQ=; b=I4aKmEGFOgh54uxM+4oc7CJwyQSiZVr3YqnPxMh7l88DUD4wcVfarpET/Nxd9TAMOo wOlBT0TJFeWzacESNHWTUZcjYJfg/EgGrtz9k4zhgoqKNyeKC2vFDyhEXetCFE36UXyn ej5SyaNJ1c0QY+Kvaej7KFcdlifOE2Bu8lzGCtuMZbl4sUqYL3seCpHS4frC1PlLzN8E NQSmgCXpshrkUjfyPCOQj4xU7mgDsFqZJcvFhF/gtl8DarfcTsADUtQXZBlBq0mBxIeO 69aOrGKHJqLIchJmXDBDE+Lu3bUZ+w6hBma6ZL6AH2bilyG9kl2ZLe6Umo0HmMqLgeXt mA6g== X-Forwarded-Encrypted: i=1; AJvYcCUo6It5j112MRkhBTW2qDXV8c2r6vSlYYr9fw75dCYc+ft5AFQy1Q2CIpSP8aw2XapfcGqqzla+NNxFDMka+RE9tPe3JEKa5nsgfDvRGAoJZlQaGq4= X-Gm-Message-State: AOJu0Yz995PY/FznRy53FkDAa2/gfxE45H2UEeUKRVC1dA/cXnbOqFhP DVhNEUkABo/ri7mcLQCC+fyJ7YzBuusc1BZO8Hm7kQ0M8MQPdKa5GgAefPkw8/M= X-Google-Smtp-Source: AGHT+IGgOJa5fGQAYguh/4UFR66rws120+N7SzDoxZcxxrmB2tQoaSRdoEbnXKojUbpsWK7Cb159UA== X-Received: by 2002:a50:d704:0:b0:568:1b9f:d6b3 with SMTP id t4-20020a50d704000000b005681b9fd6b3mr2074156edi.40.1709916304658; Fri, 08 Mar 2024 08:45:04 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id j29-20020a508a9d000000b0056636a98652sm9702141edj.82.2024.03.08.08.45.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Mar 2024 08:45:04 -0800 (PST) Message-ID: <073e5ef5-2a2e-4300-93d6-e25552276e13@linaro.org> Date: Fri, 8 Mar 2024 17:45:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: exynos: gs101: define all PERIC USI nodes Content-Language: en-US To: Tudor Ambarus , peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, willmcvicker@google.com, kernel-team@android.com References: <20240307135912.163996-1-tudor.ambarus@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240307135912.163996-1-tudor.ambarus@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_084506_841379_F900F183 X-CRM114-Status: GOOD ( 18.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/03/2024 14:59, Tudor Ambarus wrote: > Universal Serial Interface (USI) supports three types of serial > interface such as UART, SPI and I2C. Each protocol works independently. > USI can be configured to work as one of these protocols. Define all the > USI nodes from the PERIC blocks (USI0-14), in all their possible > configurations. These blocks have the TX/RX FIFO depth of 64 bytes. > > Signed-off-by: Tudor Ambarus > --- > Please note that: > - google,gs101-spi compatible was queued through the SPI tree: > https://lore.kernel.org/linux-arm-kernel/170742731537.2266792.3851016361229293846.b4-ty@kernel.org/ > - SPI dma properties were marked as not requiered. Queued through the > SPI tree: > https://lore.kernel.org/linux-spi/170967132774.228925.1759895846287455970.b4-ty@kernel.org/ > > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 782 +++++++++++++++++++ > 1 file changed, 782 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > index ee65ed9d2cfc..d7ecfbc7e440 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > @@ -373,6 +373,398 @@ pinctrl_peric0: pinctrl@10840000 { > interrupts = ; > }; > > + usi1: usi@109000c0 { > + compatible = "google,gs101-usi", > + "samsung,exynos850-usi"; This should fit within 81 characters, which is pretty close to 80, so if there is going to be any resend/new version, please join the lines. > + reg = <0x109000c0 0x20>; > + ranges; > + #address-cells = <1>; > + #size-cells = <1>; > + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_0>, > + <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_0>; > + clock-names = "pclk", "ipclk"; > + samsung,sysreg = <&sysreg_peric0 0x1000>; > + status = "disabled"; > + > + hsi2c_1: i2c@10900000 { > + compatible = "google,gs101-hsi2c", > + "samsung,exynosautov9-hsi2c"; > + reg = <0x10900000 0xc0>; > + interrupts = ; I wonder why we use four cells in GIC... > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&hsi2c1_bus>; Please reverse two lines, first pinctrl-0 then pinctrl-names. I know we did not follow this convention till now, but at least new code can be correct. Also clocks should be before pinctrl, so we keep some sort of alphabetical order. It is anyway too late in the cycle for me to pick it up, so no need to hurry with resend. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel